Stop reusing xref object nrs & edit tests to fit

DEVSIX-1428

Author: Benoit Lagae

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfXrefTable.java

@@ -116,20 +116,8 @@ public PdfIndirectReference get(int index) {
      * @return created indirect reference.
      */
     protected PdfIndirectReference createNextIndirectReference(PdfDocument document) {
-        PdfIndirectReference reference;
-        if (freeReferences.size() > 0) {
-            int num = (int) freeReferences.pollFirst();
-            reference = xref[num];
-            if (reference == null) {
-                reference = new PdfIndirectReference(document, num);
-                xref[num] = reference;
-            }
-            reference.setOffset(0);
-            reference.clearState(PdfObject.FREE);
-        } else {
-            reference = new PdfIndirectReference(document, ++count);
-            add(reference);
-        }
+        PdfIndirectReference reference = new PdfIndirectReference(document, ++count);
+        add(reference);
         return reference.setState(PdfObject.MODIFIED);
     }
 

kernel/src/test/java/com/itextpdf/kernel/pdf/PdfPagesTest.java

@@ -171,7 +171,7 @@ public void randomObjectPagesTest() throws IOException {
         PdfPage testPage = document.removePage(1000);
         Assert.assertTrue(testPage.getPdfObject().getIndirectReference() == null);
         document.addPage(1000, testPage);
-        Assert.assertTrue(testPage.getPdfObject().getIndirectReference().getObjNumber() < xrefSize);
+        Assert.assertTrue(testPage.getPdfObject().getIndirectReference().getObjNumber() == xrefSize);
 
         for (int i = 0; i < pages.length; i++) {
             Assert.assertEquals("Remove page", true, document.removePage(pages[i]));

kernel/src/test/java/com/itextpdf/kernel/pdf/PdfReaderTest.java

@@ -375,7 +375,7 @@ public void pagesTest01() throws IOException {
 
         Assert.assertTrue(testPage.getPdfObject().getIndirectReference() == null);
         document.addPage(1000, testPage);
-        Assert.assertTrue(testPage.getPdfObject().getIndirectReference().getObjNumber() < xrefSize);
+        Assert.assertTrue(testPage.getPdfObject().getIndirectReference().getObjNumber() == xrefSize);
 
         for (int i = 1; i < document.getNumberOfPages() + 1; i++) {
             PdfPage page = document.getPage(i);