Distinguish between the whole row being partially placed and only certain cells being able to be placed

These changes fix an infinite loop

DEVSIX-3356

Author: ars18wrw

layout/src/main/java/com/itextpdf/layout/renderer/TableRenderer.java

@@ -888,7 +888,13 @@ public LayoutResult layout(LayoutContext layoutContext) {
                 }
                 // Apply borders if there is no footer
                 if (null == footerRenderer) {
-                    if (0 != this.childRenderers.size()) {
+                    // If split renderer does not have any rows, it can mean two things:
+                    // - either nothing is placed and the top border, which have been already applied,
+                    // should be reverted
+                    // - or the only placed row is placed partially.
+                    // In the latter case the number of added child renderers should equal to the number of the cells
+                    // in the current row (currChildRenderers stands for it)
+                    if (!splitResult[0].rows.isEmpty() || currChildRenderers.size() == childRenderers.size()) {
                         bordersHandler.applyBottomTableBorder(occupiedArea.getBBox(), layoutBox, false);
                     } else {
                         bordersHandler.applyTopTableBorder(occupiedArea.getBBox(), layoutBox, true);

layout/src/test/java/com/itextpdf/layout/TableTest.java

@@ -3054,6 +3054,74 @@ public void inheritHeaderPropsWhileMinMaxWidthCalculationsTest() throws IOExcept
                 sourceFolder + "cmp_" + filename, destinationFolder, "diff"));
     }
 
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = LogMessageConstant.ELEMENT_DOES_NOT_FIT_AREA)
+    })
+    public void infiniteLoopOnUnfitCellAndBigRowspanTest() throws IOException, InterruptedException {
+        String testName = "infiniteLoopOnUnfitCellAndBigRowspanTest.pdf";
+        String outFileName = destinationFolder + testName;
+        String cmpFileName = sourceFolder + "cmp_" + testName;
+
+        PdfDocument pdfDoc = new PdfDocument(new PdfWriter(outFileName));
+        Document doc = new Document(pdfDoc, PageSize.A4.rotate());
+
+        Table table = new Table(38);
+        table.useAllAvailableWidth();
+        table.setFixedLayout();
+
+        Cell cellNum1 = new Cell(1, 1);
+        table.addCell(cellNum1);
+
+        Cell cellNum2 = new Cell(2, 2);
+        Image img = new Image(ImageDataFactory.create(sourceFolder + "itext.png"));
+        cellNum2.add(img);
+        table.addCell(cellNum2);
+
+        Cell cellNum3 = new Cell(2, 36);
+        cellNum3.add(new Paragraph("text"));
+        table.addCell(cellNum3);
+
+        doc.add(table);
+        doc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(outFileName, cmpFileName, destinationFolder, testName + "_diff"));
+    }
+
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = LogMessageConstant.ELEMENT_DOES_NOT_FIT_AREA),
+            @LogMessage(messageTemplate = LogMessageConstant.TABLE_WIDTH_IS_MORE_THAN_EXPECTED_DUE_TO_MIN_WIDTH)
+    })
+    public void firstRowNotFitBigRowspanTest() throws IOException, InterruptedException {
+        String testName = "firstRowNotFitBigRowspanTest.pdf";
+        String outFileName = destinationFolder + testName;
+        String cmpFileName = sourceFolder + "cmp_" + testName;
+
+        PdfDocument pdfDoc = new PdfDocument(new PdfWriter(outFileName));
+        Document doc = new Document(pdfDoc, PageSize.A4);
+
+        Table table = new Table(4);
+
+        table.addCell("row 1 col 1");
+
+        Cell notFitCell = new Cell(2, 1);
+        notFitCell.add(new Paragraph("row 1-2 col 2"));
+        notFitCell.setFontSize(1000);
+        table.addCell(notFitCell);
+
+        Cell fitCell = new Cell(2, 2);
+        fitCell.add(new Paragraph("row 1-2 col 3-4"));
+        table.addCell(fitCell);
+
+        table.addCell("row 2 col 1");
+
+        doc.add(table);
+        doc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(outFileName, cmpFileName, destinationFolder, testName + "_diff"));
+    }
+
     @Test
     // TODO DEVSIX-5250 The first column should be fully red
     public void bigRowSpanTooFarFullTest() throws IOException, InterruptedException {