Add safe-guard check if occupiedArea is initialized in renderers #move method

DEVSIX-6760

Author: Alexander Kozlov

layout/src/main/java/com/itextpdf/layout/renderer/AbstractRenderer.java

@@ -1182,6 +1182,12 @@ public IRenderer getParent() {
      */
     @Override
     public void move(float dxRight, float dyUp) {
+        Logger logger = LoggerFactory.getLogger(AbstractRenderer.class);
+        if (occupiedArea == null) {
+            logger.error(MessageFormatUtil.format(IoLogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED,
+                    "Moving won't be performed."));
+            return;
+        }
         occupiedArea.getBBox().moveRight(dxRight);
         occupiedArea.getBBox().moveUp(dyUp);
         for (IRenderer childRenderer : childRenderers) {

layout/src/main/java/com/itextpdf/layout/renderer/ParagraphRenderer.java

@@ -44,6 +44,7 @@ This file is part of the iText (R) project.
 package com.itextpdf.layout.renderer;
 
 import com.itextpdf.commons.utils.MessageFormatUtil;
+import com.itextpdf.io.logs.IoLogMessageConstant;
 import com.itextpdf.kernel.geom.Rectangle;
 import com.itextpdf.layout.borders.Border;
 import com.itextpdf.layout.element.Paragraph;
@@ -68,6 +69,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.properties.TextAlignment;
 import com.itextpdf.layout.properties.UnitValue;
 
+import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.util.ArrayList;
@@ -572,6 +574,12 @@ public void drawChildren(DrawContext drawContext) {
      */
     @Override
     public void move(float dxRight, float dyUp) {
+        Logger logger = LoggerFactory.getLogger(ParagraphRenderer.class);
+        if (occupiedArea == null) {
+            logger.error(MessageFormatUtil.format(IoLogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED,
+                    "Moving won't be performed."));
+            return;
+        }
         occupiedArea.getBBox().moveRight(dxRight);
         occupiedArea.getBBox().moveUp(dyUp);
         if (null != lines) {

layout/src/test/java/com/itextpdf/layout/FixedHeightTest.java

@@ -0,0 +1,104 @@
+package com.itextpdf.layout;
+
+import com.itextpdf.io.logs.IoLogMessageConstant;
+import com.itextpdf.kernel.colors.ColorConstants;
+import com.itextpdf.kernel.pdf.PdfDocument;
+import com.itextpdf.kernel.pdf.PdfWriter;
+import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.layout.borders.SolidBorder;
+import com.itextpdf.layout.element.Div;
+import com.itextpdf.layout.element.List;
+import com.itextpdf.layout.element.Paragraph;
+import com.itextpdf.layout.element.Text;
+import com.itextpdf.test.ExtendedITextTest;
+import com.itextpdf.test.annotations.LogMessage;
+import com.itextpdf.test.annotations.LogMessages;
+import com.itextpdf.test.annotations.type.IntegrationTest;
+
+import java.io.IOException;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category(IntegrationTest.class)
+public class FixedHeightTest extends ExtendedITextTest {
+
+    private static final String sourceFolder = "./src/test/resources/com/itextpdf/layout/FloatAndAlignmentTest/";
+    private static final String destinationFolder = "./target/test/com/itextpdf/layout/FloatAndAlignmentTest/";
+
+    private static final String textByron =
+            "When a man hath no freedom to fight for at home,\n" +
+                    "    Let him combat for that of his neighbours;\n" +
+                    "Let him think of the glories of Greece and of Rome,\n" +
+                    "    And get knocked on the head for his labours.\n" +
+                    "\n" +
+                    "To do good to Mankind is the chivalrous plan,\n" +
+                    "    And is always as nobly requited;\n" +
+                    "Then battle for Freedom wherever you can,\n" +
+                    "    And, if not shot or hanged, you'll get knighted.";
+
+    @BeforeClass
+    public static void beforeClass() {
+        createOrClearDestinationFolder(destinationFolder);
+    }
+
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = IoLogMessageConstant.CLIP_ELEMENT, count = 1),
+            // TODO DEVSIX-1977 partial layout result due to fixed height should not contain not layouted kids
+            @LogMessage(messageTemplate = IoLogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, count = 6)
+    })
+    @Test
+    public void divWithParagraphsAndFixedPositionTest() throws IOException, InterruptedException {
+        String outFileName = destinationFolder + "blockWithLimitedHeightAndFixedPositionTest.pdf";
+        String cmpFileName = sourceFolder + "cmp_blockWithLimitedHeightAndFixedPositionTest.pdf";
+        PdfDocument pdfDocument = new PdfDocument(new PdfWriter(outFileName));
+
+        Document doc = new Document(pdfDocument);
+
+        Div block = new Div();
+        block.setBorder(new SolidBorder(ColorConstants.BLUE, 1));
+        block.setHeight(120);
+
+        for (String line : textByron.split("\n")) {
+            Paragraph p = new Paragraph();
+            p.add(new Text(line));
+            p.setBorder(new SolidBorder(0.5f));
+            block.add(p);
+        }
+        block.setFixedPosition(100, 600, 300);
+        doc.add(block);
+
+        doc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(outFileName, cmpFileName, destinationFolder));
+    }
+
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = IoLogMessageConstant.CLIP_ELEMENT, count = 1),
+            // TODO DEVSIX-1977 partial layout result due to fixed height should not contain not layouted kids
+            @LogMessage(messageTemplate = IoLogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, count = 2)
+    })
+    @Test
+    public void listWithFixedPositionTest() throws IOException, InterruptedException {
+        String outFileName = destinationFolder + "listWithFixedPositionTest.pdf";
+        String cmpFileName = sourceFolder + "cmp_listWithFixedPositionTest.pdf";
+        PdfDocument pdfDocument = new PdfDocument(new PdfWriter(outFileName));
+
+        Document doc = new Document(pdfDocument);
+
+        List list = new List();
+        list.setBorder(new SolidBorder(ColorConstants.BLUE, 1));
+        list.setHeight(120);
+
+        for (String line : textByron.split("\n")) {
+            list.add(line);
+        }
+        list.setFixedPosition(100, 600, 300);
+        doc.add(list);
+
+        doc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(outFileName, cmpFileName, destinationFolder));
+    }
+}