Improve code coverage for DefaultITextProductEventProcessor

DEVSIX-5706

Author: yulian-gaponenko

commons/src/main/java/com/itextpdf/commons/actions/processors/DefaultITextProductEventProcessor.java

@@ -36,9 +36,7 @@ This file is part of the iText (R) project.
  */
 public class DefaultITextProductEventProcessor extends AbstractITextProductEventProcessor {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(DefaultITextProductEventProcessor.class);
-
-    private static final byte[] messageForLogging = Base64
+    static final byte[] MESSAGE_FOR_LOGGING = Base64
             .decode("WW91IGFyZSB1c2luZyBpVGV4dCB1bmRlciB0aGUgQUdQTC4KCklmIHRoaXMgaXMgeW9"
                     + "1ciBpbnRlbnRpb24sIHlvdSBoYXZlIHB1Ymxpc2hlZCB5b3VyIG93biBzb3VyY2UgY2"
                     + "9kZSBhcyBBR1BMIHNvZnR3YXJlIHRvby4KUGxlYXNlIGxldCB1cyBrbm93IHdoZXJlI"
@@ -54,6 +52,8 @@ public class DefaultITextProductEventProcessor extends AbstractITextProductEvent
                     + "byBhdm9pZCB0aGlzIG1lc3NhZ2UuCklmIHlvdSdyZSBub3QgYSBjdXN0b21lciwgd2U"
                     + "nbGwgZXhwbGFpbiB0aGUgYmVuZWZpdHMgb2YgYmVjb21pbmcgYSBjdXN0b21lci4=");
 
+    private static final Logger LOGGER = LoggerFactory.getLogger(DefaultITextProductEventProcessor.class);
+
     private static final long[] REPEAT = {10000L, 5000L, 1000L};
 
     private static final int MAX_LVL = REPEAT.length - 1;
@@ -73,7 +73,7 @@ public class DefaultITextProductEventProcessor extends AbstractITextProductEvent
      */
     public DefaultITextProductEventProcessor(String productName) {
         super(productName);
-        repeatLevel = new AtomicLong(REPEAT[(int) level.get()]);
+        repeatLevel = new AtomicLong(acquireRepeatLevel((int) level.get()));
     }
 
     @Override
@@ -88,13 +88,13 @@ public void onEvent(AbstractProductProcessITextEvent event) {
                 if (level.incrementAndGet() > MAX_LVL) {
                     level.set(MAX_LVL);
                 }
-                repeatLevel.set(REPEAT[(int) level.get()]);
+                repeatLevel.set(acquireRepeatLevel((int) level.get()));
                 isNeededToLogMessage = true;
             }
         }
 
         if (isNeededToLogMessage) {
-            String message = new String(messageForLogging, StandardCharsets.ISO_8859_1);
+            String message = new String(MESSAGE_FOR_LOGGING, StandardCharsets.ISO_8859_1);
             LOGGER.info(message);
             System.out.println(message);
         }
@@ -104,4 +104,8 @@ public void onEvent(AbstractProductProcessITextEvent event) {
     public String getUsageType() {
         return "AGPL";
     }
+
+    long acquireRepeatLevel(int lvl) {
+        return REPEAT[lvl];
+    }
 }

commons/src/test/java/com/itextpdf/commons/actions/processors/DefaultITextProductEventProcessorTest.java

@@ -22,24 +22,74 @@ This file is part of the iText (R) project.
  */
 package com.itextpdf.commons.actions.processors;
 
+import com.itextpdf.commons.actions.confirmations.ConfirmEvent;
+import com.itextpdf.commons.actions.data.CommonsProductData;
+import com.itextpdf.commons.actions.sequence.SequenceId;
+import com.itextpdf.commons.ecosystem.ITextTestEvent;
 import com.itextpdf.commons.exceptions.CommonsExceptionMessageConstant;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
+import com.itextpdf.test.LogLevelConstants;
+import com.itextpdf.test.annotations.LogMessage;
+import com.itextpdf.test.annotations.LogMessages;
 import com.itextpdf.test.annotations.type.UnitTest;
 
-import org.junit.Rule;
+import org.junit.Assert;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
-import org.junit.rules.ExpectedException;
 
 @Category(UnitTest.class)
 public class DefaultITextProductEventProcessorTest extends ExtendedITextTest {
-    @Rule
-    public ExpectedException junitExpectedException = ExpectedException.none();
 
     @Test
     public void constructorWithNullProductNameTest() {
-        junitExpectedException.expect(IllegalArgumentException.class);
-        junitExpectedException.expectMessage(CommonsExceptionMessageConstant.PRODUCT_NAME_CAN_NOT_BE_NULL);
-        new DefaultITextProductEventProcessor(null);
+        Exception e =
+                Assert.assertThrows(IllegalArgumentException.class, () -> new DefaultITextProductEventProcessor(null));
+        Assert.assertEquals(CommonsExceptionMessageConstant.PRODUCT_NAME_CAN_NOT_BE_NULL, e.getMessage());
+    }
+
+    @Test
+    @LogMessages(messages = @LogMessage(messageTemplate = "{0} you are probably {1}", logLevel = LogLevelConstants.INFO))
+    public void messageIsLoggedTest() {
+        TestDefaultITextProductEventProcessor testProcessor = new TestDefaultITextProductEventProcessor();
+        ITextTestEvent e = new ITextTestEvent(new SequenceId(), CommonsProductData.getInstance(), null, "test event");
+        AssertUtil.doesNotThrow(() -> testProcessor.onEvent(new ConfirmEvent(e)));
+    }
+
+    @Test
+    @LogMessages(messages =
+        @LogMessage(messageTemplate = "{0} you are probably {1}", logLevel = LogLevelConstants.INFO, count = 4)
+    )
+    public void messageIsLoggedThreeTimesTest() {
+        int iterationsNumber = 15;
+        // "1" correspond to expected iterations with log messages:
+        // 1 0 0 0 0
+        // 0 1 0 0 0
+        // 1 0 0 0 1
+        TestDefaultITextProductEventProcessor testProcessor = new TestDefaultITextProductEventProcessor();
+        ITextTestEvent e = new ITextTestEvent(new SequenceId(), CommonsProductData.getInstance(), null, "test event");
+        for (int i = 0; i < iterationsNumber; ++i) {
+            AssertUtil.doesNotThrow(() -> testProcessor.onEvent(new ConfirmEvent(e)));
+        }
+    }
+
+    private static class TestDefaultITextProductEventProcessor extends DefaultITextProductEventProcessor {
+
+        public TestDefaultITextProductEventProcessor() {
+            super("test product");
+        }
+
+        @Override
+        long acquireRepeatLevel(int lvl) {
+            switch (lvl) {
+                case 0:
+                    return 0;
+                case 1:
+                    return 5;
+                case 2:
+                    return 3;
+            }
+            return 0;
+        }
     }
 }