Resolve TODOs in CssPageRule and MediaExpression

DEVSIX-6348

Author: Evgeniy Prudnikov

styled-xml-parser/src/main/java/com/itextpdf/styledxmlparser/css/media/MediaExpression.java

@@ -203,7 +203,8 @@ public boolean matches(MediaDeviceDescription deviceDescription) {
      */
     private static float parseAbsoluteLength(String value) {
         if (CssTypesValidationUtils.isRelativeValue(value)) {
-            // TODO here should be used default font size of the browser, it probably should be fetched from the more generic place than private class constant
+            // TODO Use some shared default value (from default.css or CssDefaults)
+            //      rather than a constant of this class
             return CssDimensionParsingUtils.parseRelativeValue(value, DEFAULT_FONT_SIZE);
         } else {
             return CssDimensionParsingUtils.parseAbsoluteLength(value);

styled-xml-parser/src/main/java/com/itextpdf/styledxmlparser/css/page/CssMarginRule.java

@@ -72,6 +72,7 @@ public CssMarginRule(String ruleName) {
      */
     @Override
     public void addBodyCssDeclarations(List<CssDeclaration> cssDeclarations) {
+        // TODO DEVSIX-6364 Fix the body declarations duplication for each pageSelector part
         for (ICssSelector pageSelector : pageSelectors) {
             this.body.add(new CssNonStandardRuleSet(new CssPageMarginBoxSelector(getRuleName(), pageSelector), cssDeclarations));
         }

styled-xml-parser/src/main/java/com/itextpdf/styledxmlparser/css/page/CssPageRule.java

@@ -85,16 +85,17 @@ public CssPageRule(String ruleParameters) {
      */
     @Override
     public void addBodyCssDeclarations(List<CssDeclaration> cssDeclarations) {
-        // TODO Due to this for-loop, on toString method call for the CssPageRule instance
+        // TODO DEVSIX-6364 Fix the body declarations duplication for each pageSelector part
+        //      Due to this for-loop, on toString method call for the CssPageRule instance
         //      all the body declarations will be duplicated for each pageSelector part.
         //      This potentially could lead to a nasty behaviour when declarations will double
-        //      for each read-write iteration of the same css-file (however, this use case seems 
-        //      to be unlikely to happen). 
-        //      Possible solution would be to split single page rule with compound selector into 
+        //      for each read-write iteration of the same css-file (however, this use case seems
+        //      to be unlikely to happen).
+        //      Possible solution would be to split single page rule with compound selector into
         //      several page rules with simple selectors on addition of the page rule to it's parent.
         //
         //      Also, the same concerns this method implementation in CssMarginRule class.
-        //      
+        //
         //      See CssStyleSheetParserTest#test11 test.
         for (ICssSelector pageSelector : pageSelectors) {
             this.body.add(new CssNonStandardRuleSet(pageSelector, cssDeclarations));

styled-xml-parser/src/test/java/com/itextpdf/styledxmlparser/css/parse/CssStyleSheetParserTest.java

@@ -135,10 +135,8 @@ public void test10() throws IOException {
     }
 
     @Test
+    // TODO DEVSIX-6364 Fix the body declarations duplication for each pageSelector part
     public void test11() throws IOException {
-        // TODO in this test declarations of the page at-rule with compound selector are duplicated.
-        // See CssPageRule#addBodyCssDeclarations() method for the reason and possible solution if this becomes important.
-
         String cssFile = sourceFolder + "css11.css";
         String cmpFile = sourceFolder + "cmp_css11.css";
         CssStyleSheet styleSheet = CssStyleSheetParser.parse(new FileInputStream(cssFile));