Add new test demonstratic incorrect total page count when last page is trimmed

Snipx · iText-CI · commit 1a98816c32a2 · 2021-06-07T16:00:52.000Z
DEVSIX-5509

Autoported commit.
Original commit hash: [a9bca9c2]
diff --git a/itext.tests/itext.html2pdf.tests/itext/html2pdf/attach/impl/layout/PageCountRendererTest.cs b/itext.tests/itext.html2pdf.tests/itext/html2pdf/attach/impl/layout/PageCountRendererTest.cs
@@ -32,13 +32,13 @@ public class PageCountRendererTest : ExtendedITextTest {
         [NUnit.Framework.Test]
         [LogMessage(iText.IO.LogMessageConstant.GET_NEXT_RENDERER_SHOULD_BE_OVERRIDDEN)]
         public virtual void GetNextRendererShouldBeOverriddenTest() {
-            PageCountRenderer pageCountRenderer = new _PageCountRenderer_51(new PageCountElement());
+            PageCountRenderer pageCountRenderer = new _PageCountRenderer_50(new PageCountElement());
             // Nothing is overridden
             NUnit.Framework.Assert.AreEqual(typeof(PageCountRenderer), pageCountRenderer.GetNextRenderer().GetType());
         }
 
-        private sealed class _PageCountRenderer_51 : PageCountRenderer {
-            public _PageCountRenderer_51(PageCountElement baseArg1)
+        private sealed class _PageCountRenderer_50 : PageCountRenderer {
+            public _PageCountRenderer_50(PageCountElement baseArg1)
                 : base(baseArg1) {
             }
         }
diff --git a/itext.tests/itext.html2pdf.tests/itext/html2pdf/css/CounterTest.cs b/itext.tests/itext.html2pdf.tests/itext/html2pdf/css/CounterTest.cs
@@ -85,5 +85,11 @@ public virtual void PageCounter04Test() {
         public virtual void PageCounterSpacesInDeclarationTest() {
             ConvertToPdfAndCompare("page_counter_spaces_in_declaration", sourceFolder, destinationFolder);
         }
+
+        [NUnit.Framework.Test]
+        public virtual void PageCounterWithTrimmedLastPageTest() {
+            // TODO fix cmp after DEVSIX-5509 is done; currently total page count is incorrect
+            ConvertToPdfAndCompare("page_counter_with_trimmed_last_page", sourceFolder, destinationFolder);
+        }
     }
 }
diff --git a/itext.tests/itext.html2pdf.tests/resources/itext/html2pdf/css/CounterTest/cmp_page_counter_with_trimmed_last_page.pdf b/itext.tests/itext.html2pdf.tests/resources/itext/html2pdf/css/CounterTest/cmp_page_counter_with_trimmed_last_page.pdf
diff --git a/itext.tests/itext.html2pdf.tests/resources/itext/html2pdf/css/CounterTest/page_counter_with_trimmed_last_page.html b/itext.tests/itext.html2pdf.tests/resources/itext/html2pdf/css/CounterTest/page_counter_with_trimmed_last_page.html
@@ -0,0 +1,16 @@
+<html>
+<head>
+    <style>
+        @page {
+            @top-left {
+                content: "Page " counter(page) " / " counter(pages);
+            }
+        }</style>
+</head>
+
+<body>
+<div><span>Text on first page</span></div>
+<div style="page-break-after:always"></div>
+<div></div>
+</body>
+</html>
diff --git a/port-hash b/port-hash
@@ -1 +1 @@
-65c57aee596ba14d0ac28e5da6da2d8fb1c7b1a4
+a9bca9c275e780d5ecf4b1eb219b7e374c8c9988

Original file line number	Diff line number	Diff line change
`@@ -32,13 +32,13 @@ public class PageCountRendererTest : ExtendedITextTest {`
`32`	`32`	`[NUnit.Framework.Test]`
`33`	`33`	`[LogMessage(iText.IO.LogMessageConstant.GET_NEXT_RENDERER_SHOULD_BE_OVERRIDDEN)]`
`34`	`34`	`public virtual void GetNextRendererShouldBeOverriddenTest() {`
`35`		`- PageCountRenderer pageCountRenderer = new _PageCountRenderer_51(new PageCountElement());`
	`35`	`+ PageCountRenderer pageCountRenderer = new _PageCountRenderer_50(new PageCountElement());`
`36`	`36`	`// Nothing is overridden`
`37`	`37`	`NUnit.Framework.Assert.AreEqual(typeof(PageCountRenderer), pageCountRenderer.GetNextRenderer().GetType());`
`38`	`38`	`}`
`39`	`39`
`40`		`- private sealed class _PageCountRenderer_51 : PageCountRenderer {`
`41`		`- public _PageCountRenderer_51(PageCountElement baseArg1)`
	`40`	`+ private sealed class _PageCountRenderer_50 : PageCountRenderer {`
	`41`	`+ public _PageCountRenderer_50(PageCountElement baseArg1)`
`42`	`42`	`: base(baseArg1) {`
`43`	`43`	`}`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,5 +85,11 @@ public virtual void PageCounter04Test() {`
`85`	`85`	`public virtual void PageCounterSpacesInDeclarationTest() {`
`86`	`86`	`ConvertToPdfAndCompare("page_counter_spaces_in_declaration", sourceFolder, destinationFolder);`
`87`	`87`	`}`
	`88`	`+`
	`89`	`+ [NUnit.Framework.Test]`
	`90`	`+ public virtual void PageCounterWithTrimmedLastPageTest() {`
	`91`	`+ // TODO fix cmp after DEVSIX-5509 is done; currently total page count is incorrect`
	`92`	`+ ConvertToPdfAndCompare("page_counter_with_trimmed_last_page", sourceFolder, destinationFolder);`
	`93`	`+ }`
`88`	`94`	`}`
`89`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-65c57aee596ba14d0ac28e5da6da2d8fb1c7b1a4`
	`1`	`+a9bca9c275e780d5ecf4b1eb219b7e374c8c9988`