Skip to content

Commit 2d64310

Browse files
AnhelinaMiText-CI
authored andcommitted
Fix issue with align-content space-between, space-around and space-evenly values in case gap is applied
DEVSIX-9473 Autoported commit. Original commit hash: [4ae8e2e51]
1 parent 7b18f49 commit 2d64310

31 files changed

+352
-9
lines changed

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/flex/FlexGapTest.cs

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,13 +166,28 @@ public virtual void GapAlignContentRowRevDirTest() {
166166

167167
[NUnit.Framework.Test]
168168
public virtual void GapAlignContentColumnDirTest() {
169-
// TODO DEVSIX-9473 Fix issues on page split
170169
ConvertToPdfAndCompare("gapAlignContentColumnDir", SOURCE_FOLDER, DESTINATION_FOLDER);
171170
}
172171

172+
[NUnit.Framework.Test]
173+
public virtual void GapAlignContentColumnDirPageSplitTest() {
174+
ConvertToPdfAndCompare("gapAlignContentColumnDirPageSplit", SOURCE_FOLDER, DESTINATION_FOLDER);
175+
}
176+
177+
[NUnit.Framework.Test]
178+
public virtual void GapAlignContentColumnDirSmallHeightTest() {
179+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
180+
ConvertToPdfAndCompare("gapAlignContentColumnDirSmallHeight", SOURCE_FOLDER, DESTINATION_FOLDER);
181+
}
182+
183+
[NUnit.Framework.Test]
184+
public virtual void GapAlignContentColumnDirSmallHeightWrapRevTest() {
185+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
186+
ConvertToPdfAndCompare("gapAlignContentColumnDirSmallHeightWrapRev", SOURCE_FOLDER, DESTINATION_FOLDER);
187+
}
188+
173189
[NUnit.Framework.Test]
174190
public virtual void GapAlignContentColumnRevDirTest() {
175-
// TODO DEVSIX-9473 Fix issues on page split
176191
ConvertToPdfAndCompare("gapAlignContentColumnRevDir", SOURCE_FOLDER, DESTINATION_FOLDER);
177192
}
178193

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/flex/PageSplitTest.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,13 @@ public virtual void AlignContentFlexEndWrapReverseTest() {
6969

7070
[NUnit.Framework.Test]
7171
public virtual void AlignContentCenterTest() {
72+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
7273
ConvertToPdfAndCompare("alignContentCenter", SOURCE_FOLDER, DESTINATION_FOLDER);
7374
}
7475

7576
[NUnit.Framework.Test]
7677
public virtual void AlignContentCenterWrapReverseTest() {
78+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
7779
ConvertToPdfAndCompare("alignContentCenterWrapReverse", SOURCE_FOLDER, DESTINATION_FOLDER);
7880
}
7981

@@ -159,11 +161,13 @@ public virtual void RowRevAlignContentFlexEndWrapReverseTest() {
159161

160162
[NUnit.Framework.Test]
161163
public virtual void RowRevAlignContentCenterTest() {
164+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
162165
ConvertToPdfAndCompare("rowRevAlignContentCenter", SOURCE_FOLDER, DESTINATION_FOLDER);
163166
}
164167

165168
[NUnit.Framework.Test]
166169
public virtual void RowRevAlignContentCenterWrapReverseTest() {
170+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
167171
ConvertToPdfAndCompare("rowRevAlignContentCenterWrapReverse", SOURCE_FOLDER, DESTINATION_FOLDER);
168172
}
169173

itext.tests/itext.html2pdf.tests/resources/itext/html2pdf/css/flex/FlexGapTest/colGapAlignContent.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
<div class="item">8</div>
6363
</div>
6464

65-
<!-- Incorrect layout on page split -->
6665
<div class="sample" style="align-content: space-between;">
6766
<div class="item">1</div>
6867
<div class="item">2</div>

0 commit comments

Comments
 (0)