Skip to content

Commit 505bd9a

Browse files
ars18wrwiText-CI
authored andcommitted
Remove outdated TODOs
The one in CssContentPropertyResolver seems to be already resolved, since we do float children The one in SpanTagCssApplier could have been done, but the code application seems to be quite dirty either in a css applier or in a node DEVSIX-6522 Autoported commit. Original commit hash: [2f98eedd3]
1 parent ca150a2 commit 505bd9a

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

itext/itext.html2pdf/itext/html2pdf/css/apply/impl/SpanTagCssApplier.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ public virtual void Apply(ProcessorContext context, IStylesContainer stylesConta
8282
}
8383
}
8484
}
85-
// TODO as for now spans are flattened, let's at least make kids of floating spans floating too
8685
String floatVal = cssStyles.Get(CssConstants.FLOAT);
8786
if (floatVal != null && !CssConstants.NONE.Equals(floatVal)) {
8887
foreach (IPropertyContainer elem in spanTagWorker.GetAllElements()) {

itext/itext.html2pdf/itext/html2pdf/css/resolve/CssContentPropertyResolver.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,6 @@ internal static IList<INode> ResolveContent(IDictionary<String, String> styles,
223223
if (token.GetValue().StartsWith("url(")) {
224224
IDictionary<String, String> attributes = new Dictionary<String, String>();
225225
attributes.Put(AttributeConstants.SRC, CssUtils.ExtractUrl(token.GetValue()));
226-
//TODO: probably should add user agent styles on CssContentElementNode creation, not here.
227226
attributes.Put(AttributeConstants.STYLE, CssConstants.DISPLAY + ":" + CssConstants.INLINE_BLOCK);
228227
result.Add(new CssContentElementNode(contentContainer, TagConstants.IMG, attributes));
229228
}

port-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
9c95a69439cecb5edad990936b80b0e5a18eb297
1+
2f98eedd3d5fe0f906b628657badbddb7ce3e0b5

0 commit comments

Comments
 (0)