Support grid-gap, grid-column-gap and grid-row-gap and log unsupported properties

DEVSIX-8376

Fix per code review, part 1

Autoported commit.
Original commit hash: [d16c1ad06]

Author: introfog

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/apply/util/GridApplierUtilTest.cs

@@ -439,6 +439,18 @@ public virtual void ContainerGapValuesTest() {
             NUnit.Framework.Assert.AreEqual(30, element.GetProperty<float?>(Property.ROW_GAP));
         }
 
+        [NUnit.Framework.Test]
+        public virtual void ContainerGridGapValuesTest() {
+            IDictionary<String, String> cssProps = new Dictionary<String, String>();
+            cssProps.Put(CssConstants.GRID_COLUMN_GAP, "11px");
+            cssProps.Put(CssConstants.GRID_ROW_GAP, "30%");
+            IElement element = new Div();
+            GridApplierUtil.ApplyGridContainerProperties(cssProps, element, new ProcessorContext(new ConverterProperties
+                ()));
+            NUnit.Framework.Assert.AreEqual(8.25f, element.GetProperty<float?>(Property.COLUMN_GAP));
+            NUnit.Framework.Assert.AreEqual(30, element.GetProperty<float?>(Property.ROW_GAP));
+        }
+
         [NUnit.Framework.Test]
         public virtual void ColumnFlowTest() {
             IDictionary<String, String> cssProps = new Dictionary<String, String>();

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/grid/GridGapTest.cs

@@ -173,6 +173,31 @@ public virtual void SmallValuesGapTest() {
             RunTest("small_values_gap");
         }
 
+        [NUnit.Framework.Test]
+        public virtual void DifferentRowsColsGapTest() {
+            RunTest("different_rows_cols_gap");
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void GridGapTest1() {
+            RunTest("gridGapTest1");
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void GridGapTest2() {
+            RunTest("gridGapTest2");
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void GridColumnGapTest() {
+            RunTest("gridColumnGapTest");
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void GridRowGapTest() {
+            RunTest("gridRowGapTest");
+        }
+
         private void RunTest(String testName) {
             ConvertToPdfAndCompare(testName, SOURCE_FOLDER, DESTINATION_FOLDER, false, new ConverterProperties().SetBaseUri
                 (SOURCE_FOLDER));

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/grid/GridTemplatesTest.cs

@@ -547,6 +547,8 @@ public virtual void AutoFitRepeatWithFlexMinMaxTest() {
             RunTest("autoFitRepeatWithFlexMinMaxTest");
         }
 
+        [LogMessage(Html2PdfLogMessageConstant.GRID_TEMPLATE_WAS_NOT_RECOGNISED, LogLevel = LogLevelConstants.WARN
+            )]
         [NUnit.Framework.Test]
         public virtual void RepeatInsideMinMaxTest() {
             RunTest("repeatInsideMinMaxTest");
@@ -626,13 +628,35 @@ public virtual void MaxHeightFlexRowsTest2() {
             RunTest("maxHeightFlexRowsTest2");
         }
 
-        [NUnit.Framework.Test]
         [LogMessage(Html2PdfLogMessageConstant.INVALID_CSS_PROPERTY_DECLARATION, LogLevel = LogLevelConstants.WARN
             )]
+        [NUnit.Framework.Test]
         public virtual void DivNestingTest() {
             RunTest("divNestingTest");
         }
 
+        [LogMessage(Html2PdfLogMessageConstant.SUBGRID_VALUE_IS_NOT_SUPPORTED, LogLevel = LogLevelConstants.WARN)]
+        [LogMessage(Html2PdfLogMessageConstant.GRID_TEMPLATE_WAS_NOT_RECOGNISED, LogLevel = LogLevelConstants.WARN
+            )]
+        [NUnit.Framework.Test]
+        public virtual void SubgridTest() {
+            RunTest("subgridTest");
+        }
+
+        [LogMessage(Html2PdfLogMessageConstant.GRID_TEMPLATE_WAS_NOT_RECOGNISED, LogLevel = LogLevelConstants.WARN
+            )]
+        [NUnit.Framework.Test]
+        public virtual void InvalidTemplateColumns() {
+            RunTest("invalidTemplateColumns");
+        }
+
+        [LogMessage(Html2PdfLogMessageConstant.GRID_TEMPLATE_WAS_NOT_RECOGNISED, LogLevel = LogLevelConstants.WARN
+            )]
+        [NUnit.Framework.Test]
+        public virtual void InvalidTemplateRows() {
+            RunTest("invalidTemplateRows");
+        }
+
         private void RunTest(String testName) {
             ConvertToPdfAndCompare(testName, SOURCE_FOLDER, DESTINATION_FOLDER, false, new ConverterProperties().SetBaseUri
                 (SOURCE_FOLDER));

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/w3c/css_flexbox/FlexboxColumnRowGap001Test.cs

@@ -26,7 +26,6 @@ You should have received a copy of the GNU Affero General Public License
 using iText.Test.Attributes;
 
 namespace iText.Html2pdf.Css.W3c.Css_flexbox {
-    //TODO DEVSIX-7554 change after column-gap is supported
     //TODO DEVSIX-7616 change after row-gap is supported
     //TODO DEVSIX-5164 change after align-content: space-around is supported
     //TODO DEVSIX-5163 change after more complex justify-content values are supported

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/w3c/css_flexbox/FlexboxColumnRowGap002Test.cs

@@ -26,7 +26,6 @@ You should have received a copy of the GNU Affero General Public License
 using iText.Test.Attributes;
 
 namespace iText.Html2pdf.Css.W3c.Css_flexbox {
-    //TODO DEVSIX-7554 change after column-gap is supported
     //TODO DEVSIX-7616 change after row-gap is supported
     //TODO DEVSIX-5164 change after align-content: flex-start is supported
     [LogMessage(Html2PdfLogMessageConstant.FLEX_PROPERTY_IS_NOT_SUPPORTED_YET, Count = 6)]

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/w3c/css_flexbox/FlexboxColumnRowGap003Test.cs

@@ -26,7 +26,6 @@ You should have received a copy of the GNU Affero General Public License
 using iText.Test.Attributes;
 
 namespace iText.Html2pdf.Css.W3c.Css_flexbox {
-    //TODO DEVSIX-7554 change after column-gap is supported
     //TODO DEVSIX-7616 change after row-gap is supported
     //TODO DEVSIX-5164 change after align-content: space-around is supported
     //TODO DEVSIX-5163 change after more complex justify-content values are supported

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/w3c/css_flexbox/FlexboxColumnRowGap004Test.cs

@@ -26,7 +26,6 @@ You should have received a copy of the GNU Affero General Public License
 using iText.Test.Attributes;
 
 namespace iText.Html2pdf.Css.W3c.Css_flexbox {
-    //TODO DEVSIX-7554 change after column-gap is supported
     //TODO DEVSIX-7616 change after row-gap is supported
     //TODO DEVSIX-5164 change after align-content: start is supported
     [LogMessage(Html2PdfLogMessageConstant.FLEX_PROPERTY_IS_NOT_SUPPORTED_YET, Count = 12)]