Skip to content

Commit 46a5900

Browse files
committed
Remove unnecessary log checks.
DEVSIX-2869
1 parent 04384d7 commit 46a5900

File tree

4 files changed

+1
-12
lines changed

4 files changed

+1
-12
lines changed

src/test/java/com/itextpdf/html2pdf/Html2PdfTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ public void aBlockInPTagTest() throws IOException, InterruptedException {
128128
}
129129

130130
@Test
131-
@LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 8)})
132131
public void base64svgTest() throws IOException, InterruptedException {
133132
HtmlConverter.convertToPdf(new File(sourceFolder + "objectTag_base64svg.html"), new File(destinationFolder + "objectTag_base64svg.pdf"));
134133
Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "objectTag_base64svg.pdf", sourceFolder + "cmp_objectTag_base64svg.pdf", destinationFolder, "diff01_"));
@@ -155,8 +154,7 @@ public void htmlObjectAltTextTest() throws IOException, InterruptedException {
155154
}
156155

157156
@Test
158-
@LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 8),
159-
@LogMessage(messageTemplate = LogMessageConstant.WORKER_UNABLE_TO_PROCESS_OTHER_WORKER, count = 1),})
157+
@LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.WORKER_UNABLE_TO_PROCESS_OTHER_WORKER, count = 1),})
160158
public void htmlObjectNestedObjectTest() throws IOException, InterruptedException {
161159
HtmlConverter.convertToPdf(new File(sourceFolder + "objectTag_nestedTag.html"), new File(destinationFolder + "objectTag_nestedTag.pdf"));
162160
Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "objectTag_nestedTag.pdf", sourceFolder + "cmp_objectTag_nestedTag.pdf", destinationFolder, "diff01_"));
@@ -165,7 +163,6 @@ public void htmlObjectNestedObjectTest() throws IOException, InterruptedExceptio
165163

166164

167165
@Test
168-
@LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 8)})
169166
public void htmlImgBase64SVGTest() throws IOException, InterruptedException {
170167
HtmlConverter.convertToPdf(new File(sourceFolder + "imgTag_base64svg.html"), new File(destinationFolder + "imgTag_base64svg.pdf"));
171168
Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "imgTag_base64svg.pdf", sourceFolder + "cmp_imgTag_base64svg.pdf", destinationFolder, "diff01_"));

src/test/java/com/itextpdf/html2pdf/ResourceResolverTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,6 @@ public void resourceResolverSvgWithImageInlineTest() throws IOException, Interru
360360
}
361361

362362
@Test
363-
@LogMessages(messages = @LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 1))
364363
public void resourceResolverSvgWithImageBackgroundTest() throws IOException, InterruptedException {
365364
//Browsers do not render this
366365
String baseUri = sourceFolder;
@@ -375,7 +374,6 @@ public void resourceResolverSvgWithImageBackgroundTest() throws IOException, Int
375374
}
376375

377376
@Test
378-
@LogMessages(messages = @LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 1))
379377
public void resourceResolverSvgWithImageObjectTest() throws IOException, InterruptedException {
380378
String baseUri = sourceFolder;
381379
String outPdf = destinationFolder + "resourceResolverSvgWithImageObject.pdf";

src/test/java/com/itextpdf/html2pdf/element/SvgTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ public void inlineSvgExternalFontUrlTest() throws IOException, InterruptedExcept
106106
@Test
107107
@LogMessages(messages = {
108108
@LogMessage(messageTemplate = com.itextpdf.styledxmlparser.LogMessageConstant.ERROR_PARSING_COULD_NOT_MAP_NODE),
109-
@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 4),
110109
})
111110
public void externalImageSuccessTest() throws IOException, InterruptedException {
112111
String name = "external_img";
@@ -130,7 +129,6 @@ public void externalImageNonExistentRefTest() throws IOException, InterruptedExc
130129
@Test
131130
@LogMessages(messages = {
132131
@LogMessage(messageTemplate = com.itextpdf.styledxmlparser.LogMessageConstant.ERROR_PARSING_COULD_NOT_MAP_NODE),
133-
@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 4),
134132
})
135133
public void externalObjectSuccessTest() throws IOException, InterruptedException {
136134
String name = "external_object";
@@ -139,8 +137,6 @@ public void externalObjectSuccessTest() throws IOException, InterruptedException
139137
}
140138

141139
@Test
142-
@LogMessages(messages = {
143-
@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 4)})
144140
public void externalObjectWithResourceTest() throws IOException, InterruptedException {
145141
//TODO update after DEVSIX-2239
146142
String name = "external_object_with_resource";
@@ -184,7 +180,6 @@ public void svgWithoutDimensionsWithViewboxTest() throws IOException, Interrupte
184180
@LogMessages(messages = {
185181
@LogMessage(messageTemplate = SvgLogMessageConstant.MISSING_WIDTH, count = 2),
186182
@LogMessage(messageTemplate = SvgLogMessageConstant.MISSING_HEIGHT, count = 2),
187-
@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count=6)
188183
})
189184
public void svgWithoutDimensionsImageAndObjectRef() throws IOException, InterruptedException {
190185
String name = "svgWithoutDimensionsImageAndObjectRef";

src/test/java/com/itextpdf/html2pdf/resolver/resource/LocalImageResolverReleaseTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ public static void beforeClass() {
6969
}
7070

7171
@Test
72-
@LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.ERROR_RESOLVING_PARENT_STYLES, count = 60)})
7372
public void testThatSvgIsReleasedAfterConversion() throws IOException {
7473
String htmlFileName = "testWithSvg.html";
7574
String svgFileName = "imageWithMultipleShapes.svg";

0 commit comments

Comments
 (0)