Remove redundant interface extension for form field classes

It was only there for compatibility over the past time. Now the form
elements are supported via native inline-block functionality in layout

DEVSIX-3495

Author: Snipx

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/form/element/IFormField.java

@@ -43,12 +43,11 @@ This file is part of the iText (R) project.
 package com.itextpdf.html2pdf.attach.impl.layout.form.element;
 
 import com.itextpdf.layout.element.IBlockElement;
-import com.itextpdf.layout.element.ILeafElement;
 
 /**
- * Interface extending the {@link ILeafElement} interface in the context of form fields.
+ * Common interface for HTML form elements
  */
-public interface IFormField extends ILeafElement, IBlockElement {
+public interface IFormField extends IBlockElement {
 
     /**
      * Gets the id.

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/form/renderer/AbstractFormFieldRenderer.java

@@ -46,11 +46,8 @@ This file is part of the iText (R) project.
 import com.itextpdf.html2pdf.attach.impl.layout.Html2PdfProperty;
 import com.itextpdf.html2pdf.attach.impl.layout.form.element.IFormField;
 import com.itextpdf.html2pdf.attach.util.AccessiblePropHelper;
-import com.itextpdf.io.font.PdfEncodings;
 import com.itextpdf.kernel.geom.Rectangle;
 import com.itextpdf.kernel.pdf.PdfDocument;
-import com.itextpdf.kernel.pdf.PdfString;
-import com.itextpdf.kernel.pdf.tagging.PdfStructElem;
 import com.itextpdf.kernel.pdf.tagging.StandardRoles;
 import com.itextpdf.kernel.pdf.tagutils.TagTreePointer;
 import com.itextpdf.layout.IPropertyContainer;
@@ -64,7 +61,6 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.property.UnitValue;
 import com.itextpdf.layout.renderer.BlockRenderer;
 import com.itextpdf.layout.renderer.DrawContext;
-import com.itextpdf.layout.renderer.ILeafElementRenderer;
 import com.itextpdf.layout.renderer.IRenderer;
 import com.itextpdf.layout.tagging.IAccessibleElement;
 
@@ -74,7 +70,7 @@ This file is part of the iText (R) project.
 /**
  * Abstract {@link BlockRenderer} for form fields.
  */
-public abstract class AbstractFormFieldRenderer extends BlockRenderer implements ILeafElementRenderer {
+public abstract class AbstractFormFieldRenderer extends BlockRenderer {
 
     /**
      * The flat renderer.
@@ -184,18 +180,6 @@ public void drawChildren(DrawContext drawContext) {
         drawContext.getCanvas().restoreState();
     }
 
-    @Override
-    public float getAscent() {
-        Float baseline = getLastYLineRecursively();
-        return baseline != null ? occupiedArea.getBBox().getTop() - (float) baseline : occupiedArea.getBBox().getHeight();
-    }
-
-    @Override
-    public float getDescent() {
-        Float baseline = getLastYLineRecursively();
-        return baseline != null ? occupiedArea.getBBox().getBottom() - (float) baseline : 0;
-    }
-
     /* (non-Javadoc)
      * @see com.itextpdf.layout.renderer.BlockRenderer#getMinMaxWidth(float)
      */

src/main/java/com/itextpdf/html2pdf/attach/impl/tags/LiTagWorker.java

@@ -135,6 +135,12 @@ public boolean processTagChild(ITagWorker childTagWorker, ProcessorContext conte
         if (element instanceof ILeafElement) {
             inlineHelper.add((ILeafElement) element);
             return true;
+        } else if (childTagWorker instanceof IDisplayAware &&
+                (CssConstants.INLINE_BLOCK.equals(((IDisplayAware) childTagWorker).getDisplay()) ||
+                        CssConstants.INLINE.equals(((IDisplayAware) childTagWorker).getDisplay()))
+                && element instanceof IBlockElement) {
+            inlineHelper.add((IBlockElement) element);
+            return true;
         } else if (childTagWorker instanceof SpanTagWorker) {
             boolean allChildrenProcessed = true;
             for (IPropertyContainer propertyContainer : ((SpanTagWorker) childTagWorker).getAllElements()) {

src/main/java/com/itextpdf/html2pdf/attach/impl/tags/PTagWorker.java

@@ -133,6 +133,12 @@ public boolean processTagChild(ITagWorker childTagWorker, ProcessorContext conte
         } else if (element instanceof ILeafElement) {
             inlineHelper.add((ILeafElement) element);
             return true;
+        } else if (childTagWorker instanceof IDisplayAware &&
+                (CssConstants.INLINE_BLOCK.equals(((IDisplayAware) childTagWorker).getDisplay()) ||
+                        CssConstants.INLINE.equals(((IDisplayAware) childTagWorker).getDisplay()))
+                && element instanceof IBlockElement) {
+            inlineHelper.add((IBlockElement) element);
+            return true;
         } else if (isBlockWithDisplay(childTagWorker, element, CssConstants.INLINE_BLOCK, false)) {
             inlineHelper.add((IBlockElement) element);
             return true;