Remove cssGridEnabled property

DEVSIX-8335

Author: Alexander Pliushchou

src/main/java/com/itextpdf/html2pdf/ConverterProperties.java

@@ -109,12 +109,6 @@ public class ConverterProperties {
      */
     private boolean continuousContainerEnabled;
 
-    /**
-     * enables css grid processing for all elements.
-     */
-    //TODO DEVSIX-8335 remove this property
-    private boolean cssGridEnabled = false;
-
     /**
      * Output intent for final destination device.
      */
@@ -151,7 +145,6 @@ public ConverterProperties(ConverterProperties other) {
         this.limitOfLayouts = other.limitOfLayouts;
         this.immediateFlush = other.immediateFlush;
         this.continuousContainerEnabled = other.continuousContainerEnabled;
-        this.cssGridEnabled = other.cssGridEnabled;
     }
 
     /**
@@ -532,16 +525,6 @@ public boolean isContinuousContainerEnabled() {
         return continuousContainerEnabled;
     }
 
-    /**
-     * check if css grid support is enabled.
-     *
-     * @return true if enabled, false otherwise
-     */
-    //TODO DEVSIX-8335
-    public boolean isCssGridEnabled() {
-        return cssGridEnabled;
-    }
-
     /**
      * Sets continuous container support.
      *
@@ -552,16 +535,4 @@ public ConverterProperties setContinuousContainerEnabled(boolean value) {
         continuousContainerEnabled = value;
         return this;
     }
-
-    //TODO DEVSIX-8335 remove this method
-    /**
-     * Sets css grid support.
-     *
-     * @param value true to enable css grid support, false otherwise
-     * @return the {@link ConverterProperties} instance
-     */
-    public ConverterProperties setCssGridEnabled(boolean value) {
-        cssGridEnabled = value;
-        return this;
-    }
 }

src/main/java/com/itextpdf/html2pdf/attach/ProcessorContext.java

@@ -155,12 +155,6 @@ public class ProcessorContext {
      */
     private boolean continuousContainerEnabled;
 
-    /**
-     * enables css grid processing for all elements.
-     */
-    //TODO DEVSIX-8335 remove this property
-    private boolean cssGridEnabled = false;
-
     /**
      * Instantiates a new {@link ProcessorContext} instance.
      *
@@ -215,7 +209,6 @@ public ProcessorContext(ConverterProperties converterProperties) {
         pdfAConformanceLevelFromProperties = converterProperties.getConformanceLevel();
         processingInlineSvg = false;
         continuousContainerEnabled = converterProperties.isContinuousContainerEnabled();
-        cssGridEnabled = converterProperties.isCssGridEnabled();
     }
 
     /**
@@ -524,14 +517,4 @@ public void endProcessingInlineSvg(){
     public boolean isContinuousContainerEnabled() {
         return continuousContainerEnabled;
     }
-
-    /**
-     * check if css grid support is enabled.
-     *
-     * @return true if enabled, false otherwise
-     */
-    //TODO DEVSIX-8335 remove this method
-    public boolean isCssGridEnabled() {
-        return cssGridEnabled;
-    }
 }

src/main/java/com/itextpdf/html2pdf/attach/impl/DefaultTagWorkerMapping.java

@@ -205,9 +205,8 @@ class DefaultTagWorkerMapping {
                 (lhs, rhs) -> new DisplayFlexTagWorker(lhs, rhs));
         workerMapping.putMapping(TagConstants.SPAN, CssConstants.FLEX,
                 (lhs, rhs) -> new DisplayFlexTagWorker(lhs, rhs));
-        //TODO DEVSIX-8335 remove check for css grid enabled logic
         workerMapping.putMapping(TagConstants.DIV, CssConstants.GRID,
-                (lhs, rhs) -> rhs.isCssGridEnabled() ? new DisplayGridTagWorker(lhs, rhs) : new DivTagWorker(lhs, rhs));
+                (lhs, rhs) -> new DisplayGridTagWorker(lhs, rhs));
 
         // pseudo elements mapping
         String beforePseudoElemName = CssPseudoElementUtil.createPseudoElementTagName(CssConstants.BEFORE);

src/test/java/com/itextpdf/html2pdf/css/grid/GridAreaTest.java

@@ -155,6 +155,6 @@ public void templateAreasStartEndTest() throws IOException, InterruptedException
     private void runTest(String testName) throws IOException, InterruptedException {
         convertToPdfAndCompare(testName,
                 SOURCE_FOLDER, DESTINATION_FOLDER, false,
-                new ConverterProperties().setBaseUri(SOURCE_FOLDER).setCssGridEnabled(true));
+                new ConverterProperties().setBaseUri(SOURCE_FOLDER));
     }
 }

src/test/java/com/itextpdf/html2pdf/css/grid/GridGapTest.java

@@ -179,6 +179,6 @@ public void smallValuesGapTest() throws IOException, InterruptedException {
 
     private void runTest(String testName) throws IOException, InterruptedException {
         convertToPdfAndCompare(testName, SOURCE_FOLDER, DESTINATION_FOLDER, false,
-                new ConverterProperties().setBaseUri(SOURCE_FOLDER).setCssGridEnabled(true));
+                new ConverterProperties().setBaseUri(SOURCE_FOLDER));
     }
 }

src/test/java/com/itextpdf/html2pdf/css/grid/GridItemPlacementTest.java

@@ -185,6 +185,6 @@ public void noTemplate2Test() throws IOException, InterruptedException {
 
     private void runTest(String testName) throws IOException, InterruptedException {
         convertToPdfAndCompare(testName, SOURCE_FOLDER, DESTINATION_FOLDER, false,
-                new ConverterProperties().setBaseUri(SOURCE_FOLDER).setCssGridEnabled(true));
+                new ConverterProperties().setBaseUri(SOURCE_FOLDER));
     }
 }

src/test/java/com/itextpdf/html2pdf/css/grid/GridLinenameTest.java

@@ -99,6 +99,6 @@ public void linenameAutoRepeatTest() throws IOException, InterruptedException {
     private void runTest(String testName) throws IOException, InterruptedException {
         convertToPdfAndCompare(testName,
                 SOURCE_FOLDER, DESTINATION_FOLDER, false,
-                new ConverterProperties().setBaseUri(SOURCE_FOLDER).setCssGridEnabled(true));
+                new ConverterProperties().setBaseUri(SOURCE_FOLDER));
     }
 }

src/test/java/com/itextpdf/html2pdf/css/grid/GridRelativeValuesTest.java

@@ -350,6 +350,6 @@ public void minmaxWithSpan4Test() throws IOException, InterruptedException {
 
     private void runTest(String testName) throws IOException, InterruptedException {
         convertToPdfAndCompare(testName, SOURCE_FOLDER, DESTINATION_FOLDER, false,
-                new ConverterProperties().setBaseUri(SOURCE_FOLDER).setCssGridEnabled(true));
+                new ConverterProperties().setBaseUri(SOURCE_FOLDER));
     }
 }

src/test/java/com/itextpdf/html2pdf/css/grid/GridTemplateColumnTest.java

@@ -144,6 +144,6 @@ public void templateColumnBasicTest2() throws IOException, InterruptedException
     private void runTest(String testName) throws IOException, InterruptedException {
         convertToPdfAndCompare(testName,
                 SOURCE_FOLDER, DESTINATION_FOLDER, false,
-                new ConverterProperties().setBaseUri(SOURCE_FOLDER).setCssGridEnabled(true));
+                new ConverterProperties().setBaseUri(SOURCE_FOLDER));
     }
 }

src/test/java/com/itextpdf/html2pdf/css/grid/GridTemplateCombinedTest.java

@@ -103,6 +103,6 @@ public void templateCombinedNoOtherPropertiesTest() throws IOException, Interrup
     private void runTest(String testName) throws IOException, InterruptedException {
         convertToPdfAndCompare(testName,
                 SOURCE_FOLDER, DESTINATION_FOLDER, false,
-                new ConverterProperties().setBaseUri(SOURCE_FOLDER).setCssGridEnabled(true));
+                new ConverterProperties().setBaseUri(SOURCE_FOLDER));
     }
 }