Skip to content

Commit ee7763b

Browse files
committed
Add test which reproduce the NPE due to null parent
DEVSIX-7609
1 parent 1ac89a8 commit ee7763b

File tree

82 files changed

+139
-231
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+139
-231
lines changed

src/test/java/com/itextpdf/html2pdf/css/multicol/ColumnCountTest.java

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ This file is part of the iText (R) project.
2424

2525
import com.itextpdf.html2pdf.ConverterProperties;
2626
import com.itextpdf.html2pdf.ExtendedHtmlConversionITextTest;
27+
import com.itextpdf.io.logs.IoLogMessageConstant;
2728
import com.itextpdf.layout.logs.LayoutLogMessageConstant;
29+
import com.itextpdf.test.LogLevelConstants;
2830
import com.itextpdf.test.annotations.LogMessage;
2931
import com.itextpdf.test.annotations.LogMessages;
3032
import com.itextpdf.test.annotations.type.IntegrationTest;
@@ -245,4 +247,31 @@ public void imagesMultipageTest() throws IOException, InterruptedException {
245247
public void imagesWithParagraphMultipageTest() throws IOException, InterruptedException {
246248
runTest("imagesWithParagraphMultipageTest");
247249
}
250+
251+
@Test
252+
public void basicOrphans1Test() throws IOException, InterruptedException {
253+
convertToPdfAndCompare("basicOrphans1Test",
254+
SOURCE_FOLDER, DESTINATION_FOLDER, false, new ConverterProperties().setMulticolEnabled(true));
255+
}
256+
257+
@Test
258+
public void basicOrphans2Test() throws IOException, InterruptedException {
259+
convertToPdfAndCompare("basicOrphans2Test",
260+
SOURCE_FOLDER, DESTINATION_FOLDER, false, new ConverterProperties().setMulticolEnabled(true));
261+
}
262+
263+
@Test
264+
@LogMessages(messages = {
265+
@LogMessage(messageTemplate = IoLogMessageConstant.WIDOWS_CONSTRAINT_VIOLATED, logLevel = LogLevelConstants.WARN, count = 2)
266+
})
267+
public void basicWidows1Test() throws IOException, InterruptedException {
268+
convertToPdfAndCompare("basicWidows1Test",
269+
SOURCE_FOLDER, DESTINATION_FOLDER, false, new ConverterProperties().setMulticolEnabled(true));
270+
}
271+
272+
@Test
273+
public void basicWidows2Test() throws IOException, InterruptedException {
274+
convertToPdfAndCompare("basicWidows2Test",
275+
SOURCE_FOLDER, DESTINATION_FOLDER, false, new ConverterProperties().setMulticolEnabled(true));
276+
}
248277
}

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/ColumnfillAutoMaxHeight002Test.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ This file is part of the iText (R) project.
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
2626

27-
import org.junit.Ignore;
2827

29-
@Ignore("DEVSIX-7609")
3028
public class ColumnfillAutoMaxHeight002Test extends W3CCssMulticolTest {
3129
@Override
3230
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolClip001Test.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,7 @@ This file is part of the iText (R) project.
2323
package com.itextpdf.html2pdf.css.w3c.css_multicol;
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
26-
import com.itextpdf.io.logs.IoLogMessageConstant;
27-
import com.itextpdf.test.LogLevelConstants;
28-
import com.itextpdf.test.annotations.LogMessage;
29-
import com.itextpdf.test.annotations.LogMessages;
3026

31-
import org.junit.Ignore;
32-
33-
@Ignore("DEVSIX-7609")
34-
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.RECTANGLE_HAS_NEGATIVE_SIZE,
35-
logLevel = LogLevelConstants.ERROR))
3627
public class MulticolClip001Test extends W3CCssMulticolTest {
3728
@Override
3829
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolClip002Test.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,7 @@ This file is part of the iText (R) project.
2323
package com.itextpdf.html2pdf.css.w3c.css_multicol;
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
26-
import com.itextpdf.io.logs.IoLogMessageConstant;
27-
import com.itextpdf.test.LogLevelConstants;
28-
import com.itextpdf.test.annotations.LogMessage;
29-
import com.itextpdf.test.annotations.LogMessages;
3026

31-
import org.junit.Ignore;
32-
33-
@Ignore("DEVSIX-7609")
34-
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.RECTANGLE_HAS_NEGATIVE_SIZE,
35-
logLevel = LogLevelConstants.ERROR))
3627
public class MulticolClip002Test extends W3CCssMulticolTest {
3728
@Override
3829
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolColumnsInvalid001Test.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,7 @@ This file is part of the iText (R) project.
2323
package com.itextpdf.html2pdf.css.w3c.css_multicol;
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
26-
import com.itextpdf.io.logs.IoLogMessageConstant;
27-
import com.itextpdf.test.LogLevelConstants;
28-
import com.itextpdf.test.annotations.LogMessage;
29-
import com.itextpdf.test.annotations.LogMessages;
3026

31-
import org.junit.Ignore;
32-
33-
@Ignore("DEVSIX-7609")
34-
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.RECTANGLE_HAS_NEGATIVE_SIZE,
35-
logLevel = LogLevelConstants.ERROR))
3627
public class MulticolColumnsInvalid001Test extends W3CCssMulticolTest {
3728
@Override
3829
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolColumnsInvalid002Test.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,7 @@ This file is part of the iText (R) project.
2323
package com.itextpdf.html2pdf.css.w3c.css_multicol;
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
26-
import com.itextpdf.io.logs.IoLogMessageConstant;
27-
import com.itextpdf.test.LogLevelConstants;
28-
import com.itextpdf.test.annotations.LogMessage;
29-
import com.itextpdf.test.annotations.LogMessages;
3026

31-
import org.junit.Ignore;
32-
33-
@Ignore("DEVSIX-7609")
34-
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.RECTANGLE_HAS_NEGATIVE_SIZE,
35-
logLevel = LogLevelConstants.ERROR))
3627
public class MulticolColumnsInvalid002Test extends W3CCssMulticolTest {
3728
@Override
3829
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolColumnsToolong001Test.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,7 @@ This file is part of the iText (R) project.
2323
package com.itextpdf.html2pdf.css.w3c.css_multicol;
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
26-
import com.itextpdf.io.logs.IoLogMessageConstant;
27-
import com.itextpdf.test.LogLevelConstants;
28-
import com.itextpdf.test.annotations.LogMessage;
29-
import com.itextpdf.test.annotations.LogMessages;
3026

31-
import org.junit.Ignore;
32-
33-
@Ignore("DEVSIX-7609")
34-
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.RECTANGLE_HAS_NEGATIVE_SIZE,
35-
logLevel = LogLevelConstants.ERROR))
3627
public class MulticolColumnsToolong001Test extends W3CCssMulticolTest {
3728
@Override
3829
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolContaining001Test.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,9 @@ This file is part of the iText (R) project.
2828
import com.itextpdf.test.annotations.LogMessage;
2929
import com.itextpdf.test.annotations.LogMessages;
3030

31-
import org.junit.Ignore;
32-
33-
34-
@Ignore("DEVSIX-7609")
35-
@LogMessages(messages = {@LogMessage(messageTemplate = IoLogMessageConstant.FONT_PROPERTY_MUST_BE_PDF_FONT_OBJECT),
36-
@LogMessage(messageTemplate = IoLogMessageConstant.RECTANGLE_HAS_NEGATIVE_SIZE,
37-
logLevel = LogLevelConstants.ERROR)})
31+
@LogMessages(messages = {
32+
@LogMessage(messageTemplate = IoLogMessageConstant.FONT_PROPERTY_MUST_BE_PDF_FONT_OBJECT, logLevel = LogLevelConstants.ERROR)
33+
})
3834
public class MulticolContaining001Test extends W3CCssMulticolTest {
3935
@Override
4036
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolCount001Test.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ This file is part of the iText (R) project.
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
2626

27-
import org.junit.Ignore;
28-
29-
@Ignore("DEVSIX-7601")
3027
public class MulticolCount001Test extends W3CCssMulticolTest {
3128
@Override
3229
protected String getHtmlFileName() {

src/test/java/com/itextpdf/html2pdf/css/w3c/css_multicol/MulticolCountComputed003Test.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,7 @@ This file is part of the iText (R) project.
2323
package com.itextpdf.html2pdf.css.w3c.css_multicol;
2424

2525
import com.itextpdf.html2pdf.css.w3c.W3CCssMulticolTest;
26-
import com.itextpdf.io.logs.IoLogMessageConstant;
27-
import com.itextpdf.test.LogLevelConstants;
28-
import com.itextpdf.test.annotations.LogMessage;
29-
import com.itextpdf.test.annotations.LogMessages;
3026

31-
import org.junit.Ignore;
32-
33-
@Ignore("DEVSIX-7609")
34-
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.RECTANGLE_HAS_NEGATIVE_SIZE,
35-
logLevel = LogLevelConstants.ERROR))
3627
public class MulticolCountComputed003Test extends W3CCssMulticolTest {
3728
@Override
3829
protected String getHtmlFileName() {

0 commit comments

Comments
 (0)