Add some basic tests to increase coverage

Author: Eswcvlad

src/test/java/com/itextpdf/rups/io/TextAreaOutputStreamTest.java

@@ -0,0 +1,67 @@
+/*
+    This file is part of the iText (R) project.
+    Copyright (c) 1998-2025 Apryse Group NV
+    Authors: Apryse Software.
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License version 3
+    as published by the Free Software Foundation with the addition of the
+    following permission added to Section 15 as permitted in Section 7(a):
+    FOR ANY PART OF THE COVERED WORK IN WHICH THE COPYRIGHT IS OWNED BY
+    APRYSE GROUP. APRYSE GROUP DISCLAIMS THE WARRANTY OF NON INFRINGEMENT
+    OF THIRD PARTY RIGHTS
+
+    This program is distributed in the hope that it will be useful, but
+    WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+    or FITNESS FOR A PARTICULAR PURPOSE.
+    See the GNU Affero General Public License for more details.
+    You should have received a copy of the GNU Affero General Public License
+    along with this program; if not, see http://www.gnu.org/licenses or write to
+    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+    Boston, MA, 02110-1301 USA, or download the license from the following URL:
+    http://itextpdf.com/terms-of-use/
+
+    The interactive user interfaces in modified source and object code versions
+    of this program must display Appropriate Legal Notices, as required under
+    Section 5 of the GNU Affero General Public License.
+
+    In accordance with Section 7(b) of the GNU Affero General Public License,
+    a covered work must retain the producer line in every PDF that is created
+    or manipulated using iText.
+
+    You can be released from the requirements of the license by purchasing
+    a commercial license. Buying such a license is mandatory as soon as you
+    develop commercial activities involving the iText software without
+    disclosing the source code of your own applications.
+    These activities include: offering paid services to customers as an ASP,
+    serving PDFs on the fly in a web application, shipping iText with a closed
+    source product.
+
+    For more information, please contact iText Software Corp. at this
+    address: [email protected]
+ */
+package com.itextpdf.rups.io;
+
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import javax.swing.JTextArea;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+
+@Tag("UnitTest")
+class TextAreaOutputStreamTest {
+    @Test
+    void write() throws IOException {
+        final JTextArea textArea = new JTextArea("Initial Text");
+        try (final TextAreaOutputStream stream = new TextAreaOutputStream(textArea)) {
+            Assertions.assertEquals("", textArea.getText());
+            stream.write('\n');
+            Assertions.assertEquals("\n", textArea.getText());
+            stream.write("тест".getBytes(StandardCharsets.UTF_8), 2, 4);
+            Assertions.assertEquals("\nес", textArea.getText());
+            stream.write("ТЕСТ".getBytes(StandardCharsets.UTF_8));
+            Assertions.assertEquals("\nесТЕСТ", textArea.getText());
+        }
+    }
+}

src/test/java/com/itextpdf/rups/model/PdfSyntaxUtilsTest.java

@@ -45,36 +45,48 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfArray;
 import com.itextpdf.kernel.pdf.PdfBoolean;
 import com.itextpdf.kernel.pdf.PdfDictionary;
+import com.itextpdf.kernel.pdf.PdfDocument;
+import com.itextpdf.kernel.pdf.PdfIndirectReference;
 import com.itextpdf.kernel.pdf.PdfName;
 import com.itextpdf.kernel.pdf.PdfNumber;
 import com.itextpdf.kernel.pdf.PdfString;
+import com.itextpdf.kernel.pdf.PdfWriter;
 import com.itextpdf.test.ExtendedITextTest;
 
+import java.io.ByteArrayOutputStream;
 import java.util.Arrays;
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
 @Tag("UnitTest")
-public class PdfSyntaxUtilsTest extends ExtendedITextTest {
+class PdfSyntaxUtilsTest extends ExtendedITextTest {
 
     @Test
-    public void testSimpleString() {
+    void testSimpleString() {
         Assertions.assertEquals("(hello world)", PdfSyntaxUtils.getSyntaxString(new PdfString("hello world")));
     }
 
     @Test
-    public void testSimpleDictionary() {
+    void testSimpleDictionary() {
         PdfDictionary pdfDictionary = new PdfDictionary();
         pdfDictionary.put(PdfName.ON, PdfBoolean.TRUE);
         Assertions.assertEquals("<< /ON true >>", PdfSyntaxUtils.getSyntaxString(pdfDictionary));
     }
 
     @Test
-    public void testSimpleArray() {
+    void testSimpleArray() {
         PdfArray array = new PdfArray(Arrays.asList(new PdfNumber(1), new PdfString("hello")));
         Assertions.assertEquals("[ 1 (hello) ]", PdfSyntaxUtils.getSyntaxString(array));
     }
 
+    @Test
+    void testIndirectRef() {
+        final PdfDocument doc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
+        final PdfIndirectReference ref = new PdfString("test")
+                .makeIndirect(doc)
+                .getIndirectReference();
+        Assertions.assertEquals(ref.getObjNumber() + " 0 R", PdfSyntaxUtils.getSyntaxString(ref));
+    }
 }

src/test/java/com/itextpdf/rups/model/TreeNodeFactoryTest.java

@@ -559,6 +559,20 @@ void expandNode_Asn1SVCertWithInvalidFormFieldType() {
         doSVCertTest(PdfName.Tx, null, null, new PdfString(new byte[] {0x30, 0x00}), null);
     }
 
+    @Test
+    void addNewIndirectObject() {
+        final PdfDocument doc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
+        final TreeNodeFactory factory = new TreeNodeFactory(createIndirectObjectFactory(doc));
+        final PdfString object = new PdfString("TEST");
+        factory.addNewIndirectObject(object);
+        final PdfIndirectReference ref = object.getIndirectReference();
+        Assertions.assertNotNull(ref);
+        Assertions.assertSame(doc, ref.getDocument());
+        final PdfObjectTreeNode node = factory.getNode(ref.getObjNumber());
+        Assertions.assertNotNull(node);
+        Assertions.assertSame(object, node.getPdfObject());
+    }
+
     private static void doSigTest(PdfName ft, PdfName type, PdfObject contents, String expectedLeafNodeName) {
         final PdfDocument doc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
         final PdfDictionary sigDict = createSigDict(doc, type, contents);

src/test/java/com/itextpdf/rups/view/PreferencesWindowTest.java

@@ -0,0 +1,56 @@
+/*
+    This file is part of the iText (R) project.
+    Copyright (c) 1998-2025 Apryse Group NV
+    Authors: Apryse Software.
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License version 3
+    as published by the Free Software Foundation with the addition of the
+    following permission added to Section 15 as permitted in Section 7(a):
+    FOR ANY PART OF THE COVERED WORK IN WHICH THE COPYRIGHT IS OWNED BY
+    APRYSE GROUP. APRYSE GROUP DISCLAIMS THE WARRANTY OF NON INFRINGEMENT
+    OF THIRD PARTY RIGHTS
+
+    This program is distributed in the hope that it will be useful, but
+    WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+    or FITNESS FOR A PARTICULAR PURPOSE.
+    See the GNU Affero General Public License for more details.
+    You should have received a copy of the GNU Affero General Public License
+    along with this program; if not, see http://www.gnu.org/licenses or write to
+    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+    Boston, MA, 02110-1301 USA, or download the license from the following URL:
+    http://itextpdf.com/terms-of-use/
+
+    The interactive user interfaces in modified source and object code versions
+    of this program must display Appropriate Legal Notices, as required under
+    Section 5 of the GNU Affero General Public License.
+
+    In accordance with Section 7(b) of the GNU Affero General Public License,
+    a covered work must retain the producer line in every PDF that is created
+    or manipulated using iText.
+
+    You can be released from the requirements of the license by purchasing
+    a commercial license. Buying such a license is mandatory as soon as you
+    develop commercial activities involving the iText software without
+    disclosing the source code of your own applications.
+    These activities include: offering paid services to customers as an ASP,
+    serving PDFs on the fly in a web application, shipping iText with a closed
+    source product.
+
+    For more information, please contact iText Software Corp. at this
+    address: [email protected]
+ */
+package com.itextpdf.rups.view;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+
+@Tag("UnitTest")
+final class PreferencesWindowTest {
+    @Test
+    void constructor_Smoke() {
+        // Most basic test, that the window does not blow up on construction
+        Assertions.assertDoesNotThrow(PreferencesWindow::new);
+    }
+}

src/test/java/com/itextpdf/rups/view/itext/FormTreeTest.java

@@ -47,7 +47,11 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfObject;
 import com.itextpdf.kernel.pdf.PdfReader;
 import com.itextpdf.rups.controller.PdfReaderController;
+import com.itextpdf.rups.mock.NoopProgressDialog;
+import com.itextpdf.rups.model.IRupsEventListener;
 import com.itextpdf.rups.model.IndirectObjectFactory;
+import com.itextpdf.rups.model.ObjectLoader;
+import com.itextpdf.rups.model.PdfFile;
 import com.itextpdf.rups.model.TreeNodeFactory;
 import com.itextpdf.rups.view.itext.treenodes.PdfObjectTreeNode;
 import com.itextpdf.rups.view.itext.treenodes.XfaTreeNode;
@@ -60,7 +64,7 @@ This file is part of the iText (R) project.
 import java.io.File;
 
 @Tag("UnitTest")
-class FormTreeTest extends ExtendedITextTest {
+final class FormTreeTest extends ExtendedITextTest {
     private static final String SOURCE_DIR = "./src/test/resources/com/itextpdf/rups/view/itext/";
 
     @Test
@@ -91,4 +95,27 @@ void testLoadXfa() {
             FormTree.loadXfa(factory, xfaTreeNode, xfaObjTreeNode);
         });
     }
+
+    @Test
+    void testHandleOpenDocument() {
+        Assertions.assertDoesNotThrow(() -> {
+            // Preload everything
+            final PdfFile pdfFile = PdfFile.open(
+                    new File(SOURCE_DIR + "cmp_purchase_order_filled.pdf")
+            );
+
+            // Using a noop listener here to prevent threading issues
+            final ObjectLoader loader = new ObjectLoader(
+                    new IRupsEventListener() {
+                    }, pdfFile, "Test loader", new NoopProgressDialog()
+            );
+            loader.execute();
+            loader.get();
+
+            // There is a FormTree inside the controller, which will also
+            // handle the event
+            final PdfReaderController controller = new PdfReaderController(null, null);
+            controller.handleOpenDocument(loader);
+        });
+    }
 }