chore!: ensure retrieved config values are of correct types and strict up types

Author: NeoIsRecursive

composer.json

@@ -17,7 +17,7 @@
     "orchestra/testbench": "^9.0",
     "pestphp/pest": "^3.0",
     "pestphp/pest-plugin-laravel": "^3.0",
-    "carthage-software/mago": "^0.23.0"
+    "carthage-software/mago": "1.0.0-alpha.2"
   },
   "autoload": {
     "psr-4": {

composer.lock

@@ -19,13 +19,17 @@ allow_dynamic_static_calls = true
 level = "off"
 
 [[linter.rules]]
-name = "analysis/override-attribute"
+name = "best-practices/override-attribute"
 level = "off"
 
 [[linter.rules]]
 name = "naming/class"
 level = "off"
 
+[[linter.rules]]
+name = "best-practices/literal-named-argument"
+level = "off"
+
 [[linter.rules]]
 name = "naming/interface"
 level = "off"
@@ -34,4 +38,3 @@ level = "off"
 # since we support php 8.2 we cannot use constant types
 name = "strictness/require-constant-type"
 level = "off"
-

mago.toml

@@ -5,6 +5,6 @@
 
 @csrf
 
-<itiden-backup :chunk-size="{{ config('backup.chunk_size') }}" />
+<itiden-backup :chunk-size="{{ config()->integer('backup.chunk_size') }}" />
 
 @endsection

resources/views/backups.blade.php

@@ -5,6 +5,7 @@
 namespace Itiden\Backup;
 
 use Illuminate\Contracts\Auth\Authenticatable;
+use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Facades\Pipeline;
 use Itiden\Backup\Contracts\Repositories\BackupRepository;
@@ -37,16 +38,17 @@ public function backup(?Authenticatable $user = null): BackupDto
         try {
             $this->stateManager->setState(State::BackupInProgress);
 
-            $temp_zip_path = join_paths(config('backup.temp_path'), 'temp.zip');
+            $temp_zip_path = join_paths(Config::string('backup.temp_path'), 'temp.zip');
 
             $zipper = Zipper::write($temp_zip_path);
 
             Pipeline::via('backup')
                 ->send($zipper)
-                ->through(config('backup.pipeline'))
+                ->through(Config::array('backup.pipeline'))
                 ->thenReturn();
 
-            $password = config('backup.password');
+            /** @var string|null */
+            $password = Config::get('backup.password');
 
             if ($password) {
                 $zipper->encrypt($password);
@@ -108,7 +110,9 @@ public static function addMetaFromZipToBackupMeta(string $pathToZip, BackupDto $
      */
     public function enforceMaxBackups(): void
     {
-        $maxBackups = config('backup.max_backups', false);
+        /** @var int|false */
+        $maxBackups = Config::get('backup.max_backups', false);
+
         if (!$maxBackups) {
             return;
         }

src/Backuper.php

@@ -16,8 +16,10 @@
  */
 final class BackupCommand extends Command
 {
+    // @mago-expect lint:strictness/require-property-type
     protected $signature = 'statamic:backup';
 
+    // @mago-expect lint:strictness/require-property-type
     protected $description = 'Run the backup pipeline';
 
     public function handle(): void

src/Console/Commands/BackupCommand.php

@@ -5,12 +5,15 @@
 namespace Itiden\Backup\Console\Commands;
 
 use Illuminate\Console\Command;
+use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Facades\File;
 
 use function Laravel\Prompts\info;
 
 /**
  * Clear the backup temp directory
+ *
+ * @mago-expect lint:strictness/require-property-type
  */
 final class ClearFilesCommand extends Command
 {
@@ -20,13 +23,15 @@ final class ClearFilesCommand extends Command
 
     public function handle(): void
     {
-        if (!File::exists(config('backup.temp_path'))) {
+        $path = Config::string('backup.temp_path');
+
+        if (!File::exists(path: $path)) {
             info('Backup temp directory does not exist, no need to clear it.');
 
             return;
         }
 
-        File::cleanDirectory(config('backup.temp_path'));
+        File::cleanDirectory(directory: $path);
 
         info('Backup temp directory cleared successfully');
     }

src/Console/Commands/ClearFilesCommand.php

@@ -16,6 +16,8 @@
 
 /**
  * Restore content from a directory / backup
+ *
+ * @mago-expect lint:strictness/require-property-type
  */
 final class RestoreCommand extends Command
 {

src/Console/Commands/RestoreCommand.php

@@ -5,6 +5,7 @@
 namespace Itiden\Backup\DataTransferObjects;
 
 use Carbon\CarbonImmutable;
+use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Facades\Storage;
 use Itiden\Backup\Contracts\BackupNameResolver;
 use Itiden\Backup\Models\Metadata;
@@ -36,7 +37,7 @@ public static function fromFile(string $path): ?static
             return null;
         }
 
-        $bytes = Storage::disk(config('backup.destination.disk'))->size($path);
+        $bytes = Storage::disk(Config::string('backup.destination.disk'))->size($path);
 
         return new static(
             id: $values->id,

src/DataTransferObjects/BackupDto.php

@@ -9,7 +9,7 @@
 
 final readonly class ChunkyUploadDto
 {
-    // @mago-expect maintainability/excessive-parameter-list
+    // @mago-expect lint:maintainability/excessive-parameter-list
     public function __construct(
         public string $filename,
         public int $totalChunks,