fix(restore): remove option to not remove uploaded backup after restore

BREAKING CHANGE:        `destroyAfterRestore` parameter no longer has an effect and it will always be deleted

Author: NeoIsRecursive

client/src/components/Actions.vue

@@ -90,7 +90,6 @@ export default {
       this.$axios
         .post(cp_url("api/backups/restore-from-path"), {
           path: file.path,
-          destroyAfterRestore: true,
         })
         .then(({ data }) => {
           this.$toast.info(__(data.message));

src/Http/Controllers/Api/RestoreFromPathController.php

@@ -15,12 +15,7 @@
 {
     public function __invoke(RestoreFromPathRequest $request, StateManager $stateManager): JsonResponse
     {
-        $stateManager->dispatch(
-            new RestoreFromPathJob(
-                path: $request->validated('path'),
-                deleteAfter: $request->input('destroyAfterRestore', false),
-            ),
-        );
+        $stateManager->dispatch(new RestoreFromPathJob(path: $request->validated('path')));
 
         return response()->json(['message' => __('statamic-backup::backup.restore.started')]);
     }

src/Http/Requests/RestoreFromPathRequest.php

@@ -12,7 +12,6 @@ public function rules(): array
     {
         return [
             'path' => 'required|string',
-            'destroyAfterRestore' => 'nullable|boolean',
         ];
     }
 }

src/Jobs/RestoreFromPathJob.php

@@ -21,7 +21,6 @@ final class RestoreFromPathJob implements ShouldQueue
      */
     public function __construct(
         private string $path,
-        private bool $deleteAfter,
     ) {
     }
 
@@ -34,9 +33,7 @@ public function handle(Restorer $restorer, Repository $cache): void
 
         $cache->forget(StateManager::JOB_QUEUED_KEY);
 
-        if ($this->deleteAfter) {
-            File::delete($this->path);
-        }
+        File::delete($this->path);
     }
 
     public function failed(): void

tests/Feature/RestoreFromPathTest.php

@@ -50,7 +50,6 @@
 
         $response = postJson(cp_route('api.itiden.backup.restore-from-path'), [
             'path' => $path,
-            'destroyAfterRestore' => true,
         ]);
 
         expect($response->status())->toBe(Response::HTTP_OK);
@@ -77,7 +76,6 @@
 
         $response = postJson(cp_route('api.itiden.backup.restore-from-path'), [
             'path' => $emptyArchive,
-            'destroyAfterRestore' => true,
         ]);
 
         Event::assertDispatched(RestoreFailed::class);