Make mago happy

Author: NeoIsRecursive

src/Console/Commands/BackupCommand.php

@@ -16,10 +16,8 @@
  */
 final class BackupCommand extends Command
 {
-    // @mago-expect lint:strictness/require-property-type
     protected $signature = 'statamic:backup';
 
-    // @mago-expect lint:strictness/require-property-type
     protected $description = 'Run the backup pipeline';
 
     public function handle(): void

src/Console/Commands/ClearFilesCommand.php

@@ -12,8 +12,6 @@
 
 /**
  * Clear the backup temp directory
- *
- * @mago-expect lint:strictness/require-property-type
  */
 final class ClearFilesCommand extends Command
 {

src/Console/Commands/RestoreCommand.php

@@ -16,8 +16,6 @@
 
 /**
  * Restore content from a directory / backup
- *
- * @mago-expect lint:strictness/require-property-type
  */
 final class RestoreCommand extends Command
 {

src/Http/Resources/BackupResource.php

@@ -11,7 +11,6 @@
  */
 final class BackupResource extends JsonResource
 {
-    // @mago-expect lint:parameter-type
     public function toArray($request): array
     {
         return [

src/Http/Resources/MetadataResource.php

@@ -12,7 +12,6 @@
  */
 final class MetadataResource extends JsonResource
 {
-    // @mago-expect lint:parameter-type
     public function toArray($request): array
     {
         return [

src/ServiceProvider.php

@@ -18,7 +18,6 @@
 use Statamic\Facades\Permission;
 use Statamic\Providers\AddonServiceProvider;
 
-// @mago-expect lint:strictness/require-property-type
 final class ServiceProvider extends AddonServiceProvider
 {
     protected $viewNamespace = 'itiden-backup';

tests/Feature/CreateBackupTest.php

@@ -68,9 +68,10 @@
 
         postJson(cp_route('api.itiden.backup.store'));
 
-        Event::assertDispatched(BackupCreated::class, function (BackupCreated $event): bool {
-            return $event->backup->name === app(BackupRepository::class)->all()->first()->name;
-        });
+        Event::assertDispatched(
+            BackupCreated::class,
+            fn(BackupCreated $event) => $event->backup->name === app(BackupRepository::class)->all()->first()->name,
+        );
     });
 
     it('dispatches failed event when error occurs', function (): void {

tests/Feature/RestoreBackupTest.php

@@ -89,9 +89,7 @@
 
         $response = postJson(cp_route('api.itiden.backup.restore', $backup->id));
 
-        Event::assertDispatched(BackupRestored::class, function (BackupRestored $event) use ($backup): bool {
-            return $event->backup->id === $backup->id;
-        });
+        Event::assertDispatched(BackupRestored::class, fn(BackupRestored $event) => $event->backup->id === $backup->id);
         expect($response->status())->toBe(Response::HTTP_OK);
     });
 

tests/TestCase.php

@@ -16,7 +16,6 @@ class TestCase extends AddonTestCase
 
     protected string $addonServiceProvider = ServiceProvider::class;
 
-    // @mago-expect lint:parameter-type
     protected function resolveApplicationConfiguration($app): void
     {
         parent::resolveApplicationConfiguration($app);

tests/Unit/PipeTest.php

@@ -47,9 +47,7 @@
     test('can skip a pipe with users', function (): void {
         $pipe = app()->make(Users::class);
 
-        $callable = function (Zipper $z): Zipper {
-            return $z;
-        };
+        $callable = fn(Zipper $z) => $z;
 
         File::deleteDirectory(Stache::store('users')->directory());
 
@@ -69,9 +67,7 @@
     test('can skip a pipe with stache content', function (): void {
         $pipe = app()->make(StacheData::class);
 
-        $callable = function (Zipper $z): Zipper {
-            return $z;
-        };
+        $callable = fn(Zipper $z) => $z;
 
         config()->set('backup.stache_stores', ['non-existing-store']);