Skip to content

Commit 973fc1b

Browse files
committed
removed unnecessary modal margin and changed overflow scroll to overflow auto to prevent visible scrollbars in modals
1 parent 9f5cd35 commit 973fc1b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/stories/Library/Modals/modal-details/modal-details.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ $MODAL_DETAILS_CONTAINER_WIDTH: 1000px;
1212

1313
.modal-details__container {
1414
width: 100%;
15-
overflow: scroll;
15+
overflow: auto;
1616
max-width: 100%;
1717
padding-bottom: $s-2xl;
1818

1919
@include breakpoint-s {
20-
margin: 0 45px;
20+
margin: 0;
2121
padding-bottom: 0;
2222
}
2323
}
@@ -56,8 +56,8 @@ $MODAL_DETAILS_CONTAINER_WIDTH: 1000px;
5656
margin-bottom: 16px;
5757
}
5858

59-
/*
60-
We disable stylelint here since -webkit-box
59+
/*
60+
We disable stylelint here since -webkit-box
6161
uses ellipsis for truncating which we need.
6262
https://caniuse.com/?search=line-clamp
6363
*/

src/stories/Library/Modals/modal.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
display: none;
2121
transition: opacity 0.3s;
2222
height: 100vh;
23-
overflow: scroll;
23+
overflow: auto;
2424

2525
&__screen-reader-description {
2626
@include hide-visually;

0 commit comments

Comments
 (0)