4881: Fix Unrecognized option: --fail-on-changes

Author: turegjorup

.github/workflows/api-spec.yml

@@ -46,12 +46,12 @@ jobs:
           ref: ${{ github.head_ref }}
           path: head
 
-      - name: Run OpenAPI Changes (from HEAD rev)
-        id: api-changes
+      - name: Run OpenAPI Changed (from HEAD rev)
+        id: api-changed
         continue-on-error: true
         uses: docker://openapitools/openapi-diff:latest
         with:
-          args: --fail-on-changes base/public/spec.yaml head/public/spec.yaml  --markdown api-spec-changes.md
+          args: --fail-on-changed base/public/spec.yaml head/public/spec.yaml --markdown api-spec-changed.md
 
       - name: Run OpenAPI Incompatible (from HEAD rev)
         id: api-incompatible
@@ -63,26 +63,26 @@ jobs:
       - name: Debug outcomes
         if: always()
         run: |
-          echo "api-changes outcome: ${{ steps.api-changes.outcome }}"
+          echo "api-changed outcome: ${{ steps.api-changed.outcome }}"
           echo "api-incompatible outcome: ${{ steps.api-incompatible.outcome }}"
 
       - name: Comment PR with no changes
-        if: steps.api-changes.outcome == 'success' && steps.api-incompatible.outcome == 'success'
+        if: steps.api-changed.outcome == 'success' && steps.api-incompatible.outcome == 'success'
         working-directory: head
         env:
           GH_TOKEN: ${{ github.token }}
         run: |
           gh pr comment ${{ github.event.pull_request.number }} --body "✅ **No changes detected in API specification**" --create-if-none --edit-last
 
       - name: Comment PR with non-breaking changes
-        if: steps.api-changes.outcome == 'failure' && steps.api-incompatible.outcome == 'success'
+        if: steps.api-changed.outcome == 'failure' && steps.api-incompatible.outcome == 'success'
         working-directory: head
         env:
           GH_TOKEN: ${{ github.token }}
         run: |
           echo "## ⚠️ Non-Breaking changes detected in API specification" > ../comment.md
           echo "" >> ../comment.md
-          cat ../api-spec-changes.md >> ../comment.md
+          cat ../api-spec-changed.md >> ../comment.md
           gh pr comment ${{ github.event.pull_request.number }} --body-file ../comment.md --create-if-none --edit-last
 
       - name: Comment PR with breaking changes