Skip to content

Commit bd34f0a

Browse files
authored
Merge pull request #90 from itk-dev/feature/modal-cleanup
Cleaned up modals
2 parents 6468293 + 1f1fa3a commit bd34f0a

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ Versioning](https://semver.org/spec/v2.0.0.html).
88

99
## [Unreleased]
1010

11+
* [PR-90](https://github.com/itk-dev/kunstdatabasen/pull/90)
12+
Cleaned up modals
1113
* [PR-89](https://github.com/itk-dev/kunstdatabasen/pull/89)
1214
Cleaned up assets
1315
* [PR-88](https://github.com/itk-dev/kunstdatabasen/pull/88)

templates/admin/item/_modal.html.twig

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,8 @@
33
<div class="modal-content">
44
<div class="modal-header bg-light">
55
<h4 class="modal-title" id="item-details-modal-title"></h4>
6-
<div class="float-right">
7-
<a id="item-details-modal-edit-link" class="me-3"><i class="fas fa-edit me-1"></i><span class="sr-only">{{ 'action.close'|trans }}</span></a>
8-
<button type="button" class="btn" data-bs-dismiss="modal" aria-label="{{ 'action.close'|trans }}">
9-
<span aria-hidden="true"><i class="fas fa-times"></i></span>
10-
</button>
11-
</div>
6+
<a id="item-details-modal-edit-link" class="ms-3"><i class="fas fa-edit me-1"></i><span class="sr-only">{{ 'action.edit'|trans }}</span></a>
7+
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="{{ 'action.close'|trans }}"></button>
128
</div>
139
<div class="modal-body" id="item-details-modal-body">
1410
</div>

templates/admin/item/details.html.twig

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,7 @@
122122
<div class="modal-dialog" role="document">
123123
<div class="modal-content">
124124
<div class="modal-header">
125-
<button type="button" class="btn" data-dismiss="modal" aria-label="{{ 'action.close'|trans }}">
126-
<span aria-hidden="true"><i class="fas fa-times"></i></span>
127-
</button>
125+
<button type="button" class="btn" data-dismiss="modal" aria-label="{{ 'action.close'|trans }}"></button>
128126
</div>
129127
<div class="modal-body">
130128
<img class="img-fluid" id="carouselImageFull" src="" alt="{{ 'frontend.image_large'|trans }}">

translations/messages+intl-icu.da.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ admin.item.delete_confirm: Er du sikker på at du vil slette dette?
7777
action.edit_item: Redigér
7878
action.close: Luk
7979
action.create_new_item: 'Opret nyt'
80+
action.edit: Rediger
8081
item.form.common: Generelt
8182
item.form.art: Kunst
8283
item.form.placement: Placering

0 commit comments

Comments
 (0)