Updated changelog and applied js coding standards

Author: martinyde

CHANGELOG.md

@@ -7,7 +7,8 @@ and this project adheres to [Semantic
 Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
-
+- [374](https://github.com/itk-dev/os2loop/pull/374)
+  Added itkdev template with github actions and tasks
 - [PR-373](https://github.com/itk-dev/os2loop/pull/373)
   Update contrib modules
   Update custom modules

task/Taskfile.yml

@@ -75,7 +75,8 @@ tasks:
       - task dev:compose -- exec phpfpm vendor/bin/phpstan analyse --configuration=phpstan.neon
       - task dev:compose -- exec phpfpm vendor/bin/twig-cs-fixer lint web/profiles/custom/os2loop/themes/*/templates
       - task dev:compose -- run --rm prettier '**/*.{yml,yaml}' --check
-      - task dev:compose -- run --rm prettier 'web/profiles/custom/os2loop/themes/**/*.{css,scss}' --check
+      - task dev:compose -- run --rm prettier 'web/profiles/custom/os2loop/**/*.{css,scss}' --check
+      - task dev:compose -- run --rm prettier 'web/profiles/custom/os2loop/**/*.js' --check
       - docker run --rm --volume "$PWD:/md" itkdev/markdownlint '**/*.md'
 
   code:apply-standards:
@@ -85,4 +86,5 @@ tasks:
       - task dev:compose -- exec phpfpm vendor/bin/twig-cs-fixer lint web/profiles/custom/os2loop/themes/*/templates --fix
       - task dev:compose -- run --rm prettier '**/*.{yml,yaml}' --write
       - task dev:compose -- run --rm prettier 'web/profiles/custom/os2loop/themes/**/*.{css,scss}' --write
+      - task dev:compose -- run --rm prettier 'web/profiles/custom/os2loop/**/*.js' --write
       - docker run --rm --volume "$PWD:/md" itkdev/markdownlint '**/*.md' --fix

web/profiles/custom/os2loop/modules/os2loop_question/assets/js/hideReferenceIds.js

@@ -1,52 +1,57 @@
 (function ($, Drupal, once) {
-    'use strict';
-    /**
-     * Remove entity reference ID from "entity_autocomplete" field.
-     *
-     * @type {{attach: Drupal.behaviors.autocompleteReferenceEntityId.attach}}
-     */
-    Drupal.behaviors.autocompleteReferenceEntityId = {
-      attach: function (context) {
-        // Remove reference IDs for autocomplete elements on init.
-        $(once('replaceReferenceIdOnInit', '.form-autocomplete', context)).each(function () {
-          let splitValues = (this.value && this.value !== 'false') ?
-            Drupal.autocomplete.splitValues(this.value) : [];
+  "use strict";
+  /**
+   * Remove entity reference ID from "entity_autocomplete" field.
+   *
+   * @type {{attach: Drupal.behaviors.autocompleteReferenceEntityId.attach}}
+   */
+  Drupal.behaviors.autocompleteReferenceEntityId = {
+    attach: function (context) {
+      // Remove reference IDs for autocomplete elements on init.
+      $(once("replaceReferenceIdOnInit", ".form-autocomplete", context)).each(
+        function () {
+          let splitValues =
+            this.value && this.value !== "false"
+              ? Drupal.autocomplete.splitValues(this.value)
+              : [];
 
-            if (splitValues.length > 0) {
-                let labelValues = [];
-                for (let i in splitValues) {
-                  let value = splitValues[i].trim();
-                  let entityIdMatch = value.match(/\s*\((.*?)\)$/);
-                  if (entityIdMatch) {
-                    labelValues[i] = value.replace(entityIdMatch[0], '');
-                  }
-                }
-                if (labelValues.length > 0) {
-                  $(this).data('real-value', splitValues.join(', '));
-                  this.value = labelValues.join(', ');
-                }
+          if (splitValues.length > 0) {
+            let labelValues = [];
+            for (let i in splitValues) {
+              let value = splitValues[i].trim();
+              let entityIdMatch = value.match(/\s*\((.*?)\)$/);
+              if (entityIdMatch) {
+                labelValues[i] = value.replace(entityIdMatch[0], "");
+              }
             }
-        });
-      }
-    };
-
-    let autocomplete = Drupal.autocomplete.options;
-    autocomplete.originalValues = [];
-    autocomplete.labelValues = [];
+            if (labelValues.length > 0) {
+              $(this).data("real-value", splitValues.join(", "));
+              this.value = labelValues.join(", ");
+            }
+          }
+        },
+      );
+    },
+  };
 
-    /**
-     * Add custom select handler.
-     */
-    autocomplete.select = function (event, ui) {
-      autocomplete.labelValues = Drupal.autocomplete.splitValues(event.target.value);
-      autocomplete.labelValues.pop();
-      autocomplete.labelValues.push(ui.item.label);
-      autocomplete.originalValues.push(ui.item.value);
+  let autocomplete = Drupal.autocomplete.options;
+  autocomplete.originalValues = [];
+  autocomplete.labelValues = [];
 
-      $(event.target).data('real-value', autocomplete.originalValues.join(', '));
-      event.target.value = autocomplete.labelValues.join(', ');
+  /**
+   * Add custom select handler.
+   */
+  autocomplete.select = function (event, ui) {
+    autocomplete.labelValues = Drupal.autocomplete.splitValues(
+      event.target.value,
+    );
+    autocomplete.labelValues.pop();
+    autocomplete.labelValues.push(ui.item.label);
+    autocomplete.originalValues.push(ui.item.value);
 
-      return FALSE;
-    }
+    $(event.target).data("real-value", autocomplete.originalValues.join(", "));
+    event.target.value = autocomplete.labelValues.join(", ");
 
+    return FALSE;
+  };
 })(jQuery, Drupal, once);

web/profiles/custom/os2loop/modules/os2loop_search_db/assets/js/hideFilters.js

@@ -2,14 +2,13 @@
  * Hide search filters if the search yields no result.
  */
 (function (Drupal, drupalSettings) {
-  'use strict';
+  "use strict";
   Drupal.behaviors.hideFilters = {
     attach: function (context, settings) {
-      let noResult = document.getElementById('js-no-result');
+      let noResult = document.getElementById("js-no-result");
       if (noResult) {
-        document.getElementById('js-search-filters').style.display = 'none';
+        document.getElementById("js-search-filters").style.display = "none";
       }
-    }
+    },
   };
-
 })(Drupal, drupalSettings);

web/profiles/custom/os2loop/modules/os2loop_section_page/js/hide-empty-sections.js

@@ -5,7 +5,7 @@ Drupal.behaviors.hideEmptySections = {
     for (let i = 0; i < empty_views.length; i++) {
       let el = empty_views.item(i);
       // Look for class section in parents.
-      let section = findUpClass(el, 'section');
+      let section = findUpClass(el, "section");
       if (section) {
         // Add explanatory class.
         section.classList.add("js-empty-list");
@@ -14,16 +14,15 @@ Drupal.behaviors.hideEmptySections = {
         section.classList.add("d-none");
       }
     }
-  }
+  },
 };
 
 // Iterate up through parents looking for a class.
 function findUpClass(el, tag) {
   while (el.parentNode) {
     el = el.parentNode;
-    let classList = el.className.split(' ')
-    if (classList.includes(tag))
-      return el;
+    let classList = el.className.split(" ");
+    if (classList.includes(tag)) return el;
   }
   return null;
 }

web/profiles/custom/os2loop/modules/os2loop_user_login/assets/user-login-form.js

@@ -1,5 +1,7 @@
-document.querySelector('#drupal-login input[type="submit"]').addEventListener('click', function(event) {
-  // Make sure that we keep the fragment id in the form action url.
-  // If we don't do this, any login errors will not be visible.
-  event.target.form.action = document.location.href
-})
+document
+  .querySelector('#drupal-login input[type="submit"]')
+  .addEventListener("click", function (event) {
+    // Make sure that we keep the fragment id in the form action url.
+    // If we don't do this, any login errors will not be visible.
+    event.target.form.action = document.location.href;
+  });

web/profiles/custom/os2loop/themes/os2loop_theme/assets/app.js

@@ -31,12 +31,12 @@ jQuery(() => {
 		.on("autocompleteopen", (event) =>
 			jQuery(event.target)
 				.parent()
-				.addClass("search-api-autocomplete-has-suggestions")
+				.addClass("search-api-autocomplete-has-suggestions"),
 		)
 		.on("autocompleteclose", (event) =>
 			jQuery(event.target)
 				.parent()
-				.removeClass("search-api-autocomplete-has-suggestions")
+				.removeClass("search-api-autocomplete-has-suggestions"),
 		);
 
 	// Add target="_blank" to all external links in main content.

web/profiles/custom/os2loop/themes/os2loop_theme/webpack.config.js

@@ -4,65 +4,65 @@ var CopyWebpackPlugin = require("copy-webpack-plugin");
 // Manually configure the runtime environment if not already configured yet by the "encore" command.
 // It's useful when you use tools that rely on webpack.config.js file.
 if (!Encore.isRuntimeEnvironmentConfigured()) {
-  Encore.configureRuntimeEnvironment(process.env.NODE_ENV || "dev");
+	Encore.configureRuntimeEnvironment(process.env.NODE_ENV || "dev");
 }
 
 Encore
-  // directory where compiled assets will be stored
-  .setOutputPath("build/")
-  // public path used by the web server to access the output path
-  .setPublicPath(".")
-  // only needed for CDN's or sub-directory deploy
-  .setManifestKeyPrefix("build/")
+	// directory where compiled assets will be stored
+	.setOutputPath("build/")
+	// public path used by the web server to access the output path
+	.setPublicPath(".")
+	// only needed for CDN's or sub-directory deploy
+	.setManifestKeyPrefix("build/")
 
-  /*
-   * ENTRY CONFIG
-   *
-   * Add 1 entry for each "page" of your app
-   * (including one that's included on every page - e.g. "app")
-   *
-   * Each entry will result in one JavaScript file (e.g. app.js)
-   * and one CSS file (e.g. app.css) if your JavaScript imports CSS.
-   */
-  .addEntry("app", "./assets/app.js")
-  .addEntry("pdf", "./assets/components/pdf/pdf.scss")
+	/*
+	 * ENTRY CONFIG
+	 *
+	 * Add 1 entry for each "page" of your app
+	 * (including one that's included on every page - e.g. "app")
+	 *
+	 * Each entry will result in one JavaScript file (e.g. app.js)
+	 * and one CSS file (e.g. app.css) if your JavaScript imports CSS.
+	 */
+	.addEntry("app", "./assets/app.js")
+	.addEntry("pdf", "./assets/components/pdf/pdf.scss")
 
-  // Color templates
-  .addEntry("default", "./assets/color-templates/default.scss")
-  .addEntry("blue", "./assets/color-templates/blue.scss")
-  .addEntry("green", "./assets/color-templates/green.scss")
-  .addEntry("red", "./assets/color-templates/red.scss")
-  .addEntry("yellow", "./assets/color-templates/yellow.scss")
-  .addEntry("lightblue", "./assets/color-templates/lightblue.scss")
+	// Color templates
+	.addEntry("default", "./assets/color-templates/default.scss")
+	.addEntry("blue", "./assets/color-templates/blue.scss")
+	.addEntry("green", "./assets/color-templates/green.scss")
+	.addEntry("red", "./assets/color-templates/red.scss")
+	.addEntry("yellow", "./assets/color-templates/yellow.scss")
+	.addEntry("lightblue", "./assets/color-templates/lightblue.scss")
 
-  // When enabled, Webpack "splits" your files into smaller pieces for greater optimization.
-  //.splitEntryChunks()
+	// When enabled, Webpack "splits" your files into smaller pieces for greater optimization.
+	//.splitEntryChunks()
 
-  // will require an extra script tag for runtime.js
-  // but, you probably want this, unless you're building a single-page app
-  .disableSingleRuntimeChunk()
+	// will require an extra script tag for runtime.js
+	// but, you probably want this, unless you're building a single-page app
+	.disableSingleRuntimeChunk()
 
-  /*
-   * FEATURE CONFIG
-   *
-   * Enable & configure other features below. For a full
-   * list of features, see:
-   * https://symfony.com/doc/current/frontend.html#adding-more-features
-   */
-  .cleanupOutputBeforeBuild()
-  .enableBuildNotifications()
-  .enableSourceMaps(!Encore.isProduction())
-  // enables hashed filenames (e.g. app.abc123.css)
-  //.enableVersioning(Encore.isProduction())
+	/*
+	 * FEATURE CONFIG
+	 *
+	 * Enable & configure other features below. For a full
+	 * list of features, see:
+	 * https://symfony.com/doc/current/frontend.html#adding-more-features
+	 */
+	.cleanupOutputBeforeBuild()
+	.enableBuildNotifications()
+	.enableSourceMaps(!Encore.isProduction())
+	// enables hashed filenames (e.g. app.abc123.css)
+	//.enableVersioning(Encore.isProduction())
 
-  // enables @babel/preset-env polyfills
-  .configureBabelPresetEnv((config) => {
-    config.useBuiltIns = "usage";
-    config.corejs = 3;
-  })
+	// enables @babel/preset-env polyfills
+	.configureBabelPresetEnv((config) => {
+		config.useBuiltIns = "usage";
+		config.corejs = 3;
+	})
 
-  // enables Sass/SCSS support
-  .enableSassLoader();
+	// enables Sass/SCSS support
+	.enableSassLoader();
 
 // uncomment if you use TypeScript
 //.enableTypeScriptLoader()