Applied coding standards

Author: martinyde

.github/workflows/javascript.yaml

@@ -33,4 +33,4 @@ jobs:
           docker network create frontend
 
       - run: |
-          docker compose run --rm prettier 'web/themes/custom/**/js/**/*.js' --check
+          docker compose run --rm prettier 'web/profiles/custom/os2loop/**/*.js' --check

.github/workflows/styles.yaml

@@ -33,4 +33,4 @@ jobs:
           docker network create frontend
 
       - run: |
-          docker compose run --rm prettier 'web/themes/custom/**/css/**/*.{css,scss}' --check
+          docker compose run --rm prettier 'web/profiles/custom/os2loop/**/*.{css,scss}' --check

.phpcs.xml.dist

@@ -5,8 +5,7 @@
 <ruleset name="PHP_CodeSniffer">
   <description>The coding standard.</description>
 
-  <file>web/modules/custom/</file>
-  <file>web/themes/custom/</file>
+  <file>web/profiles/custom/</file>
 
   <!-- Exclude generated files -->
   <exclude-pattern>node_modules</exclude-pattern>

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic
 Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+
 - [374](https://github.com/itk-dev/os2loop/pull/374)
   Added itkdev template with github actions and tasks
 - [PR-373](https://github.com/itk-dev/os2loop/pull/373)

task/Taskfile.yml

@@ -71,7 +71,7 @@ tasks:
   code:check:
     desc: Check php, twig and markdown files and analyze php code
     cmds:
-      - task dev:compose -- exec phpfpm vendor/bin/phpcs --standard=phpcs.xml.dist
+      - task dev:compose -- exec phpfpm vendor/bin/phpcs
       - task dev:compose -- exec phpfpm vendor/bin/phpstan analyse --configuration=phpstan.neon
       - task dev:compose -- exec phpfpm vendor/bin/twig-cs-fixer lint
       - task dev:compose -- run --rm prettier '**/*.{yml,yaml}' --check
@@ -82,7 +82,7 @@ tasks:
   code:apply-standards:
     desc: Apply coding standards to php, twig and markdown files
     cmds:
-      - task dev:compose -- exec phpfpm vendor/bin/phpcbf --standard=phpcs.xml.dist
+      - task dev:compose -- exec phpfpm vendor/bin/phpcbf
       - task dev:compose -- exec phpfpm vendor/bin/twig-cs-fixer lint --fix
       - task dev:compose -- run --rm prettier '**/*.{yml,yaml}' --write
       - task dev:compose -- run --rm prettier 'web/profiles/custom/os2loop/themes/**/*.{css,scss}' --write

web/profiles/custom/os2loop/modules/os2loop_documents/modules/os2loop_documents_fixtures/src/Fixture/DocumentLegacyFixture.php

@@ -48,7 +48,7 @@ public function load() {
       ],
     ]);
     $document->save();
-    $this->setReference($document->getType() . ':' . 'legacy-body', $document);
+    $this->setReference($document->getType() . ':legacy-body', $document);
 
     $document = Node::create([
       'type' => 'os2loop_documents_document',
@@ -78,7 +78,7 @@ public function load() {
       ],
     ]);
     $document->save();
-    $this->setReference($document->getType() . ':' . 'legacy-info', $document);
+    $this->setReference($document->getType() . ':legacy-info', $document);
 
     $document = Node::create([
       'type' => 'os2loop_documents_document',

web/profiles/custom/os2loop/themes/os2loop_theme/os2loop_theme.theme

@@ -146,7 +146,7 @@ function os2loop_theme_theme_suggestions_form_element_alter(array &$suggestions,
  */
 function os2loop_theme_theme_suggestions_container_alter(array &$suggestions, array $variables) {
   if (isset($variables['element']['#id'])) {
-    $suggestions[] = 'container' . '__' . str_replace('-', '_', $variables['element']['#id']);
+    $suggestions[] = 'container__' . str_replace('-', '_', $variables['element']['#id']);
   }
 }
 
@@ -155,7 +155,7 @@ function os2loop_theme_theme_suggestions_container_alter(array &$suggestions, ar
  */
 function os2loop_theme_theme_suggestions_form_element_label_alter(array &$suggestions, array $variables) {
   if (isset($variables['element']['#id'])) {
-    $suggestions[] = 'form_element_label' . '__' . str_replace('-', '_', $variables['element']['#id']);
+    $suggestions[] = 'form_element_label__' . str_replace('-', '_', $variables['element']['#id']);
   }
 }