Fixed n8n feedback (#6)

* N8N Feedback: Remove authenticate option from credentials

ITopApi.credentials.ts#L55 - This should be used to prevent issues when trying to use the credential with a http request node. If you are not using this please remove it.

* N8N Feedback: Resources are missing

ITop.node.ts#L55 - Resources are missing, Nodes should have Resources and Operations.

* N8N Feedback: Remove IAuthenticateGeneric import.

---------

Co-authored-by: Lars Kaltefleiter <lars.kaltefleiter@itomig.de>

Author: dw-itomig

credentials/ITopApi.credentials.ts

@@ -1,5 +1,4 @@
 import type {
-	IAuthenticateGeneric,
 	ICredentialTestRequest,
 	ICredentialType,
 	INodeProperties,
@@ -52,11 +51,6 @@ export class ITopApi implements ICredentialType {
 		},
 	];
 
-	authenticate: IAuthenticateGeneric = {
-		type: 'generic',
-		properties: {},
-	};
-
 	test: ICredentialTestRequest = {
 		request: {
 			baseURL: '={{$credentials.url}}/webservices/rest.php',

credentials/ITopTokenApi.credentials.ts

@@ -1,5 +1,4 @@
 import type {
-	IAuthenticateGeneric,
 	ICredentialTestRequest,
 	ICredentialType,
 	INodeProperties,
@@ -46,11 +45,6 @@ export class ITopTokenApi implements ICredentialType {
 		},
 	];
 
-	authenticate: IAuthenticateGeneric = {
-		type: 'generic',
-		properties: {},
-	};
-
 	test: ICredentialTestRequest = {
 		request: {
 			baseURL: '={{$credentials.url}}/webservices/rest.php',

nodes/ITop/ITop.node.ts

@@ -24,7 +24,7 @@ export class ITop implements INodeType {
 			},
 		group: ['transform'],
 		version: 1,
-		subtitle: '={{$parameter["operation"]}}',
+		subtitle: '={{$parameter["resource"] + ": " + $parameter["operation"]}}',
 		description: 'Interact with iTop CMDB via REST API',
 		usableAsTool: true,
 		defaults: {
@@ -69,11 +69,29 @@ export class ITop implements INodeType {
 				],
 				default: 'credentials',
 			},
+			{
+				displayName: 'Resource',
+				name: 'resource',
+				type: 'options',
+				noDataExpression: true,
+				options: [
+					{
+						name: 'Object',
+						value: 'object',
+					},
+				],
+				default: 'object',
+			},
 			{
 				displayName: 'Operation',
 				name: 'operation',
 				type: 'options',
 				noDataExpression: true,
+				displayOptions: {
+					show: {
+						resource: ['object'],
+					},
+				},
 				options: [
 					{
 						name: 'Apply Stimulus',

nodes/ITop/operations/apply_stimulus.ts

@@ -6,6 +6,7 @@ export const applyStimulusFields: INodeProperties[] = [
 		...classNameField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['apply_stimulus'],
 			},
 		},
@@ -15,6 +16,7 @@ export const applyStimulusFields: INodeProperties[] = [
 		description: 'Object identifier: numeric ID or search criteria. Must uniquely identify one object.',
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['apply_stimulus'],
 			},
 		},
@@ -28,6 +30,7 @@ export const applyStimulusFields: INodeProperties[] = [
 		description: 'The stimulus to apply (e.g. ev_assign)',
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['apply_stimulus'],
 			},
 		},
@@ -43,6 +46,7 @@ export const applyStimulusFields: INodeProperties[] = [
 		default: {},
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['apply_stimulus'],
 			},
 		},
@@ -74,6 +78,7 @@ export const applyStimulusFields: INodeProperties[] = [
 		...outputFieldsField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['apply_stimulus'],
 			},
 		},
@@ -82,6 +87,7 @@ export const applyStimulusFields: INodeProperties[] = [
 		...commentField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['apply_stimulus'],
 			},
 		},

nodes/ITop/operations/create.ts

@@ -6,6 +6,7 @@ export const createFields: INodeProperties[] = [
 		...classNameField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['create'],
 			},
 		},
@@ -22,6 +23,7 @@ export const createFields: INodeProperties[] = [
 		required: true,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['create'],
 			},
 		},
@@ -53,6 +55,7 @@ export const createFields: INodeProperties[] = [
 		...outputFieldsField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['create'],
 			},
 		},
@@ -61,6 +64,7 @@ export const createFields: INodeProperties[] = [
 		...commentField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['create'],
 			},
 		},

nodes/ITop/operations/delete.ts

@@ -6,6 +6,7 @@ export const deleteFields: INodeProperties[] = [
 		...classNameField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['delete'],
 			},
 		},
@@ -15,6 +16,7 @@ export const deleteFields: INodeProperties[] = [
 		description: 'The key or ID of the object to delete. Must uniquely identify one object.',
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['delete'],
 			},
 		},
@@ -23,6 +25,7 @@ export const deleteFields: INodeProperties[] = [
 		...commentField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['delete'],
 			},
 		},

nodes/ITop/operations/get.ts

@@ -6,6 +6,7 @@ export const getFields: INodeProperties[] = [
 		...classNameField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['get'],
 			},
 		},
@@ -14,6 +15,7 @@ export const getFields: INodeProperties[] = [
 		...keyField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['get'],
 			},
 		},
@@ -22,6 +24,7 @@ export const getFields: INodeProperties[] = [
 		...outputFieldsField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['get'],
 			},
 		},
@@ -30,6 +33,7 @@ export const getFields: INodeProperties[] = [
 		...limitField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['get'],
 			},
 		},
@@ -42,6 +46,7 @@ export const getFields: INodeProperties[] = [
 		default: {},
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['get'],
 			},
 		},

nodes/ITop/operations/update.ts

@@ -6,6 +6,7 @@ export const updateFields: INodeProperties[] = [
 		...classNameField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['update'],
 			},
 		},
@@ -15,6 +16,7 @@ export const updateFields: INodeProperties[] = [
 		description: 'Object identifier: numeric ID or search criteria. Note: Key must identify exactly ONE object, bulk updates are not supported.',
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['update'],
 			},
 		},
@@ -31,6 +33,7 @@ export const updateFields: INodeProperties[] = [
 		required: true,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['update'],
 			},
 		},
@@ -62,6 +65,7 @@ export const updateFields: INodeProperties[] = [
 		...outputFieldsField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['update'],
 			},
 		},
@@ -70,6 +74,7 @@ export const updateFields: INodeProperties[] = [
 		...commentField,
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['update'],
 			},
 		},
@@ -82,6 +87,7 @@ export const updateFields: INodeProperties[] = [
 		default: {},
 		displayOptions: {
 			show: {
+				resource: ['object'],
 				operation: ['update'],
 			},
 		},