File tree Expand file tree Collapse file tree 1 file changed +4
-4
lines changed
Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Original file line number Diff line number Diff line change @@ -818,17 +818,17 @@ def test_partial_none_counters_still_detected(self, detector):
818818 assert len (restart_events ) == 1
819819
820820 def test_no_false_positive_missing_summary_keys (self , detector ):
821- """Missing summary error keys must not cause false positive ."""
821+ """Missing cur summary keys: sanity check skipped, per-channel signal sufficient ."""
822822 prev , cur = self ._make_restart_pair ()
823823 # Remove summary error keys entirely from cur
824824 del cur ["summary" ]["ds_correctable_errors" ]
825825 del cur ["summary" ]["ds_uncorrectable_errors" ]
826826 detector .check (prev )
827827 events = detector .check (cur )
828828 restart_events = [e for e in events if e ["event_type" ] == "modem_restart_detected" ]
829- # Per-channel signal is there, but sanity check is skipped (not enforced)
830- # so per-channel alone is enough — this SHOULD detect .
831- # The key point: if summary keys are missing on PREV, no false positive.
829+ # Per-channel signal is strong (all channels declined), sanity check
830+ # skipped because cur summary keys are missing — detection still works .
831+ assert len ( restart_events ) == 1
832832
833833 def test_no_false_positive_prev_missing_summary (self , detector ):
834834 """If prev has no summary error keys, sanity check skipped, no false positive from 0-default."""
You can’t perform that action at this time.
0 commit comments