Skip to content

Commit afd164b

Browse files
committed
fix: mock ICMP helper in probe fallback tests to prevent false passes in Docker
1 parent b0e5626 commit afd164b

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/modules/connection_monitor/test_probe.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,14 @@ def test_auto_selects_icmp_when_raw_socket_available(self):
4343
assert engine.detected_method == "icmp"
4444

4545
def test_auto_falls_back_to_tcp_on_permission_error(self):
46-
with patch("app.modules.connection_monitor.probe.socket.socket", side_effect=PermissionError):
46+
with patch("app.modules.connection_monitor.probe.os.path.isfile", return_value=False), \
47+
patch("app.modules.connection_monitor.probe.socket.socket", side_effect=PermissionError):
4748
engine = ProbeEngine(method="auto")
4849
assert engine.detected_method == "tcp"
4950

5051
def test_auto_falls_back_to_tcp_on_os_error(self):
51-
with patch("app.modules.connection_monitor.probe.socket.socket", side_effect=OSError):
52+
with patch("app.modules.connection_monitor.probe.os.path.isfile", return_value=False), \
53+
patch("app.modules.connection_monitor.probe.socket.socket", side_effect=OSError):
5254
engine = ProbeEngine(method="auto")
5355
assert engine.detected_method == "tcp"
5456

@@ -61,7 +63,8 @@ def test_explicit_tcp(self):
6163
assert engine.detected_method == "tcp"
6264

6365
def test_capability_info(self):
64-
with patch("app.modules.connection_monitor.probe.socket.socket", side_effect=PermissionError):
66+
with patch("app.modules.connection_monitor.probe.os.path.isfile", return_value=False), \
67+
patch("app.modules.connection_monitor.probe.socket.socket", side_effect=PermissionError):
6568
engine = ProbeEngine(method="auto")
6669
info = engine.capability_info()
6770
assert info["method"] == "tcp"

0 commit comments

Comments
 (0)