Adjust SNR thresholds to match Vodafone VFKD guidelines

Warning: 30 -> 33 dB (VFKD regelkonform > 33.1 dB for 256QAM)
Critical: 25 -> 29 dB (VFKD sofortige Beseitigung < 29 dB)

Author: Dennis Braun

app/analyzer.py

@@ -13,9 +13,10 @@
 US_POWER_WARN = 50.0
 US_POWER_CRIT = 54.0
 
-# SNR / MER (dB): good >30, marginal 25-30, bad <25
-SNR_WARN = 30.0
-SNR_CRIT = 25.0
+# SNR / MER (dB): good >33, marginal 29-33, bad <29
+# Based on Vodafone VFKD guidelines: 256QAM regelkonform > 33.1 dB
+SNR_WARN = 33.0
+SNR_CRIT = 29.0
 
 # Uncorrectable errors threshold
 UNCORR_ERRORS_CRIT = 10000

app/event_detector.py

@@ -7,8 +7,8 @@
 
 # Thresholds for event detection
 POWER_SHIFT_THRESHOLD = 2.0  # dBmV shift to trigger power_change
-SNR_WARN_THRESHOLD = 30.0
-SNR_CRIT_THRESHOLD = 25.0
+SNR_WARN_THRESHOLD = 33.0
+SNR_CRIT_THRESHOLD = 29.0
 UNCORR_SPIKE_THRESHOLD = 1000
 
 # QAM hierarchy: higher value = better modulation

app/templates/index.html

@@ -1012,7 +1012,7 @@
                             <div class="range-zone range-good" style="width:50%"></div>
                             <div class="range-marker val-{{ snr_health }}" style="left:{{ snr_marker }}%"></div>
                         </div>
-                        <div class="range-labels"><span>15</span><span>25</span><span>30</span><span>45 dB</span></div>
+                        <div class="range-labels"><span>15</span><span>29</span><span>33</span><span>45 dB</span></div>
                     </div>
                 </div>
             </div>
@@ -1021,7 +1021,7 @@
                     <tr><td>{{ t.card_power_range }}</td><td>{{ s.ds_power_min }} ... {{ s.ds_power_max }} dBmV</td></tr>
                     <tr><td>SNR {{ t.card_power_range }}</td><td>{{ s.ds_snr_min }} ... {{ s.ds_snr_avg }} dB</td></tr>
                     <tr><td>{{ t.channels }}</td><td>{{ s.ds_total }} {{ t.downstream|lower }}</td></tr>
-                    <tr><td>{{ t.card_ideal_range }}</td><td>-7...+7 dBmV / SNR &gt;30 dB</td></tr>
+                    <tr><td>{{ t.card_ideal_range }}</td><td>-7...+7 dBmV / SNR &gt;33 dB</td></tr>
                 </table>
             </div>
         </div>
@@ -1190,7 +1190,7 @@ <h2 class="section-title">{{ t.downstream }} ({{ ds|length }} {{ t.channels }})<
                 <td data-sort="{{ ch.channel_id }}">{{ ch.channel_id }}</td>
                 <td>{{ ch.frequency }}</td>
                 <td data-sort="{{ ch.power if ch.power is not none else 0 }}" class="{% if ch.power is not none %}{% if ch.power|abs > 10 %}val-crit{% elif ch.power|abs > 7 %}val-warn{% else %}val-good{% endif %}{% endif %}">{{ ch.power }}</td>
-                <td data-sort="{{ ch.snr if ch.snr is not none else 0 }}" class="{% if ch.snr is not none %}{% if ch.snr < 25 %}val-crit{% elif ch.snr < 30 %}val-warn{% else %}val-good{% endif %}{% endif %}">{{ ch.snr if ch.snr is not none else "-" }}</td>
+                <td data-sort="{{ ch.snr if ch.snr is not none else 0 }}" class="{% if ch.snr is not none %}{% if ch.snr < 29 %}val-crit{% elif ch.snr < 33 %}val-warn{% else %}val-good{% endif %}{% endif %}">{{ ch.snr if ch.snr is not none else "-" }}</td>
                 <td>{{ ch.modulation }}</td>
                 <td data-sort="{{ ch.correctable_errors }}">{{ ch.correctable_errors|fmt_k }}</td>
                 <td data-sort="{{ ch.uncorrectable_errors }}">{{ ch.uncorrectable_errors|fmt_k }}</td>
@@ -2113,9 +2113,9 @@ <h2>{{ t.export_title }}</h2>
         {yMin: -12, yMax: 12}
     ];
     var DS_SNR_ZONES = [
-        {min: 15, max: 30, color: "rgba(244,67,54,0.35)"},
-        {min: 30, max: 35, color: "rgba(255,152,0,0.30)"},
-        {min: 35, max: 50, color: "rgba(76,175,80,0.25)"},
+        {min: 15, max: 29, color: "rgba(244,67,54,0.35)"},
+        {min: 29, max: 33, color: "rgba(255,152,0,0.30)"},
+        {min: 33, max: 50, color: "rgba(76,175,80,0.25)"},
         {yMin: 25, yMax: 45}
     ];
     var US_POWER_ZONES = [

tests/test_analyzer.py

@@ -119,9 +119,9 @@ def test_us_power_warning(self):
         assert "us_power_warn" in result["summary"]["health_issues"]
 
     def test_snr_warning(self):
-        """SNR 28 dB is marginal (between 25-30)."""
+        """SNR 31 dB is marginal (between 29-33)."""
         data = _make_data(
-            ds30=[_make_ds30(1, power=2.0, mse="-28")],
+            ds30=[_make_ds30(1, power=2.0, mse="-31")],
             us30=[_make_us30(1, power=42.0)],
         )
         result = analyze(data)
@@ -163,9 +163,9 @@ def test_us_power_critical(self):
         assert "us_power_critical" in result["summary"]["health_issues"]
 
     def test_snr_critical(self):
-        """SNR 22 dB is critical (<25)."""
+        """SNR 27 dB is critical (<29)."""
         data = _make_data(
-            ds30=[_make_ds30(1, power=2.0, mse="-22")],
+            ds30=[_make_ds30(1, power=2.0, mse="-27")],
             us30=[_make_us30(1, power=42.0)],
         )
         result = analyze(data)

tests/test_events.py

@@ -208,15 +208,15 @@ def test_power_no_event_small_shift(self, detector):
         assert len(power_events) == 0
 
     def test_snr_drop_warning(self, detector):
-        detector.check(_make_analysis(ds_snr_min=32.0))
-        events = detector.check(_make_analysis(ds_snr_min=28.0))
+        detector.check(_make_analysis(ds_snr_min=35.0))
+        events = detector.check(_make_analysis(ds_snr_min=31.0))
         snr_events = [e for e in events if e["event_type"] == "snr_change"]
         assert len(snr_events) == 1
         assert snr_events[0]["severity"] == "warning"
 
     def test_snr_drop_critical(self, detector):
-        detector.check(_make_analysis(ds_snr_min=28.0))
-        events = detector.check(_make_analysis(ds_snr_min=23.0))
+        detector.check(_make_analysis(ds_snr_min=31.0))
+        events = detector.check(_make_analysis(ds_snr_min=27.0))
         snr_events = [e for e in events if e["event_type"] == "snr_change"]
         assert len(snr_events) == 1
         assert snr_events[0]["severity"] == "critical"