Skip to content

Commit f92010a

Browse files
committed
Fix modem URL not updating for credential-free drivers
The URL default was applied after the credentials_required check, so modems like the Hitron CODA-56 would keep showing the FritzBox default URL (192.168.178.1) instead of their own (192.168.100.1). Move the URL update before the early return in both setup wizard and settings page. Fixes #175
1 parent dc2d40e commit f92010a

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

app/static/js/settings.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -839,6 +839,11 @@ function toggleUsernameField() {
839839
var testBtnParent = testBtn ? testBtn.parentElement : null;
840840
var testResult = document.getElementById('modem-test');
841841

842+
// URL default: apply if field is empty or still shows any known modem default
843+
if (hints.default_url && urlField && (!urlField.value || KNOWN_DEFAULT_URLS[urlField.value])) {
844+
urlField.value = hints.default_url;
845+
}
846+
842847
if (hints.credentials_required === false) {
843848
credFields.forEach(function(el) { if (el) el.style.display = 'none'; });
844849
if (testBtnParent) testBtnParent.style.display = 'none';
@@ -848,11 +853,6 @@ function toggleUsernameField() {
848853
credFields.forEach(function(el) { if (el) el.style.display = ''; });
849854
if (testBtnParent) testBtnParent.style.display = '';
850855

851-
// URL default: apply if field is empty or still shows any known modem default
852-
if (hints.default_url && urlField && (!urlField.value || KNOWN_DEFAULT_URLS[urlField.value])) {
853-
urlField.value = hints.default_url;
854-
}
855-
856856
// Username handling
857857
if (hints.username_required === false) {
858858
usernameField.disabled = true;

app/templates/setup.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -430,16 +430,16 @@ <h1 class="setup-title">{{ t.initial_setup }}</h1>
430430
var credGroup = document.getElementById('modem-credentials-group');
431431
var hints = DRIVER_HINTS[modemType] || {};
432432

433+
if(hints.default_url && (!urlField.value || KNOWN_DEFAULT_URLS[urlField.value])) {
434+
urlField.value = hints.default_url;
435+
}
436+
433437
if(hints.credentials_required === false) {
434438
credGroup.style.display = 'none';
435439
return;
436440
}
437441
credGroup.style.display = 'grid';
438442

439-
if(hints.default_url && (!urlField.value || KNOWN_DEFAULT_URLS[urlField.value])) {
440-
urlField.value = hints.default_url;
441-
}
442-
443443
if(hints.username_required === false) {
444444
usernameField.disabled = true;
445445
usernameField.value = '';

0 commit comments

Comments
 (0)