#429: Fixed review findings of @kaklakariada.

- Extracted method for header peeking
- Implemented `ImporterFactory` directly
- Fixed release date

Author: redcatbear

doc/changes/changes_4.2.1.md

@@ -1,4 +1,4 @@
-# OpenFastTrace 4.2.1, released 2025-09-07
+# OpenFastTrace 4.2.1, released 2025-09-14
 
 Code name: Peek before you guess
 

importer/specobject/src/main/java/org/itsallcode/openfasttrace/importer/specobject/SpecobjectImporterFactory.java

@@ -12,7 +12,7 @@
 /**
  * An {@link ImporterFactory} for ReqM2/SpecObject XML files.
  */
-public class SpecobjectImporterFactory extends RegexMatchingImporterFactory
+public class SpecobjectImporterFactory extends ImporterFactory
 {
     private static final Logger LOG = Logger.getLogger(SpecobjectImporterFactory.class.getName());
     private static final int PEEK_CHARS = 4096;
@@ -24,7 +24,6 @@ public class SpecobjectImporterFactory extends RegexMatchingImporterFactory
      */
     public SpecobjectImporterFactory()
     {
-        super("(?i).*\\.(xml|oreqm)");
         this.xmlParserFactory = new XmlParserFactory();
     }
 
@@ -40,25 +39,29 @@ public boolean supportsFile(final InputFile file)
         }
         else if (lower.endsWith(".xml"))
         {
-            try (BufferedReader reader = file.createReader())
-            {
-                final char[] buf = new char[PEEK_CHARS];
-                final int read = reader.read(buf);
-                if (read <= 0)
-                {
-                    return false;
-                }
-                else {
-                    final String header = new String(buf, 0, read);
-                    return header.contains("<specdocument");
-                }
-            }
-            catch (final IOException exception)
+            return doesFileContainOreqmHeader(file, path);
+        } else {
+            return false;
+        }
+    }
+
+    private static boolean doesFileContainOreqmHeader(final InputFile file, final String path) {
+        try (BufferedReader reader = file.createReader())
+        {
+            final char[] buf = new char[PEEK_CHARS];
+            final int read = reader.read(buf);
+            if (read <= 0)
             {
-                LOG.fine(() -> "Unable to peek XML file '" + path + "' trying to determine if it contains ReqM2 format: " + exception.getMessage());
                 return false;
             }
-        } else {
+            else {
+                final String header = new String(buf, 0, read);
+                return header.contains("<specdocument");
+            }
+        }
+        catch (final IOException exception)
+        {
+            LOG.fine(() -> "Unable to peek XML file '" + path + "' trying to determine if it contains ReqM2 format: " + exception.getMessage());
             return false;
         }
     }