Median filter sample.

Author: valentina-kustikova

include/auxiliaries.hpp

@@ -1,3 +1,5 @@
 #pragma once
 
-int parseArguments(int argc, char **argv);
+#include <string>
+
+int parseArguments(int argc, char **argv, std::string &fileName);

include/img_proc.hpp

@@ -6,8 +6,8 @@
 
 using namespace cv;
 
-int getFrame(Mat& src);
+int getFrame(const std::string &fileName, Mat& src);
 
 int processFrame(const Mat& src, Mat& dst);
 
-int show(const Mat& src, const Mat& dst);
+int show(const std::string &caption, const Mat& src, const Mat& dst);

samples/sample_template.cpp

@@ -9,23 +9,30 @@ using namespace cv;
 
 int main(int argc, char **argv)
 {
-	if (parseArguments(argc, argv) != 0)
+    const std::string caption = "Median filter";
+    std::string fileName;
+	if (parseArguments(argc, argv, fileName) != 0)
     {
-        cout << "Incorrect input parameters!" << endl;
+        cout << "practice2 <img_name>" << endl;
+        cout << "<img_name> - image name for filtering" << endl;
         return 1;
     }
 
     Mat src, dst;
 
-    if (getFrame(src) != 0)
+    if (getFrame(fileName, src) != 0)
     {
         cout << "Error: \'src\' image is null or empty!" << endl;
         return 2;
     }
 
-    processFrame(src, dst);
+    if (processFrame(src, dst) != 0)
+    {
+        cout << "Error: Filtering failed!" << endl;
+        return 3;
+    }
 
-    show(src, dst);
+    show(caption, src, dst);
 
 	return 0;
 }

src/auxiliaries.cpp

@@ -1,6 +1,11 @@
 #include "auxiliaries.hpp"
 
-int parseArguments(int argc, char **argv)
+int parseArguments(int argc, char **argv, std::string &fileName)
 {
+    if (argc < 2)
+    {
+        return 1;
+    }
+    fileName = std::string(argv[1]);
     return 0;
 }

src/img_proc.cpp

@@ -1,16 +1,38 @@
 #include "img_proc.hpp"
 
-int getFrame(Mat& src)
+int getFrame(const std::string &fileName, Mat& src)
 {
+    src = imread(fileName);
+    if (src.empty())
+    {
+        return 1;
+    }
     return 0;
 }
 
 int processFrame(const Mat& src, Mat& dst)
 {
+    const int kSize = 11;
+    medianBlur(src, dst, kSize);
     return 0;
 }
 
-int show(const Mat& src, const Mat& dst)
+int show(const std::string &caption, const Mat& src, const Mat& dst)
 {
+    if (src.rows != dst.rows || src.cols != dst.cols)
+    {
+        return 1;
+    }
+    
+    Mat display(src.rows, src.cols + dst.cols, src.type());
+    Mat srcRoi = display(Rect(0, 0, src.cols, src.rows));
+    src.copyTo(srcRoi);
+    Mat dstRoi = display(Rect(src.cols, 0, dst.cols, dst.rows));
+    dst.copyTo(dstRoi);
+
+    namedWindow(caption);
+    imshow(caption, display);
+    waitKey();
+
     return 0;
 }

test/CMakeLists.txt

@@ -8,9 +8,9 @@ INCLUDE_DIRECTORIES("${CMAKE_CURRENT_SOURCE_DIR}/../3rdparty/gtest")
 ADD_EXECUTABLE(${target} ${srcs} ${hdrs})
 TARGET_LINK_LIBRARIES(${target} gtest ${PRACTICE2_LIBRARY})
 
-#add_custom_command(
-#    TARGET ${PRACTICE2_TESTS}
-#    POST_BUILD
-#    COMMAND ln -fns "${CMAKE_SOURCE_DIR}/testdata" "${CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE}/testdata"
-#    COMMENT "Adding a symbolic link to testdata"
-#)
+add_custom_command(
+    TARGET ${PRACTICE2_TESTS}
+    POST_BUILD
+    COMMAND ln -fns "${CMAKE_SOURCE_DIR}/testdata" "${CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE}/testdata"
+    COMMENT "Adding a symbolic link to testdata"
+)

test/aux_test.cpp

@@ -1,11 +1,22 @@
 #include <gtest/gtest.h>
 #include "auxiliaries.hpp"
 
-TEST(practice2, parseArguments)
+TEST(practice2, parse_empty_arguments)
 {
     int argc = 0;
     char **argv = 0;
-    int res = parseArguments(argc, argv);
+    std::string fileName;
+    int res = parseArguments(argc, argv, fileName);
+
+    EXPECT_EQ(1, res);
+}
+
+TEST(practice2, parse_incorrect_arguments)
+{
+    int argc = 2;
+    char *argv[] = { "", "image.jpg" };
+    std::string fileName;
+    int res = parseArguments(argc, argv, fileName);
 
     EXPECT_EQ(0, res);
-}
+}

test/img_proc_test.cpp

@@ -0,0 +1,22 @@
+#include <gtest/gtest.h>
+#include "img_proc.hpp"
+
+TEST(practice2, median_filter_test)
+{
+    std::string input = "./testdata/image.jpg";
+    std::string expOutput = "./testdata/image_median_1.jpg";
+
+    Mat src, expDst, dst; 
+    getFrame(input, src);
+    getFrame(expOutput, expDst);
+    if (expDst.empty())
+    {
+        FAIL() << "Can't read" + expOutput + " image";
+    }
+
+    Mat diff = abs(expDst - dst);
+    Mat mask = diff.reshape(1) > 1;
+
+    EXPECT_EQ(0, countNonZero(mask));
+
+}