Refactor code structure for improved readability and maintainability

Author: itsfuad

.gitignore

@@ -0,0 +1,2 @@
+*.exe
+*.rdb

dump.rdb

@@ -40,24 +40,26 @@ var DefaultStore = NewStore()
 type HandlerFunc func(args []string) (string, error)
 
 var Commands = map[string]HandlerFunc{
-	"SET":      setHandler,
-	"GET":      getHandler,
-	"DEL":      delHandler,
-	"EXISTS":   existsHandler,
-	"LPUSH":    lpushHandler,
-	"RPUSH":    rpushHandler,
-	"LPOP":     lpopHandler,
-	"RPOP":     rpopHandler,
-	"LRANGE":   lrangeHandler,
-	"SADD":     saddHandler,
-	"SREM":     sremHandler,
-	"SMEMBERS": smembersHandler,
-	"KEYS":     keysHandler,
-	"FLUSHDB":  flushdbHandler,
-	"INFO":     infoHandler,
-	"EXPIRE":   expireHandler,
-	"TTL":      ttlHandler,
-	"SAVE":     snapshotHandler,
+	"SET":     setHandler,
+	"GET":     getHandler,
+	"DEL":     delHandler,
+	"EXISTS":  existsHandler,
+	"LPUSH":   lpushHandler,
+	"RPUSH":   rpushHandler,
+	"LPOP":    lpopHandler,
+	"RPOP":    rpopHandler,
+	"LRANGE":  lrangeHandler,
+	"LGET":    lgetHandler,
+	"LLEN":    llengHandler,
+	"SADD":    saddHandler,
+	"SREM":    sremHandler,
+	"SGET":    sgetHandler,
+	"KEYS":    keysHandler,
+	"FLUSHDB": flushdbHandler,
+	"INFO":    infoHandler,
+	"EXPIRE":  expireHandler,
+	"TTL":     ttlHandler,
+	"SAVE":    snapshotHandler,
 }
 
 func (s *Store) ttlCleaner() {
@@ -224,6 +226,34 @@ func lrangeHandler(args []string) (string, error) {
 	return strings.Join(lst[start:end+1], ","), nil
 }
 
+func lgetHandler(args []string) (string, error) {
+	if len(args) < 1 {
+		return "", fmt.Errorf("missing argument for LGET")
+	}
+	key := args[0]
+	DefaultStore.mu.RLock()
+	defer DefaultStore.mu.RUnlock()
+	if DefaultStore.types[key] != ListType {
+		return "", nil
+	}
+	lst := DefaultStore.data[key].([]string)
+	return strings.Join(lst, ","), nil
+}
+
+func llengHandler(args []string) (string, error) {
+	if len(args) < 1 {
+		return "", fmt.Errorf("missing argument for LLEN")
+	}
+	key := args[0]
+	DefaultStore.mu.RLock()
+	defer DefaultStore.mu.RUnlock()
+	if DefaultStore.types[key] != ListType {
+		return "0", nil
+	}
+	lst := DefaultStore.data[key].([]string)
+	return fmt.Sprintf("%d", len(lst)), nil
+}
+
 // Set commands
 func saddHandler(args []string) (string, error) {
 	if len(args) < 2 {
@@ -270,9 +300,9 @@ func sremHandler(args []string) (string, error) {
 	return fmt.Sprintf("%d", removed), nil
 }
 
-func smembersHandler(args []string) (string, error) {
+func sgetHandler(args []string) (string, error) {
 	if len(args) < 1 {
-		return "", fmt.Errorf("missing argument for SMEMBERS")
+		return "", fmt.Errorf("missing argument for SGET")
 	}
 	key := args[0]
 	DefaultStore.mu.RLock()

internal/db/db.go

@@ -71,14 +71,48 @@ func TestListCommands(t *testing.T) {
 	}
 }
 
+func TestNewListCommands(t *testing.T) {
+	DefaultStore = NewStore()
+	_, _ = lpushHandler([]string{"testlist", "a", "b", "c"}) // c, b, a
+
+	// Test LGET - get all elements
+	out, _ := lgetHandler([]string{"testlist"})
+	if out != "c,b,a" {
+		t.Errorf("expected c,b,a, got %s", out)
+	}
+
+	// Test LLEN - get length
+	length, _ := llengHandler([]string{"testlist"})
+	if length != "3" {
+		t.Errorf("expected 3, got %s", length)
+	}
+
+	// Test with non-existent list
+	out, _ = lgetHandler([]string{"nonexistent"})
+	if out != "" {
+		t.Errorf("expected empty string for non-existent list, got %s", out)
+	}
+
+	length, _ = llengHandler([]string{"nonexistent"})
+	if length != "0" {
+		t.Errorf("expected 0 for non-existent list, got %s", length)
+	}
+}
+
 func TestSetCommands(t *testing.T) {
 	DefaultStore = NewStore()
 	_, _ = saddHandler([]string{"myset", "a", "b", "c"})
 	_, _ = sremHandler([]string{"myset", "b"})
-	out, _ := smembersHandler([]string{"myset"})
+	out, _ := sgetHandler([]string{"myset"})
 	if !strings.Contains(out, "a") || !strings.Contains(out, "c") || strings.Contains(out, "b") {
 		t.Errorf("expected a and c, not b; got %s", out)
 	}
+
+	// Test SGET with non-existent set
+	out2, _ := sgetHandler([]string{"nonexistent"})
+	if out2 != "" {
+		t.Errorf("expected empty string for non-existent set, got %s", out2)
+	}
 }
 
 func TestMetaCommands(t *testing.T) {
@@ -151,7 +185,7 @@ func TestSnapshotSaveLoad(t *testing.T) {
 	if val != "snapval" {
 		t.Errorf("expected snapval after load, got %s", val)
 	}
-	members, _ := smembersHandler([]string{"snapset"})
+	members, _ := sgetHandler([]string{"snapset"})
 	if !(strings.Contains(members, "a") && strings.Contains(members, "b")) {
 		t.Errorf("expected set members a and b, got %s", members)
 	}

internal/db/db_test.go

@@ -68,9 +68,11 @@ func printHelp() {
 	LPOP k             - Pop value from head of list
 	RPOP k             - Pop value from tail of list
 	LRANGE k s e       - Get list elements from s to e
+	LGET k             - Get all list elements
+	LLEN k             - Get list length
 	SADD k v [v..]     - Add value(s) to set
 	SREM k v [v..]     - Remove value(s) from set
-	SMEMBERS k         - List all set members
+	SGET k             - Get all set members
 	KEYS               - List all keys
 	FLUSHDB            - Clear the database
 	INFO               - Show server info

internal/repl/repl.go

@@ -37,8 +37,8 @@ func EvalScript(script string) (string, error) {
 func getWhitelist() map[string]bool {
 	return map[string]bool{
 		"SET": true, "GET": true, "DEL": true, "EXISTS": true,
-		"LPUSH": true, "RPUSH": true, "LPOP": true, "RPOP": true, "LRANGE": true,
-		"SADD": true, "SREM": true, "SMEMBERS": true,
+		"LPUSH": true, "RPUSH": true, "LPOP": true, "RPOP": true, "LRANGE": true, "LGET": true, "LLEN": true,
+		"SADD": true, "SREM": true, "SGET": true,
 	}
 }
 

internal/script/script.go

@@ -83,9 +83,11 @@
 | `LPOP k`        | Pop value from head of list                 |
 | `RPOP k`        | Pop value from tail of list                 |
 | `LRANGE k s e`  | Get list elements from s to e               |
+| `LGET k`        | Get all list elements                        |
+| `LLEN k`        | Get list length                              |
 | `SADD k v [v..]`| Add value(s) to set                         |
 | `SREM k v [v..]`| Remove value(s) from set                    |
-| `SMEMBERS k`    | List all set members                        |
+| `SGET k`        | Get all set members                          |
 | `KEYS`          | List all keys                               |
 | `FLUSHDB`       | Clear the database                          |
 | `INFO`          | Show server info/stats                      |
@@ -114,12 +116,14 @@ t# mylist is now [b, a, c]
 LPOP mylist   # returns b
 RPOP mylist   # returns c
 LRANGE mylist 0 1  # returns a
+LGET mylist       # returns all elements: a
+LLEN mylist       # returns length: 1
 ```
 
 #### Set
 ```
 SADD myset x y z
-SMEMBERS myset   # returns x,y,z
+SGET myset       # returns x,y,z
 SREM myset y
 SMEMBERS myset   # returns x,z
 ```