Skip to content

Commit babd8a1

Browse files
itsjustkevinitsjustkevin
committed
Revert "Add a "pub workspace" to the root of the engine repository (flutter#53539)"
This reverts commit 8c1dd2f.
1 parent 8c1dd2f commit babd8a1

File tree

12 files changed

+59
-248
lines changed

12 files changed

+59
-248
lines changed

‎ci/licenses_golden/excluded_files‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
../../../flutter/.ci.yaml
1313
../../../flutter/.clang-format
1414
../../../flutter/.clang-tidy
15-
../../../flutter/.dart_tool
1615
../../../flutter/.git
1716
../../../flutter/.gitattributes
1817
../../../flutter/.github
@@ -253,8 +252,6 @@
253252
../../../flutter/lib/web_ui/pubspec.yaml
254253
../../../flutter/lib/web_ui/test
255254
../../../flutter/prebuilts
256-
../../../flutter/pubspec.lock
257-
../../../flutter/pubspec.yaml
258255
../../../flutter/runtime/dart_isolate_unittests.cc
259256
../../../flutter/runtime/dart_lifecycle_unittests.cc
260257
../../../flutter/runtime/dart_plugin_registrant_unittests.cc

‎lib/ui/channel_buffers.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,8 +400,6 @@ class ChannelBuffers {
400400
@Native<Void Function(Handle, Bool)>(symbol: 'PlatformConfigurationNativeApi::SendChannelUpdate')
401401
external static void _sendChannelUpdate(String name, bool listening);
402402

403-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
404-
// ignore: public_member_api_docs
405403
void sendChannelUpdate(String name, {required bool listening}) => _sendChannelUpdate(name, listening);
406404

407405
/// Deprecated. Migrate to [setListener] instead.

‎lib/ui/compositing.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,6 @@ class ShaderMaskEngineLayer extends _EngineLayerWrapper {
246246
/// This does not apply when using the `dart:ui` API directly, without using the
247247
/// Flutter framework bindings, `flutter_test` framework, et al.
248248
abstract class SceneBuilder {
249-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
250-
// ignore: public_member_api_docs
251249
factory SceneBuilder() = _NativeSceneBuilder;
252250

253251
/// Pushes a transform operation onto the operation stack.

‎lib/ui/experiments/scene.dart‎

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -50,34 +50,24 @@ base class SceneNode extends NativeFieldWrapperClass1 {
5050
return result;
5151
}
5252

53-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
54-
// ignore: public_member_api_docs
5553
static SceneNodeValue fromTransform(Float64List matrix4) {
5654
final SceneNode sceneNode = SceneNode._create();
5755
sceneNode._initFromTransform(matrix4);
5856
return SceneNodeValue.fromValue(sceneNode);
5957
}
6058

61-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
62-
// ignore: public_member_api_docs
6359
void addChild(SceneNode sceneNode) {
6460
_addChild(sceneNode);
6561
}
6662

67-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
68-
// ignore: public_member_api_docs
6963
void setTransform(Float64List matrix4) {
7064
_setTransform(matrix4);
7165
}
7266

73-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
74-
// ignore: public_member_api_docs
7567
void setAnimationState(String animationName, bool playing, bool loop, double weight, double timeScale) {
7668
_setAnimationState(animationName, playing, loop, weight, timeScale);
7769
}
7870

79-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
80-
// ignore: public_member_api_docs
8171
void seekAnimation(String animationName, double time) {
8272
_seekAnimation(animationName, time);
8373
}
@@ -136,45 +126,32 @@ base class SceneNode extends NativeFieldWrapperClass1 {
136126

137127
/// Returns a fresh instance of [SceneShader].
138128
SceneShader sceneShader() => SceneShader._(this, debugName: _debugName);
139-
140129
}
141130

142-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
143-
// ignore: public_member_api_docs
144131
class SceneNodeValue {
145132
SceneNodeValue._(this._future, this._value) {
146133
_future?.then((SceneNode result) => _value = result);
147134
}
148135

149-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
150-
// ignore: public_member_api_docs
151136
static SceneNodeValue fromFuture(Future<SceneNode> future) {
152137
return SceneNodeValue._(future, null);
153138
}
154139

155-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
156-
// ignore: public_member_api_docs
157140
static SceneNodeValue fromValue(SceneNode value) {
158141
return SceneNodeValue._(null, value);
159142
}
160143

161144
final Future<SceneNode>? _future;
162145
SceneNode? _value;
163146

164-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
165-
// ignore: public_member_api_docs
166147
bool get isComplete {
167148
return _value != null;
168149
}
169150

170-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
171-
// ignore: public_member_api_docs
172151
Future<SceneNode>? get future {
173152
return _future;
174153
}
175154

176-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
177-
// ignore: public_member_api_docs
178155
SceneNode? get value {
179156
return _value;
180157
}
@@ -209,8 +186,6 @@ base class SceneShader extends Shader {
209186
// ignore: unused_field
210187
final String? _debugName;
211188

212-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
213-
// ignore: public_member_api_docs
214189
void setCameraTransform(Float64List matrix4) {
215190
_setCameraTransform(matrix4);
216191
}

‎lib/ui/key.dart‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ enum KeyEventType {
1616
/// The key is held, causing a repeated key input.
1717
repeat;
1818

19-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
20-
// ignore: public_member_api_docs
2119
String get label {
2220
return switch (this) {
2321
down => 'Key Down',
@@ -48,8 +46,6 @@ enum KeyEventDeviceType {
4846
/// The device is a device connected to an HDMI bus.
4947
hdmi;
5048

51-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
52-
// ignore: public_member_api_docs
5349
String get label {
5450
return switch (this) {
5551
keyboard => 'Keyboard',

‎lib/ui/painting.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2598,8 +2598,6 @@ base class _NativeEngineLayer extends NativeFieldWrapperClass1 implements Engine
25982598
/// Paths can be drawn on canvases using [Canvas.drawPath], and can
25992599
/// used to create clip regions using [Canvas.clipPath].
26002600
abstract class Path {
2601-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
2602-
// ignore: public_member_api_docs
26032601
factory Path() = _NativePath;
26042602

26052603
/// Creates a copy of another [Path].

‎lib/ui/platform_dispatcher.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2195,8 +2195,6 @@ class ViewConstraints {
21952195
/// [DisplayFeatureState.postureHalfOpened]. For [DisplayFeatureType.cutout],
21962196
/// the state is not used and has the [DisplayFeatureState.unknown] value.
21972197
class DisplayFeature {
2198-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
2199-
// ignore: public_member_api_docs
22002198
const DisplayFeature({
22012199
required this.bounds,
22022200
required this.type,

‎lib/ui/semantics.dart‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -281,12 +281,8 @@ class SemanticsAction {
281281
_kFocusIndex: focus,
282282
};
283283

284-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
285-
// ignore: public_member_api_docs
286284
static List<SemanticsAction> get values => _kActionById.values.toList(growable: false);
287285

288-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
289-
// ignore: public_member_api_docs
290286
static SemanticsAction? fromIndex(int index) => _kActionById[index];
291287

292288
@override
@@ -639,12 +635,8 @@ class SemanticsFlag {
639635
_kIsExpandedIndex: isExpanded,
640636
};
641637

642-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
643-
// ignore: public_member_api_docs
644638
static List<SemanticsFlag> get values => _kFlagById.values.toList(growable: false);
645639

646-
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
647-
// ignore: public_member_api_docs
648640
static SemanticsFlag? fromIndex(int index) => _kFlagById[index];
649641

650642
@override

‎pubspec.yaml‎

Lines changed: 0 additions & 173 deletions
This file was deleted.

‎tools/clang_tidy/test/header_filter_regex_test.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ void main() {
3636
test('contains every root directory in the regex', () {
3737
// These are a list of directories that should _not_ be included.
3838
const Set<String> intentionallyOmitted = <String>{
39-
'.dart_tool',
4039
'.git',
4140
'.github',
4241
'build_overrides',

0 commit comments

Comments
 (0)