Skip to content

Commit 59af998

Browse files
committed
📝 Dockerfile and docker-compose minor changes
1 parent 00d24c2 commit 59af998

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ RUN npm run build
88

99
# Server
1010
FROM python:3.12-slim
11+
LABEL maintainer="github.com/itskovacs"
12+
LABEL description="Minimalist POI Map Tracker and Trip Planner"
1113
WORKDIR /app
12-
# Touch the files
1314
COPY backend .
14-
RUN pip install -r trip/requirements.txt
15-
# Copy to /app/frontend, where /app has the backend python files also
15+
RUN pip install --no-cache-dir -r trip/requirements.txt
1616
COPY --from=build /app/dist/trip/browser ./frontend
17-
EXPOSE 8080
17+
EXPOSE 8000
1818
CMD ["fastapi", "run", "/app/trip/main.py", "--host", "0.0.0.0", "--port", "8000"]

docker-compose.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
services:
22
app:
3-
build: .
3+
#build: .
4+
image: ghcr.io/itskovacs/trip:1
5+
user: "1000:1000"
46
ports:
57
- 127.0.0.1:8080:8000 #127.0.0.1: locally exposed, on port 8080 by default
68
volumes:
7-
- trip-storage:/app/storage #Do not change /app/storage, only the first part (./storage) if needed
8-
command: ["fastapi", "run", "/app/trip/main.py", "--host", "0.0.0.0"]
9-
10-
volumes:
11-
trip-storage:
9+
- ./storage:/app/storage #If you were previously using a named volume, follow https://github.com/itskovacs/trip/releases/tag/1.5.0 to migrate your data.
10+
command: ["fastapi", "run", "/app/trip/main.py", "--host", "0.0.0.0"]

0 commit comments

Comments
 (0)