[FR] Support engines other Google Maps

[marinho]

Is your feature request related to a problem? Please describe.

Not a specific problem, except that I am trying to avoid using Google tools more than I'm enforced too :-)

Describe the solution you'd like

My suggestion here is pretty straight forward: to refactor the /google-* routes (except *-import) into a model that can support extending to other engines. A first step would be just to make it agnostic, and then whoever wants to support other engines could just file a PR adding their engine of preference.

Additional context

I'd be glad to contribute on that change, as long as the suggestion is accepted. I wanted to start with an FR, as I'm new into Trip and I don't know previous history and decisions. Maybe that's already in progress anyhow :)

[itskovacs]

Hi @marinho 👋!

I think this is a pretty good idea, as I believe many are using dummy Google account for this. I made google-* specific functions only because at the time there were no other suitable option for this enrichment purpose.

Problem is, I don't see an option to migrate the functions (google-*) into more generic ones. I believe the easiest and quick-win solution is to move all these functions (if more are to come) into a dedicated providers.py file, that will hold google-* functions and others.

Couple of example as to why, see this code for google_search_text (@router.get("/google-search"), code):

async def google_search_text(
    q: str, session: SessionDep, current_user: Annotated[str, Depends(get_current_username)]
) -> list[GooglePlaceResult]:
    if not q or not q.strip():
        raise HTTPException(status_code=400, detail="Bad Request")

    api_key = _get_user_api_key(session, current_user)
    results = await gmaps_textsearch(q.strip(), api_key)
    if not results:
        return []

    async def _process_result(
        place_data: dict,
        api_key: str,
    ) -> GooglePlaceResult | None:
        try:
            return await result_to_place(place_data, api_key)
        except Exception:
            return None

    return await _process_gmaps_batch(
        results,
        api_key,
        _process_result,
    )

• We use a specific Google api_key, I'm sure other services would require an API key as well and I think making n functions instead of a switch case is more appropriate
• We use a specific parsing function, same as before, I think making n functions instead of calling the adequat function through a switch case is more appropriate

One good thing though is that the google parsing functions are currently located in a dedicated gmaps.py file, so it's easy to simply create a my-exotic-parser.py file and move them into a dedicated providers folder.

So, in my opinion, solution is to:

• migrate the google-* functions into a dedicated files, to allow for other as well and name them using the service name like exotic-*
• move the gmaps.py from the /utils/ folder to a /utils/providers/ or alike folder

EDIT: Or I could migrate the providers into Classes (creating a GeoProviderGoogle), that would extend a basic GeoProviderBase and implement its functions (text_search, nearby_search, etc.). It's an idea 👍

[itskovacs]

Hi 👋,

1.39.0 lays the foundation with OSM Nominatim support. It's an initial step, but already offers near-parity with GoogAPI features 👍