[FR] mark plan item as 'private'

[sjorge]

💡 Something similar has been implemented were an entire trip can be shared without attachments. However it's currently not possible to hide individual plan items entirely.

Is your feature request related to a problem? Please describe.

It's nice that trips can be shared, but that gives access to all information.

It would be nice to be able to somehow mark a plan item as private, it can still be included but at least "Plan Text", "Comment", "Attachments" should be private.

I ran into this when i tried to share a trip with my mom so I could talk about my plans with her but I was surprised to see that the person with the link could also see the attached PDFs with plane tickets, QR codes on pre-booked tickets, ...

Describe the solution you'd like

A way to mark a plan item as private.

Those private items only show limited info when accessing the trip via the share link. (Can still show everything if a 2nd person is invited)

It's probably OK to show time and place, that allows all features like highlighting, navigation, ... to keep working.
I think the following would make sense:

• attachments: hidden
• comment: hidden
• plan text: I'm not so sure, I'd say hidden too but in my case they don't really have anything sensitive so maybe OK just hidding attachment/comment.

Additional context

I think I covered why this would be useful in the first textbox.

Oh I'm also having trouble to copy the share URL

It gets truncated but I have not tried on my desktop yet, so it might be a side effect from being on my 13-inch macbook att the moment. If I don't forget I will retest later on my desktop and file an issue if it's also broken.

Could you implement it?

No - I can't implement it right now

Implementation plan (optional)

No response

[itskovacs]

Hi 👋,

Nice idea, I like the concept. I'll think about the best way to implement it, since updating the models could be a fairly large change.

The link is intentionally truncated with a button on its right, but you're right there's a mistake in the dark template, the button is hidden due to a missing class. I've pushed the commit to fix it 👍

[sjorge]

Been thinking about this some more from a user experience, kind of came to the conclusion there might be 3 stats for item privacy:

1. public (everything visible (current state))
2. private (limited visibility: only time, plan text, place visible) --> should be enough show someone the plan but hiding comments that can contain some sensitive info and attachments
3. hidden (everything hidden) --> just 'omitted' entirely (1 and 2 will see a lot of use by me, I can see some use for 3 too but I think we'd be OK without?)

Spots where this state has impact:

• normal trip planning: no impact, show everything as currently is
• trip via shared link: depends on plan privacy setting, public=no change, private=hide comments and attachments, hidden=hide everything
• pretty print page: add extra 'toggle' include private plans (default=true), true => show everything (depending on field selection), false => public = depends on field selec, private = depends on field selection (but limited to max of time, plan text, place), hidden = show nothing

I'm not sure how to best do the UI on the plan item dialog:

But there status dropdown is pretty big so adding the privacy dropdown behind it could work.

[itskovacs]

I was thinking of adding a sharing column with values complete | partial and including a checkbox in the share modal. Same approach 👍

[itskovacs]

Hi 👋,

1.41.0 implements the partial sharing feature, only change on your idea is that I do include comments/notes for plan/day/trip, as I believe this is supposed to be context and not sensitive information 👍

[sjorge]

Is it a cache issue again? I'm not seeing to mark which items should not be shared/partially shared.

I wanted to mark the items with some medical stuff like allergies as private to test it out.

[itskovacs]

Oh, no, this only discard attachments and some private things like who paid 😅

[sjorge]

Ah, that's a start I guess.

I guess I wasn't super clear in the FR. I wanted to toggle an entire item to show/hide/(partial), not all items 😅

[sjorge]

Should I make a new one for that one explaining it in more detail? Or can we reopen this?