Replies: 4 comments 15 replies
-
|
Just for completeness; It fails in the build step |
Beta Was this translation helpful? Give feedback.
-
|
For now doing the frontend build a cloud vm and copying the results works but it's rather cumbersome and annoying. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @sjorge 👋,
And considering my package lock: I believe this error falls into Tailwindcss bucket for debugging as it's not related at all to Trip, though there might be option on my side to circumvent this for now as discussed in tailwindlabs/tailwindcss#15806 (comment). I'll dig a bit more in a couple of days, as this is not a critical bug and there are options for now, but is important to consider. Thanks for the heads-up! |
Beta Was this translation helpful? Give feedback.
-
|
Yeah just a compile version of src/src/dist/dist/trip/browser, the running it somewhere is as simple as And updates are just a git pull + new frontend artifact download. Which is basically the result of the dockerfile's /app folder then. |
Beta Was this translation helpful? Give feedback.
-
|
Alright, got it 😄. I'll add this to my backlog, to add a |
Beta Was this translation helpful? Give feedback.
-
|
Hi 👋, |
Beta Was this translation helpful? Give feedback.
-
|
Perfect! I git pulled and extracted the compiled frontend from the tgz and all is working well <3 |
Beta Was this translation helpful? Give feedback.
-
|
Awesome 👍, will keep adding them from now on |
Beta Was this translation helpful? Give feedback.
-
|
Just sharing as it's now super easy to update trip without docker: #!/bin/bash
ver="1.34.1"
tar_bin="tar"
if which gtar > /dev/null 2>/dev/null; then
tar_bin="gtar"
fi
[ -d /opt/trip/trip ] && rm -rf /opt/trip/trip
[ -d /opt/trip/frontend ] && rm -rf /opt/trip/frontend
mkdir -p /opt/trip/storage /opr/trip/frontend
curl -L https://github.com/itskovacs/trip/archive/refs/tags/${ver}.tar.gz | $tar_bin -xzvp --strip-component=2 -C /opt/trip trip-${ver}/backend/
curl -L https://github.com/itskovacs/trip/releases/download/${ver}/dist_${ver}.tgz | $tar_bin -xzvp -C /opt/trip/frontend/
[ -d /opt/trip/venv ] || python3 -m venv --system-site-packages --upgrade-deps --clear /opt/trip/venv
/opt/trip/venv/bin/pip install -r /opt/trip/trip/requirements.txt
if [ ! -e /var/svc/manifest/network/trip.xml ] then
cat > /var/svc/manifest/network/trip.xml <<EOF
<?xml version='1.0'?>
<!DOCTYPE service_bundle SYSTEM '/usr/share/lib/xml/dtd/service_bundle.dtd.1'>
<service_bundle type='manifest' name='export'>
<service name='network/trip' type='service' version='0'>
<create_default_instance enabled='true'/>
<single_instance/>
<dependency name='network' grouping='require_all' restart_on='error' type='service'>
<service_fmri value='svc:/milestone/network:default'/>
</dependency>
<dependency name='filesystem' grouping='require_all' restart_on='error' type='service'>
<service_fmri value='svc:/system/filesystem/local'/>
</dependency>
<method_context security_flags='aslr' working_directory='/opt/trip'>
<method_credential group='other' privileges='basic,net_privaddr,!proc_info,!proc_session,!file_link_any' user='daemon'/>
<method_environment>
<envvar name='PATH' value='/opt/trip/venv/bin/:/usr/sbin:/sbin:/opt/ooce/sbin:/usr/bin:/opt/ooce/bin'/>
</method_environment>
</method_context>
<exec_method name='start' type='method' exec='fastapi run trip/main.py --host %{config/fastapi_host} --port %{config/fastapi_port}' timeout_seconds='60'/>
<exec_method name='stop' type='method' exec=':kill' timeout_seconds='60'/>
<exec_method name='refresh' type='method' exec=':true' timeout_seconds='60'/>
<property_group name='config' type='application'>
<propval name='fastapi_host' type='astring' value='localhost'/>
<propval name='fastapi_port' type='astring' value='8000'/>
</property_group>
<property_group name='startd' type='framework'>
<propval name='duration' type='astring' value='child'/>
<propval name='ignore_error' type='astring' value='core,signal'/>
</property_group>
<stability value='Evolving'/>
<template>
<common_name>
<loctext xml:lang='C'>Trip Planner</loctext>
</common_name>
</template>
</service>
</service_bundle>
EOF
svccfg import /var/svc/manifest/network/trip.xml
fi
svcadm restart tripthe svcadm call is for the service manager on illumos so that probably needs replacing. |
Beta Was this translation helpful? Give feedback.
-
|
Hi there 👋, Would you mind making a small docs about this to describe your flow? Just a couple of lines. |
Beta Was this translation helpful? Give feedback.
-
|
I've updated the command above to also take care of the install, at least on illumos. If you drop the svccfg/svcadm commands this can probably be used as a basis to run it anywhere. The gist of it is that it installs into /opt/trip, where all the config lives in /opt/strip/storage. As long as the system python or the venv has all the dependencies installed it will just work. No messing with getting the frontend to compile as that is now included in the github releases :) |
Beta Was this translation helpful? Give feedback.
-
|
Perfect, thank you! 👍 |
Beta Was this translation helpful? Give feedback.
-
|
I'm pretty bad at writing docs so I gave chatgpt the script and added some extra comments, then did a cleanup pass where it got things wrong: |
Beta Was this translation helpful? Give feedback.
-
|
I've encountered this error in the CI build and after googling for some time I managed to fix it. It should fix yours as well. Let me know if it does 👍 |
Beta Was this translation helpful? Give feedback.
-
|
Sadly it doesn't, as there just isn't a binary available for illumos, and I was unable to build one manually. But my little script is working well, I now also auto default to the latest by replacing the ver variable with Updates are a breeze since the extra dist file is being published. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Is your feature request related to a problem? Please describe.
Very minor but for now it seems something is pulling in lightningcss to compile the scss files, lighthingcss is not available on all platforms like illumos, solaris, and some *BSD's (although freebsd does seem to be available)
The scss files seem rather small so I don't think the slight performence boost over postcss would be noticeable.
Describe the solution you'd like
No dependancy on lightningcss, or option to configure an alternative like postcss.
Additional context
I did have a look around to see if I could compile the lightningcss.-.node binary myself but I have not found a way to do so. I also looked if I could figure out what was calling lightningcss but I don't really understand the stack and wasn't successful. It seems to be either tailwindcss, which does seem to also support postcss or vite which only optionally depends on lightningcss.
I was unsuccessful, but i also don't understand what would be calling it as the mentioned config files to configure the usage of lightningcss do not seem to be present.
Beta Was this translation helpful? Give feedback.
All reactions