Type our FaceParts object

I went down the path of typing our requests as they had additional
information on them, but it was simpler to just remove that
param-handling and simply do it inline in the one place that it was
used.

Author: rylnd

src/lib/potato.ts

@@ -1,8 +1,14 @@
-// our libs
 import { sumAndDiff } from './hashingFunctions';
 import { allPaths } from './imageFiles';
 import SlotMachine from './slotMachine';
 
+export interface FaceParts {
+  color: string;
+  eyes: string;
+  nose: string;
+  mouth: string;
+}
+
 const colors = [
   '#81bef1',
   '#ad8bf2',
@@ -23,8 +29,7 @@ class Potato {
     private mouthMachine = new SlotMachine(allPaths('mouth'), sumAndDiff),
   ) {}
 
-  // Construct Faces Parts
-  parts(string) {
+  parts(string): FaceParts {
     return {
       color: this.colorMachine.pull(string),
       eyes: this.eyesMachine.pull(string),

src/routes/index.ts

@@ -15,13 +15,6 @@ const sendImage = ({ stdout, response }) => {
   stdout.pipe(response);
 };
 
-router.param('id', (req, res, next, id) => {
-  const faceParts = potato.parts(id);
-  // @ts-ignore
-  req.faceParts = faceParts;
-  return next();
-});
-
 router.get('/list', (req, res) => {
   const response = { face: {} };
 
@@ -41,8 +34,9 @@ router.get('/:size?/random', (req, res) => {
 });
 
 router.get('/:size?/:id', (req, res, next) => {
-  // @ts-ignore
-  return combine(req.faceParts, req.params.size, (err, stdout) =>
+  const faceParts = potato.parts(req.params.id);
+
+  return combine(faceParts, req.params.size, (err, stdout) =>
     sendImage({ stdout, response: res }),
   );
 });