Skip to content

Commit 48e8b20

Browse files
committed
show field name for required and default check
1 parent dad3575 commit 48e8b20

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

flagset.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ func (f *FlagSetFiller) processField(flagSet *flag.FlagSet, fieldRef any,
262262
// Check for required tag and validate it doesn't conflict with default
263263
_, hasRequiredTag := tag.Lookup(TagRequired)
264264
if hasRequiredTag && hasDefaultTag {
265-
return fmt.Errorf("field cannot be both required and have a default value")
265+
return fmt.Errorf("field %q cannot be both required and have a default value", name)
266266
}
267267

268268
var renamed string

flagset_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,6 +1048,7 @@ func TestRequiredFieldWithDefault(t *testing.T) {
10481048
err := filler.Fill(&flagset, &config)
10491049
assert.Error(t, err)
10501050
assert.Contains(t, err.Error(), "cannot be both required and have a default")
1051+
assert.Contains(t, err.Error(), "\"Host\"")
10511052
}
10521053

10531054
func TestMultipleRequiredFields(t *testing.T) {

0 commit comments

Comments
 (0)