most of the requested changes

Author: Crafter-Y

src/main/java/me/itzg/helpers/sync/MulitCopyCommand.java

@@ -73,7 +73,7 @@ public class MulitCopyCommand implements Callable<Integer> {
     @Option(names = "--delimiter", defaultValue = "@",
         description = "When using per-file destinations, which symbol should be used to delimit destination<delimiter>source"
     )
-    String stringDelimiter;
+    String destinationDelimiter;
 
     @Parameters(split = SPLIT_COMMA_NL, splitSynopsisLabel = SPLIT_SYNOPSIS_COMMA_NL, arity = "1..*",
         paramLabel = "SRC",
@@ -88,7 +88,7 @@ public Integer call() throws Exception {
         Flux.fromIterable(sources)
             .map(String::trim)
             .filter(s -> !s.isEmpty())
-            .flatMap(source -> processSource(source, fileIsListingOption, null))
+            .flatMap(source -> processSource(source, fileIsListingOption, dest))
             .collectList()
             .flatMap(this::cleanupAndSaveManifest)
             .block();
@@ -118,16 +118,12 @@ private Mono<?> cleanupAndSaveManifest(List<Path> paths) {
 
     @SuppressWarnings("BlockingMethodInNonBlockingContext") // idk if that is a good idea
     private Publisher<Path> processSource(String source, boolean fileIsListing, Path parentDestination) {
-        Path destination = dest;
+        Path destination = parentDestination;
 
-        if (parentDestination != null) {
-            destination = parentDestination;
-        }
-
-        if (source.contains(stringDelimiter)) {
-            String[] split = source.split(stringDelimiter);
-            destination = destination.resolve(Paths.get(split[0]));
-            source = split[1];
+        final int delimiterPos = source.indexOf(destinationDelimiter);
+        if (delimiterPos > 0) {
+            destination = destination.resolve(Paths.get(source.substring(0, delimiterPos)));
+            source = source.substring(delimiterPos + 1);
         }
 
         if (fileIsListing) {

src/test/java/me/itzg/helpers/sync/MulitCopyCommandTest.java

@@ -55,7 +55,7 @@ void oneWithInlineDestination() throws IOException {
             final int exitCode = new CommandLine(new MulitCopyCommand())
                 .execute(
                     "--to", tempDir.toString(),
-                    destDir + "@" +srcFile.toString()
+                    "dest@" +srcFile.toString()
                 );
             assertThat(exitCode).isEqualTo(CommandLine.ExitCode.OK);
 
@@ -98,8 +98,8 @@ void commaDelimitedMultipleDest() throws IOException {
                 .execute(
                     "--to", tempDir.toString(),
                     String.join(",",
-                        destDir1 + "@" + srcTxt.toString(),
-                        destDir2 + "@" + srcJar.toString()
+                        "dest1@" + srcTxt.toString(),
+                        "dest2@" + srcJar.toString()
                     )
                 );
             assertThat(exitCode).isEqualTo(CommandLine.ExitCode.OK);
@@ -227,7 +227,7 @@ void toInlineDir() throws IOException {
             final int exitCode = new CommandLine(new MulitCopyCommand())
                 .execute(
                     "--to", tempDir.toString(),
-                    destDir + "@" + srcDir
+                    "dest@" + srcDir
                 );
             assertThat(exitCode).isEqualTo(CommandLine.ExitCode.OK);
 
@@ -323,7 +323,7 @@ void managedWithManifestAndMultipleDest() throws IOException {
                 .execute(
                     "--to", tempDir.toString(),
                     "--scope", "managedWithManifest",
-                    destDir1 + "@" + srcTxt + "," + destDir2 + "@" + srcJar
+                    "dest1@" + srcTxt + "," + "dest2@" + srcJar
                 );
             assertThat(exitCode).isEqualTo(CommandLine.ExitCode.OK);
 
@@ -404,7 +404,7 @@ void remoteFileWithInlineDest(WireMockRuntimeInfo wmInfo) {
             final int exitCode = new CommandLine(new MulitCopyCommand())
                 .execute(
                     "--to", tempDir.toString(),
-                    destDir + "@" + wmInfo.getHttpBaseUrl() + "/file.jar"
+                    "dest@" + wmInfo.getHttpBaseUrl() + "/file.jar"
                 );
             assertThat(exitCode).isEqualTo(CommandLine.ExitCode.OK);
 
@@ -447,8 +447,8 @@ void listingOfRemoteFilesWithInlineDest(WireMockRuntimeInfo wmInfo) throws IOExc
             final Path destDir2 = tempDir.resolve("dest2");
 
             final Path listing = Files.write(tempDir.resolve("listing.txt"), Arrays.asList(
-                destDir1 + "@" + wmInfo.getHttpBaseUrl() + "/file1.jar",
-                destDir2 + "@" +wmInfo.getHttpBaseUrl() + "/file2.jar"
+                "dest1@" + wmInfo.getHttpBaseUrl() + "/file1.jar",
+                "dest2@" +wmInfo.getHttpBaseUrl() + "/file2.jar"
             ));
 
             final int exitCode = new CommandLine(new MulitCopyCommand())
@@ -496,8 +496,8 @@ void remoteListingOfRemoteFilesWithInlineDest(WireMockRuntimeInfo wmInfo) {
             final Path destDir2 = tempDir.resolve("dest2");
 
             stubRemoteSrc("listing.txt",
-                destDir1 + "@" + wmInfo.getHttpBaseUrl() + "/file1.jar\n" +
-                    destDir2 + "@" + wmInfo.getHttpBaseUrl() + "/file2.jar\n"
+                "dest1@" + wmInfo.getHttpBaseUrl() + "/file1.jar\n" +
+                    "dest2@" + wmInfo.getHttpBaseUrl() + "/file2.jar\n"
             );
             stubRemoteSrc("file1.jar", "one");
             stubRemoteSrc("file2.jar", "two");
@@ -553,8 +553,8 @@ void remoteListingOfLocalFilesWithInlineDest(WireMockRuntimeInfo wmInfo) throws
             final Path srcJar = writeLine(srcDir, "two.jar", "two");
 
             stubRemoteSrc("listing.txt",
-                destDir1 + "@" + srcTxt + "\n" +
-                    destDir2 + "@" +  srcJar + "\n"
+                "dest1@" + srcTxt + "\n" +
+                    "dest2@" +  srcJar + "\n"
             );
 
             final int exitCode = new CommandLine(new MulitCopyCommand())