get: also benefits from temp download mechanism

Author: itzg

src/main/java/me/itzg/helpers/get/GetCommand.java

@@ -134,11 +134,6 @@ public class GetCommand implements Callable<Integer> {
     @Option(names = "--retry-delay", description = "in seconds", defaultValue = "2")
     int retryDelay;
 
-    @Option(names = {"--use-temp-file"},
-        description = "Download to a temporary file in the same directory with .download extension, then rename to the final destination when complete",
-        defaultValue = "false")
-    boolean useTempFile;
-
     @Parameters(split = OPTION_SPLIT_COMMAS, paramLabel = "URI",
         description = "The URI of the resource to retrieve. When the output is a directory,"
             + " more than one URI can be requested.",
@@ -214,10 +209,8 @@ null, new JsonPathOutputHandler(
                         stdout.println(outputFile);
                     }
                 } else {
-                    final Path saveToFile = getSaveToFile();
-                    try {
                         final Path file = fetch(uris.get(0))
-                            .toFile(saveToFile)
+                        .toFile(outputFile)
                             .skipUpToDate(skipUpToDate)
                             .acceptContentTypes(acceptContentTypes)
                             .handleDownloaded((uri, f, contentSizeBytes) -> {
@@ -226,25 +219,9 @@ null, new JsonPathOutputHandler(
                                 }
                             })
                             .execute();
-                        if (useTempFile) {
-                            Files.move(saveToFile, outputFile);
-                        }
                         if (this.outputFilename) {
                             stdout.println(file);
                         }
-                    } catch (Exception e) {
-                        // Clean up temp file if download fails
-                        if (useTempFile && Files.exists(saveToFile)) {
-                            try {
-                                Files.delete(saveToFile);
-                                log.debug("Cleaned up temporary file {} after failed download", saveToFile);
-                            } catch (IOException cleanupEx) {
-                                log.warn("Failed to clean up temporary file {} after failed download", 
-                                    saveToFile, cleanupEx);
-                            }
-                        }
-                        throw e; // Re-throw the original exception
-                    }
                 }
             }
         } catch (URISyntaxException e) {
@@ -500,10 +477,5 @@ private static URI removeUserInfo(URI uri) throws URISyntaxException {
         );
     }
 
-    private Path getSaveToFile() {
-        return useTempFile ? 
-            Paths.get(outputFile.toString() + ".download") : 
-            outputFile;
-    }
 
 }