feat(users): not keeping UUIDs of existing users in white/ops list

Author: FedotCompot

src/main/java/me/itzg/helpers/users/ManageUsersCommand.java

@@ -233,14 +233,6 @@ private JavaUser resolveJavaUserId(SharedFetch sharedFetch, List<? extends JavaU
                     return getOfflineUUID(user.getName());
                 }
 
-                // ...or username
-                for (final JavaUser existingUser : existing) {
-                    if (existingUser.getName().equalsIgnoreCase(user.getName())) {
-                        log.debug("Resolved '{}' from existing user entry by name: {}", user.getName(), existingUser);
-                        return existingUser;
-                    }
-                }
-
                 final Path userCacheFile = outputDirectory.resolve("usercache.json");
                 if (Files.exists(userCacheFile)) {
                     try {

src/test/java/me/itzg/helpers/users/ManageUsersCommandTest.java

@@ -112,8 +112,8 @@ void givenNamesAndAllExist(WireMockRuntimeInfo wmInfo) throws IOException {
                         )
                 );
 
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
+            verify(1, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
+            verify(1, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
         }
 
         @Test
@@ -230,7 +230,7 @@ void oneLessInList(WireMockRuntimeInfo wmInfo) throws IOException {
                         )
                 );
 
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
+            verify(1, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
             verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
         }
 
@@ -604,7 +604,7 @@ void changeOnlineToOffline(WireMockRuntimeInfo wmInfo) throws IOException {
                 );
 
             verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
+            verify(1, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
         }
 
         @Test
@@ -650,8 +650,8 @@ void changeOfflineToOnline(WireMockRuntimeInfo wmInfo) throws IOException {
                         )
                 );
 
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
-            verify(0, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
+            verify(1, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user1")));
+            verify(1, getRequestedFor(urlEqualTo("/users/profiles/minecraft/user2")));
         }
 
     }