Skip to content

Commit b59babb

Browse files
committed
neoforge: handle new version ordering
1 parent 5da89be commit b59babb

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/main/java/me/itzg/helpers/forge/NeoForgeInstallerResolver.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import me.itzg.helpers.http.SharedFetch;
1515
import me.itzg.helpers.mvn.MavenMetadata;
1616
import me.itzg.helpers.mvn.MavenRepoApi;
17+
import org.apache.maven.artifact.versioning.ComparableVersion;
1718
import org.jetbrains.annotations.NotNull;
1819
import org.jetbrains.annotations.Nullable;
1920

@@ -126,7 +127,10 @@ else if (requestedNeoForgeVersion == null || requestedNeoForgeVersion.equalsIgno
126127
}
127128
}
128129
})
129-
.reduce((s, s2) -> s2)
130+
// pick the highest version from a or b
131+
.reduce((a, b) ->
132+
new ComparableVersion(a).compareTo(new ComparableVersion(b)) > 0 ? a : b
133+
)
130134
.orElse(null);
131135

132136
return result != null ? new VersionPair(deriveMinecraftVersion(result), result) : null;

0 commit comments

Comments
 (0)