-
-
Notifications
You must be signed in to change notification settings - Fork 46
feat : add custom highlight to add color to logs #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
itzg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks.
Can you see if logback has helper methods to query if current context is a terminal that supports colors?
itzg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to using the withJansi feature here
|
This is excatly what i am trying to do but when it's set to true it does not have color anymore ^^ |
|
this does not color the logs ! when i desactivate withJansi they are colored back |
|
It looks like you need to use their highlight and not your custom one. |
|
i tried... no with theyr highlight it does not work too |
|
It worked fine for me; however, I did have to run it in a regular terminal rather than within IntelliJ's run config (in my case). This what I ran to test the changes: and this is what I have for the pattern: |
|
okay but outside of intellIj terminal right ? |
I don't want to use custom highlighting if their built-in works -- besides yours is still missing the is-terminal conditional. I would prefer to have it not match colors than reinvent their wheel. |
|
as you want. But i do not reinvent their wheel, i just customize the colors of the highlight -- |
|
I can't see that they're conditionalizing either, so I'm fine with your custom one then Double checked theirs at |
itzg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Kicked off a release build to get included in image |
Thanks a lot ! |


No description provided.