Merge pull request scalative#179 from scalative/tox-flake8

Run flake8 with tox

Author: sjagoe

.travis.yml

@@ -33,6 +33,9 @@ matrix:
       language: shell
       env: TOXPY36="/usr/local/bin/python3" TOXENV="cp36"
       python: "3.6"
+    - dist: xenial
+      python: "3.7"
+      env: TOXENV="flake8"
 
   allow_failures:
     - os: osx
@@ -65,6 +68,9 @@ notifications:
     - [email protected]
 
 after_success:
-  - if [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then pip install "idna < 2.8"; fi
-  - pip install coveralls
-  - coveralls
+  - |
+    if [[ "$TOXENV" != "flake8" ]]; then
+      if [[ "$TRAVIS_PYTHON_VERSION" == "2.6" ]]; then pip install "idna < 2.8"; fi
+      pip install coveralls
+      coveralls
+    fi

haas/plugin_manager.py

@@ -9,15 +9,15 @@
 import sys
 import logging
 
+from stevedore.extension import ExtensionManager
+
+from .utils import uncamelcase
+
 if sys.version_info < (2, 7):  # pragma: no cover
     from ordereddict import OrderedDict
 else:  # pragma: no cover
     from collections import OrderedDict
 
-from stevedore.extension import ExtensionManager
-
-from .utils import uncamelcase
-
 logger = logging.getLogger(__name__)
 
 

haas/plugins/runner.py

@@ -53,7 +53,7 @@ def run(self, result_collector, test):
                     warnings.filterwarnings(
                         'module',
                         category=DeprecationWarning,
-                        message='Please use assert\w+ instead.')
+                        message=r'Please use assert\w+ instead.')
             result_collector.startTestRun()
             try:
                 test(result_collector)

haas/tests/test_loader.py

@@ -44,7 +44,8 @@ def test_raises_for_test_suite(self):
 
     def test_create_custom_class(self):
         loader = Loader(test_case_class=_test_case_data.TestCaseSubclass)
-        test = loader.load_test(_test_case_data.TestCaseSubclass, 'test_method')
+        test = loader.load_test(
+            _test_case_data.TestCaseSubclass, 'test_method')
         self.assertIsInstance(test, _test_case_data.TestCaseSubclass)
 
     def test_create_custom_class_raises(self):

haas/utils.py

@@ -59,7 +59,7 @@ def get_module_by_name(name):
 
 
 def uncamelcase(string, sep='_'):
-    replace = '\g<before>{0}\g<caps>'.format(sep)
+    replace = r'\g<before>{0}\g<caps>'.format(sep)
     temp = UNCAMELCASE_FIRST_PASS.sub(replace, string)
     return UNCAMELCASE_SECOND_PASS.sub(replace, temp).lower()
 

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = cp{26,27,33,34,35},pp{2,3},cp26-win
+envlist = cp{26,27,33,34,35},pp{2,3},cp26-win,flake8
 minversion=2.7
 
 [testenv]
@@ -52,3 +52,16 @@ commands =
 # The tox environment for cp33 needs a specific set of base
 # dependencies for wheel, pip and setuptools
 deps = -rcp33-tox-requirements.txt
+
+[testenv:flake8]
+basepython = python3
+skip_install = true
+deps = flake8
+commands = flake8
+
+[flake8]
+exclude =
+    .tox,
+    .git,
+    __pycache__,
+    docs/source/conf.py