Skip to content

Commit 3d83685

Browse files
committed
Merge pull request #587 from fodinabor/UITextInputSelectionFix
Fixes text selection in UITextInput when cursor is out of the box
2 parents 1623475 + fb1c0a6 commit 3d83685

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Modules/Contents/UI/Source/PolyUITextInput.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ UITextInput::UITextInput(bool multiLine, Number width, Number height) : UIElemen
141141
textContainer->setPosition(padding + decoratorOffset, padding + textInputOffsetY);
142142

143143
inputRect->addEventListener(this, InputEvent::EVENT_MOUSEDOWN);
144-
inputRect->addEventListener(this, InputEvent::EVENT_MOUSEUP);
145144
inputRect->addEventListener(this, InputEvent::EVENT_MOUSEWHEEL_DOWN);
146145
inputRect->addEventListener(this, InputEvent::EVENT_MOUSEWHEEL_UP);
147146
inputRect->addEventListener(this, InputEvent::EVENT_DOUBLECLICK);
@@ -221,6 +220,7 @@ UITextInput::UITextInput(bool multiLine, Number width, Number height) : UIElemen
221220
indentType = INDENT_TAB;
222221

223222
core->getInput()->addEventListener(this, InputEvent::EVENT_KEYDOWN);
223+
core->getInput()->addEventListener(this, InputEvent::EVENT_MOUSEUP);
224224
}
225225

226226
void UITextInput::checkBufferLines() {
@@ -2495,6 +2495,9 @@ void UITextInput::handleEvent(Event *event) {
24952495
InputEvent *inputEvent = (InputEvent*) event;
24962496
onKeyDown(inputEvent->key, inputEvent->charCode);
24972497
}
2498+
if (event->getEventCode() == InputEvent::EVENT_MOUSEUP) {
2499+
draggingSelection = false;
2500+
}
24982501
}
24992502

25002503
if(event->getDispatcher() == contextMenu) {
@@ -2565,9 +2568,6 @@ void UITextInput::handleEvent(Event *event) {
25652568
draggingSelection = true;
25662569
}
25672570
break;
2568-
case InputEvent::EVENT_MOUSEUP:
2569-
draggingSelection = false;
2570-
break;
25712571
case InputEvent::EVENT_MOUSEWHEEL_UP:
25722572
if(scrollContainer) {
25732573
scrollContainer->_onMouseWheelUp();

0 commit comments

Comments
 (0)