Added unit test for replacing Entity Framework database (#125)

Author: ivaylokenov

MyTested.AspNetCore.Mvc.sln

@@ -62,6 +62,8 @@ Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "MyTested.AspNetCore.Mvc.Dat
 EndProject
 Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "MyTested.AspNetCore.Mvc.EntityFrameworkCore", "src\MyTested.AspNetCore.Mvc.EntityFrameworkCore\MyTested.AspNetCore.Mvc.EntityFrameworkCore.xproj", "{0BE034FD-B68B-4D52-A0C5-29BCDBF543DC}"
 EndProject
+Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test", "test\MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test\MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test.xproj", "{285E08F2-2E5A-4226-B867-FD3DF7C52053}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -156,6 +158,10 @@ Global
 		{0BE034FD-B68B-4D52-A0C5-29BCDBF543DC}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{0BE034FD-B68B-4D52-A0C5-29BCDBF543DC}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{0BE034FD-B68B-4D52-A0C5-29BCDBF543DC}.Release|Any CPU.Build.0 = Release|Any CPU
+		{285E08F2-2E5A-4226-B867-FD3DF7C52053}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{285E08F2-2E5A-4226-B867-FD3DF7C52053}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{285E08F2-2E5A-4226-B867-FD3DF7C52053}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{285E08F2-2E5A-4226-B867-FD3DF7C52053}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -185,5 +191,6 @@ Global
 		{2C375C22-4710-438F-A4C2-325C7D091710} = {09353A03-2B0C-496B-8EB1-2CB6A22D758B}
 		{BAAAAB60-49AE-4BFE-B176-408C86746474} = {D140FA14-A6C2-4279-8A41-35BC55279DA8}
 		{0BE034FD-B68B-4D52-A0C5-29BCDBF543DC} = {09353A03-2B0C-496B-8EB1-2CB6A22D758B}
+		{285E08F2-2E5A-4226-B867-FD3DF7C52053} = {D140FA14-A6C2-4279-8A41-35BC55279DA8}
 	EndGlobalSection
 EndGlobal

src/MyTested.AspNetCore.Mvc.EntityFrameworkCore/ServiceCollectionEntityFrameworkCoreExtensions.cs

@@ -40,6 +40,14 @@ public static void ReplaceDbContext(this IServiceCollection serviceCollection)
 
             if (existingDbContext != null)
             {
+                if (existingDbContext.Lifetime != ServiceLifetime.Scoped)
+                {
+                    serviceCollection.Replace(
+                        existingDbContext.ServiceType,
+                        existingDbContext.ImplementationFactory,
+                        ServiceLifetime.Scoped);
+                }
+
                 var genericMethod = ReplaceDatabaseMethodInfo.MakeGenericMethod(existingDbContext.ImplementationType);
                 genericMethod.Invoke(null, new object[] { serviceCollection });
             }

test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test.xproj

@@ -4,7 +4,6 @@
     <VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">14.0</VisualStudioVersion>
     <VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
   </PropertyGroup>
-
   <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.Props" Condition="'$(VSToolsPath)' != ''" />
   <PropertyGroup Label="Globals">
     <ProjectGuid>285e08f2-2e5a-4226-b867-fd3df7c52053</ProjectGuid>
@@ -13,9 +12,11 @@
     <OutputPath Condition="'$(OutputPath)'=='' ">.\bin\</OutputPath>
     <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion>
   </PropertyGroup>
-
   <PropertyGroup>
     <SchemaVersion>2.0</SchemaVersion>
   </PropertyGroup>
+  <ItemGroup>
+    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
+  </ItemGroup>
   <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.targets" Condition="'$(VSToolsPath)' != ''" />
-</Project>
+</Project>

test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/ServicesTests.cs

@@ -1,6 +1,49 @@
 namespace MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test
 {
+    using System.Linq;
+    using Internal;
+    using Microsoft.EntityFrameworkCore;
+    using Microsoft.EntityFrameworkCore.Internal;
+    using Microsoft.EntityFrameworkCore.Infrastructure.Internal;
+    using Microsoft.Extensions.DependencyInjection;
+    using Setups.Common;
+    using Xunit;
+
     public class ServicesTests
     {
+        [Fact]
+        public static void ReplaceDbContextShouldReplaceNonInMemoryDatabaseWithInMemoryScopedOne()
+        {
+            var services = new ServiceCollection();
+
+            services.AddDbContext<CustomDbContext>(options =>
+                options.UseSqlServer("Server=(localdb)\\MSSQLLocalDB;Database=TestDb;Trusted_Connection=True;MultipleActiveResultSets=true;Connect Timeout=30;"));
+
+            services.ReplaceDbContext();
+
+            var serviceProvider = services.BuildServiceProvider();
+
+            var dbContextService = services.FirstOrDefault(s => s.ServiceType == typeof(CustomDbContext));
+
+            Assert.NotNull(dbContextService);
+            Assert.Equal(ServiceLifetime.Scoped, dbContextService.Lifetime);
+
+            var customDbContext = serviceProvider.GetService<CustomDbContext>();
+
+            Assert.NotNull(customDbContext);
+
+            var dbContextOptions = serviceProvider.GetService<DbContextOptions<CustomDbContext>>();
+
+            Assert.NotNull(dbContextOptions);
+            Assert.Equal(3, dbContextOptions.Extensions.Count());
+
+            var coreOptionsExtension = dbContextOptions.FindExtension<CoreOptionsExtension>();
+            var inMemoryOptionsExtension = dbContextOptions.FindExtension<InMemoryOptionsExtension>();
+            var scopedInMemoryOptionsExtension = dbContextOptions.FindExtension<ScopedInMemoryOptionsExtension>();
+
+            Assert.NotNull(coreOptionsExtension);
+            Assert.NotNull(inMemoryOptionsExtension);
+            Assert.NotNull(scopedInMemoryOptionsExtension);
+        }
     }
 }

test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/Setups/Common/CustomDbContext.cs

@@ -0,0 +1,14 @@
+namespace MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test.Setups.Common
+{
+    using Microsoft.EntityFrameworkCore;
+
+    public class CustomDbContext : DbContext
+    {
+        public CustomDbContext(DbContextOptions<CustomDbContext> options)
+            : base(options)
+        {
+        }
+
+        public DbSet<CustomModel> Models { get; set; }
+    }
+}

test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/Setups/Common/CustomModel.cs

@@ -0,0 +1,9 @@
+namespace MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test.Setups.Common
+{
+    public class CustomModel
+    {
+        public int Id { get; set; }
+
+        public string Name { get; set; }
+    }
+}

test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/project.json

@@ -15,6 +15,7 @@
     "dotnet-test-xunit": "1.0.0-*",
     "xunit": "2.1.0",
     "Microsoft.AspNetCore.Mvc": "1.0.0-*",
+    "Microsoft.EntityFrameworkCore.SqlServer": "1.0.0-*",
     "MyTested.AspNetCore.Mvc.EntityFrameworkCore": "1.0.0-*",
     "MyTested.AspNetCore.Mvc.Test": "1.0.0-*"
   },