Added ShouldHaveTestBuilderEntityFrameworkCoreExtensions with DbContext method (#125)

Author: ivaylokenov

src/MyTested.AspNetCore.Mvc.Core/Builders/Contracts/ActionResults/Created/ICreatedTestBuilder.cs

@@ -25,14 +25,14 @@ public interface ICreatedTestBuilder : IBaseTestBuilderWithResponseModel,
         IAndCreatedTestBuilder AtLocation(string location);
 
         /// <summary>
-        /// Tests whether <see cref="CreatedResult"/> location passes given assertions.
+        /// Tests whether <see cref="CreatedResult"/> location passes the given assertions.
         /// </summary>
         /// <param name="assertions">Action containing all assertions on the location.</param>
         /// <returns>The same <see cref="IAndCreatedTestBuilder"/>.</returns>
         IAndCreatedTestBuilder AtLocationPassing(Action<string> assertions);
 
         /// <summary>
-        /// Tests whether <see cref="CreatedResult"/> location passes given predicate.
+        /// Tests whether <see cref="CreatedResult"/> location passes the given predicate.
         /// </summary>
         /// <param name="predicate">Predicate testing the location.</param>
         /// <returns>The same <see cref="IAndCreatedTestBuilder"/>.</returns>

src/MyTested.AspNetCore.Mvc.Core/Builders/Contracts/ActionResults/LocalRedirect/ILocalRedirectTestBuilder.cs

@@ -26,14 +26,14 @@ public interface ILocalRedirectTestBuilder : IBaseTestBuilderWithActionResult<Lo
         IAndLocalRedirectTestBuilder ToUrl(string localUrl);
 
         /// <summary>
-        /// Tests whether <see cref="LocalRedirectResult"/> URL passes given assertions.
+        /// Tests whether <see cref="LocalRedirectResult"/> URL passes the given assertions.
         /// </summary>
         /// <param name="assertions">Action containing all assertions on the URL.</param>
         /// <returns>The same <see cref="IAndLocalRedirectTestBuilder"/>.</returns>
         IAndLocalRedirectTestBuilder ToUrlPassing(Action<string> assertions);
 
         /// <summary>
-        /// Tests whether <see cref="LocalRedirectResult"/> URL passes given predicate.
+        /// Tests whether <see cref="LocalRedirectResult"/> URL passes the given predicate.
         /// </summary>
         /// <param name="predicate">Predicate testing the URL.</param>
         /// <returns>The same <see cref="IAndLocalRedirectTestBuilder"/>.</returns>

src/MyTested.AspNetCore.Mvc.Core/Builders/Contracts/ActionResults/Redirect/IRedirectTestBuilder.cs

@@ -27,14 +27,14 @@ public interface IRedirectTestBuilder : IBaseTestBuilderWithActionResult<ActionR
         IAndRedirectTestBuilder ToUrl(string location);
 
         /// <summary>
-        /// Tests whether <see cref="RedirectResult"/> location passes given assertions.
+        /// Tests whether <see cref="RedirectResult"/> location passes the given assertions.
         /// </summary>
         /// <param name="assertions">Action containing all assertions on the location.</param>
         /// <returns>The same <see cref="IAndRedirectTestBuilder"/>.</returns>
         IAndRedirectTestBuilder ToUrlPassing(Action<string> assertions);
 
         /// <summary>
-        /// Tests whether <see cref="RedirectResult"/> location passes given predicate.
+        /// Tests whether <see cref="RedirectResult"/> location passes the given predicate.
         /// </summary>
         /// <param name="predicate">Predicate testing the location.</param>
         /// <returns>The same <see cref="IAndRedirectTestBuilder"/>.</returns>

src/MyTested.AspNetCore.Mvc.Core/Builders/Contracts/Actions/IShouldReturnTestBuilder.cs

@@ -83,14 +83,14 @@ public interface IShouldReturnTestBuilder<TActionResult> : IBaseTestBuilderWithA
         IContentTestBuilder Content(string content);
 
         /// <summary>
-        /// Tests whether <see cref="Microsoft.AspNetCore.Mvc.ContentResult"/> passes given assertions.
+        /// Tests whether <see cref="Microsoft.AspNetCore.Mvc.ContentResult"/> passes the given assertions.
         /// </summary>
         /// <param name="assertions">Action containing all assertions on the content.</param>
         /// <returns>Test builder of <see cref="IContentTestBuilder"/> type.</returns>
         IContentTestBuilder Content(Action<string> assertions);
 
         /// <summary>
-        /// Tests whether <see cref="Microsoft.AspNetCore.Mvc.ContentResult"/> passes given predicate.
+        /// Tests whether <see cref="Microsoft.AspNetCore.Mvc.ContentResult"/> passes the given predicate.
         /// </summary>
         /// <param name="predicate">Predicate testing the content.</param>
         /// <returns>Test builder of <see cref="IContentTestBuilder"/> type.</returns>

src/MyTested.AspNetCore.Mvc.Core/Builders/Contracts/Models/IModelDetailsTestBuilder.cs

@@ -9,14 +9,14 @@
     public interface IModelDetailsTestBuilder<TResponseModel> : IModelErrorTestBuilder<TResponseModel>
     {
         /// <summary>
-        /// Tests whether the returned model from the invoked action passes given assertions.
+        /// Tests whether the returned model from the invoked action passes the given assertions.
         /// </summary>
         /// <param name="assertions">Action containing all assertions on the model.</param>
         /// <returns>Test builder of <see cref="IModelErrorTestBuilder{TResponseModel}"/>.</returns>
         IModelErrorTestBuilder<TResponseModel> Passing(Action<TResponseModel> assertions);
 
         /// <summary>
-        /// Tests whether the returned model from the invoked action passes given predicate.
+        /// Tests whether the returned model from the invoked action passes the given predicate.
         /// </summary>
         /// <param name="predicate">Predicate testing the model.</param>
         /// <returns>Test builder of <see cref="IModelErrorTestBuilder{TResponseModel}"/>.</returns>

src/MyTested.AspNetCore.Mvc.Core/Builders/Controllers/ControllerServiceBuilder.cs

@@ -3,7 +3,6 @@
     using System;
     using System.Collections.Generic;
     using Contracts.Controllers;
-    using Internal.Application;
     using Microsoft.Extensions.DependencyInjection;
     using Utilities;
     using Utilities.Extensions;
@@ -18,13 +17,8 @@ public partial class ControllerBuilder<TController>
         public IAndControllerBuilder<TController> WithServiceSetupFor<TService>(Action<TService> scopedServiceSetup)
         {
             CommonValidator.CheckForNullReference(scopedServiceSetup, nameof(scopedServiceSetup));
-
-            var serviceLifetime = TestServiceProvider.GetServiceLifetime<TService>();
-            if (serviceLifetime != ServiceLifetime.Scoped)
-            {
-                throw new InvalidOperationException("The 'WithServiceSetupFor' method can be used only for services with scoped lifetime.");
-            }
-
+            ServiceValidator.ValidateScopedServiceLifetime<TService>(nameof(WithServiceSetupFor));
+            
             scopedServiceSetup(this.HttpContext.RequestServices.GetService<TService>());
 
             return this;

src/MyTested.AspNetCore.Mvc.Core/Internal/Application/TestServiceProvider.cs

@@ -58,7 +58,7 @@ public static TInstance GetService<TInstance>()
             ServiceValidator.ValidateServices();
             return Current.GetService<TInstance>();
         }
-
+        
         /// <summary>
         /// Gets collection of services. Returns null if no service of this type is not found. Throws exception if there are no registered services.
         /// </summary>

src/MyTested.AspNetCore.Mvc.Core/Utilities/Validators/ServiceValidator.cs

@@ -1,6 +1,8 @@
 namespace MyTested.AspNetCore.Mvc.Utilities.Validators
 {
+    using System;
     using Internal.Application;
+    using Microsoft.Extensions.DependencyInjection;
 
     /// <summary>
     /// Validator class containing application services validation logic.
@@ -29,6 +31,20 @@ public static void ValidateServiceExists<TService>(TService service)
                 $"{typeof(TService).Name} could not be resolved from the services provider. Before running this test case, the service should be registered in the 'StartsFrom' method and");
         }
 
+        /// <summary>
+        /// Validates whether service exists and has scoped <see cref="ServiceLifetime"/>.
+        /// </summary>
+        /// <typeparam name="TService">Type of service to validate.</typeparam>
+        /// <param name="methodName">Name of the calling method.</param>
+        public static void ValidateScopedServiceLifetime<TService>(string methodName)
+        {
+            var serviceLifetime = TestServiceProvider.GetServiceLifetime<TService>();
+            if (serviceLifetime != ServiceLifetime.Scoped)
+            {
+                throw new InvalidOperationException($"The '{methodName}' method can be used only for services with scoped lifetime.");
+            }
+        }
+
         /// <summary>
         /// Validates whether formatter exists.
         /// </summary>

src/MyTested.AspNetCore.Mvc.EntityFrameworkCore/Builders/Contracts/Data/IDbContextTestBuilder.cs

@@ -0,0 +1,27 @@
+namespace MyTested.AspNetCore.Mvc.Builders.Contracts.Data
+{
+    using System;
+    using Microsoft.EntityFrameworkCore;
+
+    /// <summary>
+    /// Used for testing <see cref="DbContext"/>.
+    /// </summary>
+    public interface IDbContextTestBuilder
+    {
+        /// <summary>
+        /// Tests whether <see cref="DbContext"/> entries pass the given assertions.
+        /// </summary>
+        /// <typeparam name="TDbContext">Type of <see cref="DbContext"/>.</typeparam>
+        /// <param name="assertions">Action containing all assertions on the <see cref="DbContext"/> entities.</param>
+        void WithEntries<TDbContext>(Action<TDbContext> assertions)
+               where TDbContext : DbContext;
+
+        /// <summary>
+        /// Tests whether <see cref="DbContext"/> entries pass the given predicate.
+        /// </summary>
+        /// <typeparam name="TDbContext">Type of <see cref="DbContext"/>.</typeparam>
+        /// <param name="predicate">Predicate testing the <see cref="DbContext"/> entities.</param>
+        void WithEntries<TDbContext>(Func<TDbContext, bool> predicate)
+               where TDbContext : DbContext;
+    }
+}

src/MyTested.AspNetCore.Mvc.EntityFrameworkCore/Builders/Data/DbContextBuilder.cs

@@ -3,7 +3,6 @@
     using System;
     using Base;
     using Contracts.Data;
-    using Internal.Application;
     using Internal.TestContexts;
     using Microsoft.EntityFrameworkCore;
     using Microsoft.Extensions.DependencyInjection;
@@ -28,17 +27,14 @@ public void WithSetup<TDbContext>(Action<TDbContext> dbContextSetup)
             where TDbContext : DbContext
         {
             CommonValidator.CheckForNullReference(dbContextSetup, nameof(dbContextSetup));
-
-            var serviceLifetime = TestServiceProvider.GetServiceLifetime<TDbContext>();
-            if (serviceLifetime != ServiceLifetime.Scoped)
-            {
-                throw new InvalidOperationException("The 'WithSetup' method can be used only for services with scoped lifetime.");
-            }
-
-            var dbContext = this.TestContext.HttpContext.RequestServices.GetRequiredService<TDbContext>();
+            ServiceValidator.ValidateScopedServiceLifetime<TDbContext>(nameof(WithSetup));
+            
+            var dbContext = this.TestContext
+                .HttpContext
+                .RequestServices
+                .GetRequiredService<TDbContext>();
 
             dbContextSetup(dbContext);
-
             dbContext.SaveChanges();
         }
     }