#283 Catching the case where non-existing data is being deleted and on SaveChanges() an exception was being thrown.

Adding tests for WithoutData with provided Set.

Author: vaptsarov

src/MyTested.AspNetCore.Mvc.EntityFrameworkCore/Builders/Data/DbContextBuilder.cs

@@ -83,7 +83,7 @@ public IAndDbContextBuilder WithSet<TDbContext, TEntity>(Action<DbSet<TEntity>>
         /// <inheritdoc />
         public IAndDbContextBuilder WithoutEntities(IEnumerable<object> entities)
             => this.WithoutEntities(dbContext => dbContext.RemoveRange(entities));
-        
+
         /// <inheritdoc />
         public IAndDbContextBuilder WithoutEntities<TDbContext>(IEnumerable<object> entities)
             where TDbContext : DbContext
@@ -113,7 +113,15 @@ public IAndDbContextBuilder WithoutEntities<TDbContext>(Action<TDbContext> dbCon
 
             var dbContext = this.TestContext.GetDbContext<TDbContext>();
             dbContextSetup(dbContext);
-            dbContext.SaveChanges();
+
+            try
+            {
+                dbContext.SaveChanges();
+            }
+            catch (DbUpdateConcurrencyException)
+            {
+                // Intentional silent fail.
+            }
 
             return this;
         }
@@ -132,7 +140,15 @@ public IAndDbContextBuilder WithoutSet<TDbContext, TEntity>(Action<DbSet<TEntity
 
             var dbContext = this.TestContext.GetDbContext<TDbContext>();
             entitySetup(dbContext.Set<TEntity>());
-            dbContext.SaveChanges();
+
+            try
+            {
+                dbContext.SaveChanges();
+            }
+            catch (DbUpdateConcurrencyException)
+            {
+                // Intentional silent fail.
+            }
 
             return this;
         }

test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/BuildersTests/ControllersTests/ControllerBuilderTests.cs

@@ -578,5 +578,99 @@ public void WithoutDataReturnsCorrectDataWhenAllTableEntitiesAreDeleted()
                 .ShouldReturn()
                 .NotFound();
         }
+
+        [Fact]
+        public void WithoutDataReturnsCorrectDataWhenDeletingNonExistingObjects()
+        {
+            MyApplication
+                .StartsFrom<TestStartup>()
+                .WithServices(services => services.AddDbContext<CustomDbContext>());
+
+            var models = new List<CustomModel> {
+                new CustomModel
+                {
+                    Id = 1,
+                    Name = "Test"
+                }};
+
+            MyController<DbContextController>
+                .Instance()
+                .WithoutData(models)
+                .Calling(c => c.GetAll())
+                .ShouldReturn()
+                .NotFound();
+        }
+
+        [Fact]
+        public void WithoutSetReturnsCorrectDataWhenWholeRangeIsRemoved()
+        {
+            MyApplication
+                .StartsFrom<TestStartup>()
+                .WithServices(services => services.AddDbContext<CustomDbContext>());
+
+            var models = new List<CustomModel> {
+                new CustomModel
+                {
+                    Id = 1,
+                    Name = "Test"
+                }};
+
+            MyController<DbContextController>
+                .Instance()
+                .WithData(models)
+                .WithoutData(data =>
+                    data.WithoutSet<CustomModel>(
+                        cm => cm.RemoveRange(models)))
+                .Calling(c => c.GetAll())
+                .ShouldReturn()
+                .NotFound();
+        }
+
+        [Fact]
+        public void WithoutSetReturnsCorrectDataWhenPartialEntitiesAreRemoved()
+        {
+            MyApplication
+                .StartsFrom<TestStartup>()
+                .WithServices(services => services.AddDbContext<CustomDbContext>());
+
+            var models = new List<CustomModel> {
+                new CustomModel
+                {
+                    Id = 1,
+                    Name = "Test1"
+                },
+                new CustomModel
+                {
+                    Id = 2,
+                    Name = "Test2"
+                }};
+
+            MyController<DbContextController>
+                .Instance()
+                .WithData(models)
+                .WithoutData(data =>
+                    data.WithoutSet<CustomModel>(
+                        cm => cm.Remove(models.Last())))
+                .Calling(c => c.GetAll())
+                .ShouldReturn()
+                .Ok(ok => ok
+                    .WithModelOfType<List<CustomModel>>()
+                    .Passing(mdls => mdls.Count == 1));
+        }
+
+        [Fact]
+        public void WithoutSetReturnsCorrectDataWhenDeletingNonExistingObjects()
+        {
+            MyApplication
+                .StartsFrom<TestStartup>()
+                .WithServices(services => services.AddDbContext<CustomDbContext>());
+
+            MyController<DbContextController>
+                .Instance()
+                .WithoutData(data => data.WithoutSet<CustomModel>(cm => cm.Remove(new CustomModel())))
+                .Calling(c => c.GetAll())
+                .ShouldReturn()
+                .NotFound();
+        }
     }
 }