Added tests for all ViewComponent plugins (closes #66)

Author: ivaylokenov

samples/MusicStore/MusicStore.Test/project.lock.json

@@ -4549,7 +4549,7 @@
         "framework": ".NETStandard,Version=v1.6",
         "dependencies": {
           "Microsoft.AspNetCore.Mvc.ViewFeatures": "1.0.0",
-          "MyTested.AspNetCore.Mvc.Controllers": "1.0.0"
+          "MyTested.AspNetCore.Mvc.Abstractions": "1.0.0"
         },
         "compile": {
           "netstandard1.6/MyTested.AspNetCore.Mvc.TempData.dll": {}
@@ -7050,7 +7050,7 @@
         "framework": ".NETFramework,Version=v4.5.1",
         "dependencies": {
           "Microsoft.AspNetCore.Mvc.ViewFeatures": "1.0.0",
-          "MyTested.AspNetCore.Mvc.Controllers": "1.0.0"
+          "MyTested.AspNetCore.Mvc.Abstractions": "1.0.0"
         },
         "compile": {
           "net451/MyTested.AspNetCore.Mvc.TempData.dll": {}

src/MyTested.AspNetCore.Mvc.Abstractions/Internal/PropertyHelper.cs

@@ -80,7 +80,7 @@ protected void ThrowNewInvalidOperationExceptionIfNull(object value, string prop
         {
             if (value == null)
             {
-                throw new InvalidOperationException($"{propertyName} could not be found on the provided {this.Type.ToFriendlyTypeName()}. The property should be specified manually by providing controller instance or using the specified helper methods.");
+                throw new InvalidOperationException($"{propertyName} could not be found on the provided {this.Type.ToFriendlyTypeName()}. The property should be specified manually by providing component instance or using the specified helper methods.");
             }
         }
 

src/MyTested.AspNetCore.Mvc.Abstractions/Internal/TestContexts/ComponentTestContext.cs

@@ -18,7 +18,7 @@ public abstract class ComponentTestContext : HttpTestContext
         private LambdaExpression methodCall;
         private IEnumerable<object> methodAttributes;
         private object model;
-
+        
         public object Component
         {
             get
@@ -141,7 +141,7 @@ public object Model
         public Action ComponentPreparationDelegate { get; set; }
 
         public Action PreMethodInvocationDelegate { get; set; }
-
+        
         public TComponent ComponentAs<TComponent>()
             where TComponent : class => this.Component as TComponent;
 

src/MyTested.AspNetCore.Mvc.Controllers/Internal/Controllers/ControllerPropertyHelper.cs

@@ -9,13 +9,12 @@ public class ControllerPropertyHelper : PropertyHelper
         private static readonly ConcurrentDictionary<Type, ControllerPropertyHelper> ControllerPropertiesCache =
             new ConcurrentDictionary<Type, ControllerPropertyHelper>();
 
-        private Func<object, ControllerContext> controllerContextGetter; // DO I NEED THESE???
-        private Func<object, ActionContext> actionContextGetter; // DO I NEED THESE?
+        private Func<object, ControllerContext> controllerContextGetter;
+        private Func<object, ActionContext> actionContextGetter;
 
         public ControllerPropertyHelper(Type controllerType)
             : base (controllerType)
         {
-            
         }
 
         public Func<object, ControllerContext> ControllerContextGetter

src/MyTested.AspNetCore.Mvc.TempData/Builders/Data/TempDataTestBuilder.cs

@@ -10,17 +10,14 @@
     public class TempDataTestBuilder : BaseDataProviderWithStringKeyTestBuilder<IAndTempDataTestBuilder>, IAndTempDataTestBuilder
     {
         internal const string TempDataName = "temp data";
-
-        private readonly ControllerTestContext testContext;
-
+        
         /// <summary>
         /// Initializes a new instance of the <see cref="TempDataTestBuilder"/> class.
         /// </summary>
-        /// <param name="testContext"><see cref="ControllerTestContext"/> containing data about the currently executed assertion chain.</param>
-        public TempDataTestBuilder(ControllerTestContext testContext)
+        /// <param name="testContext"><see cref="ComponentTestContext"/> containing data about the currently executed assertion chain.</param>
+        public TempDataTestBuilder(ComponentTestContext testContext)
             : base(testContext, TempDataName)
         {
-            this.testContext = testContext;
         }
 
         /// <summary>
@@ -36,6 +33,6 @@ public TempDataTestBuilder(ControllerTestContext testContext)
         /// When overridden in derived class provides a way to built the data provider as <see cref="IDictionary{TKey,TValue}"/>.
         /// </summary>
         /// <returns>Data provider as <see cref="IDictionary{TKey,TValue}"/>.</returns>
-        protected override IDictionary<string, object> GetDataProvider() => this.testContext.GetTempData();
+        protected override IDictionary<string, object> GetDataProvider() => this.TestContext.GetTempData();
     }
 }

src/MyTested.AspNetCore.Mvc.TempData/ComponentBuilderTempDataExtensions.cs

@@ -0,0 +1,37 @@
+namespace MyTested.AspNetCore.Mvc
+{
+    using System;
+    using Builders.Contracts.Base;
+    using Builders.Contracts.Data;
+    using Builders.Base;
+    using Builders.Data;
+    using Internal.TestContexts;
+
+    /// <summary>
+    /// Contains <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.TempDataDictionary"/> extension methods for <see cref="IBaseTestBuilderWithComponentBuilder{TBuilder}"/>.
+    /// </summary>
+    public static class ComponentBuilderTempDataExtensions
+    {
+        /// <summary>
+        /// Sets initial values to the <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.TempDataDictionary"/> on the tested component.
+        /// </summary>
+        /// <typeparam name="TBuilder">Class representing ASP.NET Core MVC test builder.</typeparam>
+        /// <param name="builder">Instance of <see cref="IBaseTestBuilderWithComponentBuilder{TBuilder}"/> type.</param>
+        /// <param name="tempDataBuilder">Action setting the <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.TempDataDictionary"/> values by using <see cref="ITempDataBuilder"/>.</param>
+        /// <returns>The same component builder.</returns>
+        public static TBuilder WithTempData<TBuilder>(
+            this IBaseTestBuilderWithComponentBuilder<TBuilder> builder,
+            Action<ITempDataBuilder> tempDataBuilder)
+            where TBuilder : IBaseTestBuilder
+        {
+            var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
+
+            actualBuilder.TestContext.ComponentPreparationDelegate += () =>
+            {
+                tempDataBuilder(new TempDataBuilder(actualBuilder.TestContext.GetTempData()));
+            };
+            
+            return actualBuilder.Builder;
+        }
+    }
+}

src/MyTested.AspNetCore.Mvc.TempData/ComponentShouldHaveTestBuilderTempDataExtensions.cs

@@ -0,0 +1,78 @@
+namespace MyTested.AspNetCore.Mvc
+{
+    using System;
+    using Builders.Base;
+    using Builders.Contracts.Base;
+    using Builders.Contracts.Data;
+    using Builders.Data;
+    using Internal.TestContexts;
+    using Utilities.Validators;
+
+    /// <summary>
+    /// Contains <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.ITempDataDictionary"/> extension methods for <see cref="IBaseTestBuilderWithComponentShouldHaveTestBuilder{TBuilder}"/>.
+    /// </summary>
+    public static class ComponentShouldHaveTestBuilderTempDataExtensions
+    {
+        /// <summary>
+        /// Tests whether the component does not set any <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.ITempDataDictionary"/> entries.
+        /// </summary>
+        /// <typeparam name="TBuilder">Class representing ASP.NET Core MVC test builder.</typeparam>
+        /// <param name="builder">Instance of <see cref="IBaseTestBuilderWithComponentShouldHaveTestBuilder{TBuilder}"/> type.</param>
+        /// <returns>The same component should have test builder.</returns>
+        public static TBuilder NoTempData<TBuilder>(this IBaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder> builder)
+            where TBuilder : IBaseTestBuilder
+        {
+            var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
+
+            if (actualBuilder.TestContext.GetTempData().Count > 0)
+            {
+                DataProviderValidator.ThrowNewDataProviderAssertionExceptionWithNoEntries(
+                    actualBuilder.TestContext,
+                    TempDataTestBuilder.TempDataName);
+            }
+
+            return actualBuilder.Builder;
+        }
+        /// <summary>
+        /// Tests whether the component sets entries in the <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.ITempDataDictionary"/>.
+        /// </summary>
+        /// <typeparam name="TBuilder">Class representing ASP.NET Core MVC test builder.</typeparam>
+        /// <param name="builder">Instance of <see cref="IBaseTestBuilderWithComponentShouldHaveTestBuilder{TBuilder}"/> type.</param>
+        /// <param name="withNumberOfEntries">Expected number of <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.ITempDataDictionary"/> entries.
+        /// If default null is provided, the test builder checks only if any entries are found.</param>
+        /// <returns>The same component should have test builder.</returns>
+        public static TBuilder TempData<TBuilder>(
+            this IBaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder> builder,
+            int? withNumberOfEntries = null)
+            where TBuilder : IBaseTestBuilder
+        {
+            var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
+
+            DataProviderValidator.ValidateDataProviderNumberOfEntries(
+                actualBuilder.TestContext,
+                TempDataTestBuilder.TempDataName,
+                withNumberOfEntries,
+                actualBuilder.TestContext.GetTempData().Count);
+
+            return actualBuilder.Builder;
+        }
+        /// <summary>
+        /// Tests whether the component sets specific entries in the <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.ITempDataDictionary"/>.
+        /// </summary>
+        /// <typeparam name="TBuilder">Class representing ASP.NET Core MVC test builder.</typeparam>
+        /// <param name="builder">Instance of <see cref="IBaseTestBuilderWithComponentShouldHaveTestBuilder{TBuilder}"/> type.</param>
+        /// <param name="tempDataTestBuilder">Builder for testing specific <see cref="Microsoft.AspNetCore.Mvc.ViewFeatures.ITempDataDictionary"/> entries.</param>
+        /// <returns>The same component should have test builder.</returns>
+        public static TBuilder TempData<TBuilder>(
+            this IBaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder> builder,
+            Action<ITempDataTestBuilder> tempDataTestBuilder)
+            where TBuilder : IBaseTestBuilder
+        {
+            var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
+
+            tempDataTestBuilder(new TempDataTestBuilder(actualBuilder.TestContext));
+
+            return actualBuilder.Builder;
+        }
+    }
+}

src/MyTested.AspNetCore.Mvc.TempData/ControllerBuilderTempDataExtensions.cs

@@ -1,22 +1,22 @@
-namespace MyTested.AspNetCore.Mvc.Internal.Controllers
+namespace MyTested.AspNetCore.Mvc.Internal
 {
     using System;
     using System.Collections.Concurrent;
     using System.Linq;
     using System.Reflection;
     using Microsoft.AspNetCore.Mvc.ViewFeatures;
 
-    public class TempDataControllerPropertyHelper : ControllerPropertyHelper
+    public class TempDataPropertyHelper : PropertyHelper
     {
-        private static readonly ConcurrentDictionary<Type, TempDataControllerPropertyHelper> TempDataControllerPropertiesCache =
-            new ConcurrentDictionary<Type, TempDataControllerPropertyHelper>();
+        private static readonly ConcurrentDictionary<Type, TempDataPropertyHelper> TempDataPropertiesCache =
+            new ConcurrentDictionary<Type, TempDataPropertyHelper>();
 
         private static readonly TypeInfo TypeOfTempDataDictionary = typeof(ITempDataDictionary).GetTypeInfo();
 
         private Func<object, ITempDataDictionary> tempDataGetter;
 
-        public TempDataControllerPropertyHelper(Type controllerType)
-            : base(controllerType)
+        public TempDataPropertyHelper(Type type)
+            : base(type)
         {
         }
 
@@ -33,15 +33,15 @@ public Func<object, ITempDataDictionary> TempDataGetter
             }
         }
 
-        public static TempDataControllerPropertyHelper GetTempDataProperties<TController>()
+        public static TempDataPropertyHelper GetTempDataProperties<TController>()
             where TController : class
         {
             return GetTempDataProperties(typeof(TController));
         }
 
-        public static TempDataControllerPropertyHelper GetTempDataProperties(Type type)
+        public static TempDataPropertyHelper GetTempDataProperties(Type type)
         {
-            return TempDataControllerPropertiesCache.GetOrAdd(type, _ => new TempDataControllerPropertyHelper(type));
+            return TempDataPropertiesCache.GetOrAdd(type, _ => new TempDataPropertyHelper(type));
         }
 
         private void TryCreateTempDataGetterDelegate()

src/MyTested.AspNetCore.Mvc.TempData/Internal/Controllers/TempDataControllerPropertyHelper.cs renamed to src/MyTested.AspNetCore.Mvc.TempData/Internal/TempDataPropertyHelper.cs

@@ -1,14 +1,14 @@
 namespace MyTested.AspNetCore.Mvc.Internal.TestContexts
 {
-    using Controllers;
     using Microsoft.AspNetCore.Mvc;
     using Microsoft.AspNetCore.Mvc.ViewFeatures;
 
-    public static class ControllerTestContextTempDataExtensions
+    public static class ComponentTestContextTempDataExtensions
     {
-        public static ITempDataDictionary GetTempData(this ControllerTestContext testContext)
+        public static ITempDataDictionary GetTempData(this ComponentTestContext testContext)
             => testContext.ComponentAs<Controller>()?.TempData
-            ?? TempDataControllerPropertyHelper
+            ?? testContext.ComponentAs<ViewComponent>()?.ViewContext?.TempData
+            ?? TempDataPropertyHelper
                 .GetTempDataProperties(testContext.Component.GetType())
                 .TempDataGetter(testContext.Component);
     }