Merge branch 'development' of https://github.com/ivaylokenov/MyTested.AspNetCore.Mvc into tests/mvc-universe

Author: u-ashikov

BACKERS.md

@@ -32,10 +32,10 @@ Funds donated via both platforms are used for development and marketing purposes
 
 ## Generous Backers
 - Plamen Petkov
+- [Svetlin Nakov](https://nakov.com/)
 
 ## Kickstarters
 - Ines Ivanova from [C# In 15 Minutes](https://www.youtube.com/channel/UCljus-YO63ae0vwuuPWDasA)
-- Rusko Kumovski
 
 ## Top Backers
 - Bace Kar pod prekor Silovio aka Brudlordo
@@ -51,6 +51,7 @@ Funds donated via both platforms are used for development and marketing purposes
 - Viktor Klisurski
 - Desi Zlatanova
 - Tsenko Tsenov
+- [Ivan Ivanov](https://github.com/csyntax)
 
 ## Generous One-Time Donations
 - My-Amazing-Store
@@ -64,13 +65,15 @@ Funds donated via both platforms are used for development and marketing purposes
 - Pavel Doychinov
 
 ## Backers
-Aleksandur Gyuzelov, Bogomil Stoev, Desislav Stoyanov, Emil Venkov, Georgi Krasimirov Georgiev, Kristiyan Mihailov, Lyubomir Krastanov, Nikolay Boyadzhiev, Nikolay Mihaylov, Rositsa Nenova, Slavi Bozhikov, Vasil Bonev, Yuriy Georgiev, Калин Ценков, Velina Getova, Gabriel Daskalov
+Aleksandur Gyuzelov, Bogomil Stoev, Desislav Stoyanov, Emil Venkov, Georgi Krasimirov Georgiev, Kristiyan Mihailov, Lyubomir Krastanov, Nikolay Boyadzhiev, Nikolay Mihaylov, Rositsa Nenova, Slavi Bozhikov, Vasil Bonev, Yuriy Georgiev, Калин Ценков, Velina Getova
 
 ## One-Time Donations
-Philip Shishov, Mariya Georgieva, Tanya Georgieva, Danny Berova, German Dimitrov, Aleksandar Evangelatov, Anton Petrov, Hristo Ivanov, Anna Stambolieva, Nedelcho Penev, Yulian Ashikov, Boyana Aleksova, Plamen Haralambiev, Victoria Karamanova, Ivaylo Goranov, Aneliya Drazheva, Zdravko Yakimov, Vanya Kuncheva, Georgi Petrov, Stanimir Pavlov, Teodor Stefanov, Stefan Minchev, Simon Valentinova Kochova, Marin Marinov, Petar Peshev, Radoslav Astardzhiev, Dimitar Radkov, Aleksandar Tsvetkov, Georgi Dragnev, Veselin Neychev, Kaloyan Kolev, Andrey Blagoev, Yordan Penev, Ventsislav Yordanov, Nikolay Georgiev, Siyana Yasenova Zdravkova, Ani Kalpachka, Gergana Damyanova, Petya Koleva, Dyanko Petkov, Nikola Kolchakov, Borislava Hranova
+Yuliyana Tahova, Philip Shishov, Mariya Georgieva, Tanya Georgieva, Danny Berova, German Dimitrov, Aleksandar Evangelatov, Anton Petrov, Hristo Ivanov, Anna Stambolieva, Nedelcho Penev, Yulian Ashikov, Boyana Aleksova, Plamen Haralambiev, Victoria Karamanova, Ivaylo Goranov, Aneliya Drazheva, Zdravko Yakimov, Vanya Kuncheva, Georgi Petrov, Stanimir Pavlov, Teodor Stefanov, Stefan Minchev, Simon Valentinova Kochova, Marin Marinov, Petar Peshev, Radoslav Astardzhiev, Dimitar Radkov, Aleksandar Tsvetkov, Georgi Dragnev, Veselin Neychev, Kaloyan Kolev, Andrey Blagoev, Yordan Penev, Ventsislav Yordanov, Nikolay Georgiev, Siyana Yasenova Zdravkova, Ani Kalpachka, Gergana Damyanova, Petya Koleva, Dyanko Petkov, Nikola Kolchakov, Borislava Hranova
 
 ## Previous Supporters
+- Gabriel Daskalov
+- Rusko Kumovski
 - Kris Petrov
 - Mihail Duchev
 - Nikola Stankov
-- Peter
+- Peter

src/MyTested.AspNetCore.Mvc.Controllers.Attributes/Builders/Attributes/MiddlewareFilterAttributeTestBuilder.cs

@@ -0,0 +1,56 @@
+namespace MyTested.AspNetCore.Mvc.Builders.Attributes
+{
+    using System;
+    using Microsoft.AspNetCore.Mvc;
+    using Contracts.Attributes;
+    using Internal.TestContexts;
+    using Utilities;
+
+    /// <summary>
+    /// Used for testing <see cref="MiddlewareFilterAttribute"/>.
+    /// </summary>
+    public class MiddlewareFilterAttributeTestBuilder : BaseAttributeTestBuilderWithOrder<MiddlewareFilterAttribute>,
+        IAndMiddlewareFilterAttributeTestBuilder
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="MiddlewareFilterAttributeTestBuilder"/> class.
+        /// </summary>
+        /// <param name="testContext"><see cref="ComponentTestContext"/> containing data about the currently executed assertion chain.</param>
+        /// <param name="failedValidationAction">Action to call in case of failed validation.</param>
+        public MiddlewareFilterAttributeTestBuilder(
+            ComponentTestContext testContext,
+            Action<string, string> failedValidationAction)
+            : base(testContext, nameof(MiddlewareFilterAttribute), failedValidationAction)
+        => this.Attribute = new MiddlewareFilterAttribute(typeof(object));
+
+        /// <inheritdoc />
+        public IAndMiddlewareFilterAttributeTestBuilder OfType(Type configurationType)
+        {
+            this.Attribute = new MiddlewareFilterAttribute(configurationType);
+            this.Validations.Add((expected, actual) =>
+            {
+                var expectedType = expected.ConfigurationType;
+                var actualType = actual.ConfigurationType;
+
+                if (Reflection.AreDifferentTypes(expectedType, actualType))
+                {
+                    this.FailedValidationAction(
+                        $"{this.ExceptionMessagePrefix}'{expectedType.ToFriendlyTypeName()}' type",
+                        $"in fact found '{actualType.ToFriendlyTypeName()}'");
+                }
+            });
+
+            return this;
+        }
+
+        /// <inheritdoc />
+        public IAndMiddlewareFilterAttributeTestBuilder WithOrder(int order)
+        {
+            this.ValidateOrder(order);
+            return this;
+        }
+
+        /// <inheritdoc />
+        public IMiddlewareFilterAttributeTestBuilder AndAlso() => this;
+    }
+}

src/MyTested.AspNetCore.Mvc.Controllers.Attributes/Builders/Attributes/ProducesAttributeTestBuilder.cs

@@ -70,7 +70,7 @@ public IAndProducesAttributeTestBuilder WithContentTypes(string contentType, par
             => this.WithContentTypes(new List<string>(otherContentTypes) { contentType });
 
         /// <inheritdoc />
-        public IAndProducesAttributeTestBuilder WithType(Type type)
+        public IAndProducesAttributeTestBuilder OfType(Type type)
         {
             this.Attribute.Type = type;
             this.Validations.Add((expected, actual) =>

src/MyTested.AspNetCore.Mvc.Controllers.Attributes/Builders/Contracts/Attributes/IAndMiddlewareFilterAttributeTestBuilder.cs

@@ -0,0 +1,14 @@
+namespace MyTested.AspNetCore.Mvc.Builders.Contracts.Attributes
+{
+    /// <summary>
+    /// Used for adding AndAlso() method to the <see cref="Microsoft.AspNetCore.Mvc.MiddlewareFilterAttribute"/> tests.
+    /// </summary>
+    public interface IAndMiddlewareFilterAttributeTestBuilder : IMiddlewareFilterAttributeTestBuilder
+    {
+        /// <summary>
+        /// AndAlso method for better readability when testing <see cref="Microsoft.AspNetCore.Mvc.MiddlewareFilterAttribute"/>.
+        /// </summary>
+        /// <returns>The same <see cref="IMiddlewareFilterAttributeTestBuilder"/>.</returns>
+        IMiddlewareFilterAttributeTestBuilder AndAlso();
+    }
+}

src/MyTested.AspNetCore.Mvc.Controllers.Attributes/Builders/Contracts/Attributes/IMiddlewareFilterAttributeTestBuilder.cs

@@ -0,0 +1,18 @@
+namespace MyTested.AspNetCore.Mvc.Builders.Contracts.Attributes
+{
+    using System;
+
+    /// <summary>
+    /// Used for testing <see cref="Microsoft.AspNetCore.Mvc.MiddlewareFilterAttribute"/>.
+    /// </summary>
+    public interface IMiddlewareFilterAttributeTestBuilder : IBaseAttributeTestBuilderWithOrder<IAndMiddlewareFilterAttributeTestBuilder>
+    {
+        /// <summary>
+        /// Tests whether a <see cref="Microsoft.AspNetCore.Mvc.MiddlewareFilterAttribute"/>
+        /// has the same <see cref="Microsoft.AspNetCore.Mvc.MiddlewareFilterAttribute.ConfigurationType"/> value as the provided one.
+        /// </summary>
+        /// <param name="configurationType">A type which configures a middleware pipeline.</param>
+        /// <returns>The same <see cref="IMiddlewareFilterAttributeTestBuilder"/>.</returns>
+        IAndMiddlewareFilterAttributeTestBuilder OfType(Type configurationType);
+    }
+}

src/MyTested.AspNetCore.Mvc.Controllers.Attributes/Builders/Contracts/Attributes/IProducesAttributeTestBuilder.cs

@@ -39,6 +39,6 @@ public interface IProducesAttributeTestBuilder : IBaseAttributeTestBuilderWithOr
         /// </summary>
         /// <param name="type">Expected type value.</param>
         /// <returns>The same <see cref="IAndProducesAttributeTestBuilder"/>.</returns>
-        IAndProducesAttributeTestBuilder WithType(Type type);
+        IAndProducesAttributeTestBuilder OfType(Type type);
     }
 }

src/MyTested.AspNetCore.Mvc.Controllers.Attributes/ControllerActionAttributesTestBuilderExtensions.cs

@@ -272,7 +272,7 @@ public static TAttributesTestBuilder SpecifyingProduction<TAttributesTestBuilder
             Type withType)
             where TAttributesTestBuilder : IControllerActionAttributesTestBuilder<TAttributesTestBuilder>
             => controllerActionAttributesTestBuilder
-                .SpecifyingProduction(production => production.WithType(withType));
+                .SpecifyingProduction(production => production.OfType(withType));
 
         /// <summary>
         /// Tests whether the collected attributes contain <see cref="ProducesAttribute"/>.
@@ -290,7 +290,7 @@ public static TAttributesTestBuilder SpecifyingProduction<TAttributesTestBuilder
             where TAttributesTestBuilder : IControllerActionAttributesTestBuilder<TAttributesTestBuilder>
             => controllerActionAttributesTestBuilder
                 .SpecifyingProduction(production => production
-                    .WithType(withType)
+                    .OfType(withType)
                     .WithContentTypes(withContentTypes));
 
         /// <summary>
@@ -345,6 +345,56 @@ public static TAttributesTestBuilder SpecifyingProduction<TAttributesTestBuilder
             return actualBuilder.AttributesTestBuilder;
         }
 
+        /// <summary>
+        /// Tests whether the collected attributes contain <see cref="MiddlewareFilterAttribute"/>.
+        /// </summary>
+        /// <param name="controllerActionAttributesTestBuilder">
+        /// Instance of <see cref="IControllerActionAttributesTestBuilder{TAttributesTestBuilder}"/> type.
+        /// </param>
+        /// <param name="configurationType">A type which configures a middleware pipeline.</param>
+        /// <returns>The same attributes test builder.</returns>
+        public static TAttributesTestBuilder SpecifyingMiddleware<TAttributesTestBuilder>(
+            this IControllerActionAttributesTestBuilder<TAttributesTestBuilder> controllerActionAttributesTestBuilder,
+            Type configurationType)
+            where TAttributesTestBuilder : IControllerActionAttributesTestBuilder<TAttributesTestBuilder>
+            => controllerActionAttributesTestBuilder
+                .SpecifyingMiddleware(middleware => middleware.OfType(configurationType));
+
+        /// <summary>
+        /// Tests whether the collected attributes contain <see cref="MiddlewareFilterAttribute"/>.
+        /// </summary>
+        /// <param name="controllerActionAttributesTestBuilder">
+        /// Instance of <see cref="IControllerActionAttributesTestBuilder{TAttributesTestBuilder}"/> type.
+        /// </param>
+        /// <param name="middlewareFilterAttributeBuilder">Expected <see cref="MiddlewareFilterAttribute"/> builder.</param>
+        /// <returns>The same attributes test builder.</returns>
+        public static TAttributesTestBuilder SpecifyingMiddleware<TAttributesTestBuilder>(
+            this IControllerActionAttributesTestBuilder<TAttributesTestBuilder> controllerActionAttributesTestBuilder,
+            Action<IMiddlewareFilterAttributeTestBuilder> middlewareFilterAttributeBuilder)
+            where TAttributesTestBuilder : IControllerActionAttributesTestBuilder<TAttributesTestBuilder>
+        {
+            var actualBuilder = (BaseAttributesTestBuilder<TAttributesTestBuilder>)controllerActionAttributesTestBuilder;
+
+            actualBuilder.ContainingAttributeOfType<MiddlewareFilterAttribute>();
+
+            actualBuilder.Validations.Add(attrs =>
+            {
+                var newMiddlewareFilterAttributeBuilder = new MiddlewareFilterAttributeTestBuilder(
+                    actualBuilder.TestContext,
+                    actualBuilder.ThrowNewAttributeAssertionException);
+
+                middlewareFilterAttributeBuilder(newMiddlewareFilterAttributeBuilder);
+
+                var expectedAttribute = newMiddlewareFilterAttributeBuilder.GetAttribute();
+                var actualAttribute = actualBuilder.GetAttributeOfType<MiddlewareFilterAttribute>(attrs);
+
+                var validations = newMiddlewareFilterAttributeBuilder.GetAttributeValidations();
+                validations.ForEach(v => v(expectedAttribute, actualAttribute));
+            });
+
+            return actualBuilder.AttributesTestBuilder;
+        }
+
         /// <summary>
         /// Tests whether the collected attributes contain <see cref="RequireHttpsAttribute"/>.
         /// </summary>

test/MyTested.AspNetCore.Mvc.Abstractions.Test/UtilitiesTests/ExpressionParserTests.cs

@@ -153,7 +153,7 @@ public void GetMethodAttributesShouldReturnProperAttributes()
             };
 
             Assert.NotNull(attributes);
-            Assert.Equal(8, attributes.Count);
+            Assert.Equal(9, attributes.Count);
 
             var allAttributesArePresent = expectedTypes.All(attributes.Contains);
             Assert.True(allAttributesArePresent);

test/MyTested.AspNetCore.Mvc.Controllers.Attributes.Test/BuildersTests/AttributesTests/ActionAttributesTestBuilderTests.cs

@@ -3,6 +3,7 @@
     using System.Collections.Generic;
     using Exceptions;
     using Microsoft.AspNetCore.Mvc;
+    using Setups.Pipelines;
     using Setups;
     using Setups.Controllers;
     using Setups.Models;
@@ -499,7 +500,7 @@ public void SpecifyingProductionShouldNotThrowExceptionWithCorrectAttributeTypeA
                 .ShouldHave()
                 .ActionAttributes(attributes => attributes
                     .SpecifyingProduction(production => production
-                        .WithType(typeof(RequestModel))
+                        .OfType(typeof(RequestModel))
                         .WithContentTypes("application/javascript", "application/pdf")
                         .WithOrder(2)));
         }
@@ -525,7 +526,7 @@ public void SpecifyingProductionShouldNotThrowExceptionWithCorrectAttributeTypeA
                 .ShouldHave()
                 .ActionAttributes(attributes => attributes
                     .SpecifyingProduction(production => production
-                        .WithType(typeof(RequestModel))
+                        .OfType(typeof(RequestModel))
                         .AndAlso()
                         .WithContentTypes(new List<string> { "application/pdf", "application/javascript" })
                         .AndAlso()
@@ -549,6 +550,138 @@ public void SpecifyingProductionShouldThrowExceptionWithCorrectAttributeAndWrong
                 "When calling Post action in ApiController expected action to have ProducesAttribute with order of 1, but in fact found 2.");
         }
 
+        [Fact]
+        public void SpecifyingMiddlewareShouldNotThrowExceptionWithCorrectAttribute()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.VariousAttributesAction())
+                .ShouldHave()
+                .ActionAttributes(attributes => attributes
+                    .SpecifyingMiddleware(typeof(MyPipeline)));
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldThrowExceptionWithMissingAttribute()
+        {
+            Test.AssertException<AttributeAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.NormalActionWithAttributes())
+                        .ShouldHave()
+                        .ActionAttributes(attributes => attributes
+                            .SpecifyingMiddleware(typeof(MyPipeline)));
+                },
+                "When calling NormalActionWithAttributes action in MvcController expected action to have MiddlewareFilterAttribute, but in fact such was not found.");
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldThrowExceptionWithCorrectAttributeAndWrongConfigurationType()
+        {
+            Test.AssertException<AttributeAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.VariousAttributesAction())
+                        .ShouldHave()
+                        .ActionAttributes(attributes => attributes
+                            .SpecifyingMiddleware(typeof(MyOtherPipeline)));
+                },
+                "When calling VariousAttributesAction action in MvcController expected action to have MiddlewareFilterAttribute with 'MyOtherPipeline' type, but in fact found 'MyPipeline'.");
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldNotThrowExceptionWithCorrectAttributeConfigurationType()
+        {
+            MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.VariousAttributesAction())
+                        .ShouldHave()
+                        .ActionAttributes(attributes => attributes
+                            .SpecifyingMiddleware(middleware => middleware
+                                .OfType(typeof(MyPipeline))));
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldThrowExceptionWithWrongConfigurationType()
+        {
+            Test.AssertException<AttributeAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.VariousAttributesAction())
+                        .ShouldHave()
+                        .ActionAttributes(attributes => attributes
+                            .SpecifyingMiddleware(middleware => middleware
+                                .OfType(typeof(MyOtherPipeline))));
+                },
+                "When calling VariousAttributesAction action in MvcController expected action to have MiddlewareFilterAttribute with 'MyOtherPipeline' type, but in fact found 'MyPipeline'.");
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldThrowExceptionWithCorrectAttributeAndWrongOrder()
+        {
+            Test.AssertException<AttributeAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.VariousAttributesAction())
+                        .ShouldHave()
+                        .ActionAttributes(attributes => attributes
+                            .SpecifyingMiddleware(middleware => middleware.WithOrder(1)));
+                },
+                "When calling VariousAttributesAction action in MvcController expected action to have MiddlewareFilterAttribute with order of 1, but in fact found 2.");
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldNotThrowExceptionWithCorrectAttributeTypeAndUsingBuilderForOrder()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.VariousAttributesAction())
+                .ShouldHave()
+                .ActionAttributes(attributes => attributes
+                    .SpecifyingMiddleware(middleware => middleware.WithOrder(2)));
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldNotThrowExceptionWithCorrectAttributeConfigTypeAndUsingBuilderForOrder()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.VariousAttributesAction())
+                .ShouldHave()
+                .ActionAttributes(attributes => attributes
+                    .SpecifyingMiddleware(middleware => middleware
+                        .OfType(typeof(MyPipeline))
+                        .AndAlso()
+                        .WithOrder(2)));
+        }
+
+        [Fact]
+        public void SpecifyingMiddlewareShouldThrowExceptionWithCorrectAttributeConfigTypeAndUsingBuilderForOrderWithWrongOrder()
+        {
+            Test.AssertException<AttributeAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.VariousAttributesAction())
+                        .ShouldHave()
+                        .ActionAttributes(attributes => attributes
+                            .SpecifyingMiddleware(middleware => middleware
+                                .OfType(typeof(MyPipeline))
+                                .AndAlso()
+                                .WithOrder(1)));
+                },
+                "When calling VariousAttributesAction action in MvcController expected action to have MiddlewareFilterAttribute with order of 1, but in fact found 2.");
+        }
+
         [Fact]
         public void RequiringHttpsShouldNotThrowExceptionWithTheAttribute()
         {