Tests & Fixed Builder Implementation (#178)

Author: hristo.h

src/MyTested.AspNetCore.Mvc.ModelState/Builders/Models/ModelStateBuilder.cs

@@ -41,11 +41,18 @@ public IAndModelStateBuilder WithErrors(IDictionary<string, string> errors)
 
         /// <inheritdoc />
         public IAndModelStateBuilder WithErrors(object errors)
-            => this.WithErrors(new RouteValueDictionary(errors));
+        {
+            var errorsAsDictionary = new RouteValueDictionary(errors);
+            errorsAsDictionary
+                .ForEach(err => this.AddError(err.Key, err.Value.ToString()));
 
+            return this;
+        }
+            
         /// <inheritdoc />
         public IModelStateBuilder AndAlso() => this;
 
-        private void AddError(string key, string errorMessage) => this.ModelState.AddModelError(key, errorMessage);
+        private void AddError(string key, string errorMessage) 
+            => this.ModelState.AddModelError(key, errorMessage);
     }
 }

test/MyTested.AspNetCore.Mvc.ModelState.Test/BuildersTests/ModelsTests/ModelStateBuilderTests.cs

@@ -0,0 +1,62 @@
+namespace MyTested.AspNetCore.Mvc.Test.BuildersTests.ModelsTests
+{
+    using Setups;
+    using Setups.Controllers;
+    using Xunit;
+    using System.Collections.Generic;
+
+    public class ModelStateBuilderTests
+    {
+        [Fact]
+        public void WithModelStateWithErrorShouldWorkCorrectly()
+        {
+            var requestBody = TestObjectFactory.GetValidRequestModel();
+
+            MyController<MvcController>
+                .Instance()
+                .WithModelState(modelState => modelState
+                    .WithError("TestError", "Invalid value"))
+                .Calling(c => c.BadRequestWithModelState(requestBody))
+                .ShouldReturn()
+                .BadRequest();
+        }
+
+        [Fact]
+        public void WithModelStateWithErrorsDictionaryShouldWorkCorrectly()
+        {
+            var requestBody = TestObjectFactory.GetValidRequestModel();
+            var errorsDictionary = new Dictionary<string, string>()
+            {
+                ["First"] = "SomeError",
+                ["Second"] = "AnotherError",
+            };
+
+            MyController<MvcController>
+                .Instance()
+                .WithModelState(modelState => modelState
+                    .WithErrors(errorsDictionary))
+                .Calling(c => c.BadRequestWithModelState(requestBody))
+                .ShouldReturn()
+                .BadRequest();
+        }
+
+        [Fact]
+        public void WithModelStateWithErrorsObjectShouldWorkCorrectly()
+        {
+            var requestBody = TestObjectFactory.GetValidRequestModel();
+            var errorsObjcet = new
+            {
+                First = "SomeError",
+                Second = "AnotherError",
+            };
+
+            MyController<MvcController>
+                .Instance()
+                .WithModelState(modelState => modelState
+                    .WithErrors(errorsObjcet))
+                .Calling(c => c.BadRequestWithModelState(requestBody))
+                .ShouldReturn()
+                .BadRequest();
+        }
+    }
+}